From: Liav Albani <liavalb@gmail.com>
To: qemu-devel@nongnu.org
Cc: ani@anisinha.ca, imammedo@redhat.com,
Liav Albani <liavalb@gmail.com>,
mst@redhat.com
Subject: [PATCH v3 0/4] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table
Date: Sat, 26 Feb 2022 08:30:15 +0200 [thread overview]
Message-ID: <20220226063019.1112654-1-liavalb@gmail.com> (raw)
This can allow the guest OS to determine more easily if i8042 controller
is present in the system or not, so it doesn't need to do probing of the
controller, but just initialize it immediately, before enumerating the
ACPI AML namespace.
To allow "flexible" indication, I don't hardcode the bit at location 1
as on in the IA-PC boot flags, but try to search for i8042 on the ISA
bus to verify it exists in the system.
Why this is useful you might ask - this patch allows the guest OS to
probe and use the i8042 controller without decoding the ACPI AML blob
at all. For example, as a developer of the SerenityOS kernel, I might
want to allow people to not try to decode the ACPI AML namespace (for
now, we still don't support ACPI AML as it's a work in progress), but
still to not probe for the i8042 but just use it after looking in the
IA-PC boot flags in the ACPI FADT table.
A note about this version of the patch series: I changed the assertion
checking if the ISA bus exists to a if statement, because I can see how
in the future someone might want to run a x86 machine without an ISA bus
so we should not assert if someone calls the ISA check device existence
function but return FALSE gracefully.
If someone thinks this is wrong, I'm more than happy to discuss and fix
the code :)
Liav Albani (4):
hw/isa: add function to check for existence of device by its type
tests/acpi: i386: allow FACP acpi table changes
hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT
table
tests/acpi: i386: update FACP table differences
hw/acpi/aml-build.c | 7 ++++++-
hw/i386/acpi-build.c | 8 ++++++++
hw/i386/acpi-microvm.c | 9 +++++++++
hw/isa/isa-bus.c | 23 +++++++++++++++++++++++
include/hw/acpi/acpi-defs.h | 1 +
include/hw/isa/isa.h | 1 +
tests/data/acpi/q35/FACP | Bin 244 -> 244 bytes
tests/data/acpi/q35/FACP.nosmm | Bin 244 -> 244 bytes
tests/data/acpi/q35/FACP.slic | Bin 244 -> 244 bytes
tests/data/acpi/q35/FACP.xapic | Bin 244 -> 244 bytes
10 files changed, 48 insertions(+), 1 deletion(-)
--
2.35.1
next reply other threads:[~2022-02-26 6:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 6:30 Liav Albani [this message]
2022-02-26 6:30 ` [PATCH v3 1/4] hw/isa: add function to check for existence of device by its type Liav Albani
2022-02-27 7:27 ` Ani Sinha
2022-02-27 19:03 ` Liav Albani
2022-02-26 6:30 ` [PATCH v3 2/4] tests/acpi: i386: allow FACP acpi table changes Liav Albani
2022-02-27 6:57 ` Ani Sinha
2022-02-26 6:30 ` [PATCH v3 3/4] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table Liav Albani
2022-02-27 6:56 ` Ani Sinha
2022-02-27 18:59 ` Liav Albani
2022-02-27 10:48 ` Bernhard Beschow
2022-02-27 18:58 ` Liav Albani
2022-02-27 21:33 ` Bernhard Beschow
2022-02-28 5:01 ` Ani Sinha
2022-02-28 6:56 ` Ani Sinha
2022-02-28 8:47 ` Ani Sinha
2022-02-26 6:30 ` [PATCH v3 4/4] tests/acpi: i386: update FACP table differences Liav Albani
2022-02-27 7:05 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220226063019.1112654-1-liavalb@gmail.com \
--to=liavalb@gmail.com \
--cc=ani@anisinha.ca \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).