From: Warner Losh <imp@bsdimp.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
arrowd@FreeBSD.org, Kyle Evans <kevans@FreeBSD.org>,
Richard Henderson <richard.henderson@linaro.org>,
def@FreeBSD.org, jrtc27@FreeBSD.org, Warner Losh <imp@bsdimp.com>,
Brad Smith <brad@comstyle.com>
Subject: [PATCH v2 08/16] bsd-user: Remove bsd_type
Date: Sat, 26 Feb 2022 10:07:36 -0700 [thread overview]
Message-ID: <20220226170744.76615-9-imp@bsdimp.com> (raw)
In-Reply-To: <20220226170744.76615-1-imp@bsdimp.com>
Remove keeping track of which type of bsd we're running on. It's no
longer referenced in the code. Building bsd-user on NetBSD or OpenBSD
isn't possible, let alone running that code. Stop pretending that we can
do the cross BSD thing since there's been a large divergence since 2000
that makes this nearly impossible between FreeBSD and {Net,Open}BSD and
at least quite difficult between NetBSD and OpenBSD.
Signed-off-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Kyle Evans <kevans@FreeBSD.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
bsd-user/main.c | 2 --
bsd-user/qemu.h | 7 -------
2 files changed, 9 deletions(-)
diff --git a/bsd-user/main.c b/bsd-user/main.c
index bddb830e99b..88d347d05eb 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -96,7 +96,6 @@ unsigned long reserved_va;
static const char *interp_prefix = CONFIG_QEMU_INTERP_PREFIX;
const char *qemu_uname_release;
-enum BSDType bsd_type;
char qemu_proc_pathname[PATH_MAX]; /* full path to exeutable */
unsigned long target_maxtsiz = TARGET_MAXTSIZ; /* max text size */
@@ -284,7 +283,6 @@ int main(int argc, char **argv)
const char *gdbstub = NULL;
char **target_environ, **wrk;
envlist_t *envlist = NULL;
- bsd_type = HOST_DEFAULT_BSD_TYPE;
char *argv0 = NULL;
adjust_ssize();
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index 02921ac8b3b..e5742bd6c03 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -29,13 +29,6 @@
extern char **environ;
-enum BSDType {
- target_freebsd,
- target_netbsd,
- target_openbsd,
-};
-extern enum BSDType bsd_type;
-
#include "exec/user/thunk.h"
#include "target_arch.h"
#include "syscall_defs.h"
--
2.33.1
next prev parent reply other threads:[~2022-02-26 17:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 17:07 [PATCH v2 00/16] bsd-user: Start upstreaming the system calls Warner Losh
2022-02-26 17:07 ` [PATCH v2 01/16] bsd-user/main.c: Drop syscall flavor arg -bsd Warner Losh
2022-02-26 17:07 ` [PATCH v2 02/16] bsd-user/x86_64/target_arch_cpu.h: int $80 never was a BSD system call on amd64 Warner Losh
2022-02-26 17:07 ` [PATCH v2 03/16] bsd-user/x86_64/target_arch_cpu.h: Remove openbsd syscall Warner Losh
2022-02-26 17:07 ` [PATCH v2 04/16] bsd-user/i386/target_arch_cpu.h: " Warner Losh
2022-02-26 17:07 ` [PATCH v2 05/16] bsd-user/arm/target_arch_cpu.h: Only support FreeBSD sys calls Warner Losh
2022-02-26 17:07 ` [PATCH v2 06/16] bsd-user/arm/target_arch_thread.h: Assume a FreeBSD target Warner Losh
2022-02-26 17:07 ` [PATCH v2 07/16] bsd-user/x86_64/target_arch_thread.h: " Warner Losh
2022-02-26 17:07 ` Warner Losh [this message]
2022-02-26 17:07 ` [PATCH v2 09/16] bsd-user/freebsd/os-syscall.c: Move syscall processing here Warner Losh
2022-02-26 17:07 ` [PATCH v2 10/16] bsd-user: Move system call building to os-syscall.c Warner Losh
2022-02-26 17:07 ` [PATCH v2 11/16] bsd-user/sycall.c: Now obsolete, remove Warner Losh
2022-02-26 17:07 ` [PATCH v2 12/16] bsd-user/freebsd/os-syscall.c: Add get_errno and host_to_target_errno Warner Losh
2022-02-26 17:07 ` [PATCH v2 13/16] bsd-user/bsd-file.h: Implementation details for the filesystem calls Warner Losh
2022-02-27 3:20 ` Richard Henderson
2022-02-26 17:07 ` [PATCH v2 14/16] bsd-user: introduce target.h Warner Losh
2022-02-26 17:07 ` [PATCH v2 15/16] bsd-user: Define target_arg64 Warner Losh
2022-02-26 17:07 ` [PATCH v2 16/16] bsd-user: Add safe system call macros Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220226170744.76615-9-imp@bsdimp.com \
--to=imp@bsdimp.com \
--cc=arrowd@FreeBSD.org \
--cc=brad@comstyle.com \
--cc=def@FreeBSD.org \
--cc=jrtc27@FreeBSD.org \
--cc=kevans@FreeBSD.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).