Re: [PATCH v2 15/22] hw/ipmi/isa_ipmi_bt: Disuse isa_init_irq()

[Corey Minyard <minyard@acm.org>]

On Tue, Feb 22, 2022 at 08:34:39PM +0100, Bernhard Beschow wrote:
> isa_init_irq() has become a trivial one-line wrapper for isa_get_irq().
> Use the original instead such that isa_init_irq() can be removed
> eventually.

Looking at the rest of the patch series, this looks lik a good idea.
This is obviously trivial here, but:

Acked-by: Corey Minyard <cminyard@mvista.com>

For this and the KCS patch.

-corey

> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>  hw/ipmi/isa_ipmi_bt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ipmi/isa_ipmi_bt.c b/hw/ipmi/isa_ipmi_bt.c
> index 02625eb94e..88aa734e9e 100644
> --- a/hw/ipmi/isa_ipmi_bt.c
> +++ b/hw/ipmi/isa_ipmi_bt.c
> @@ -92,7 +92,7 @@ static void isa_ipmi_bt_realize(DeviceState *dev, Error **errp)
>      }
>  
>      if (iib->isairq > 0) {
> -        isa_init_irq(isadev, &iib->irq, iib->isairq);
> +        iib->irq = isa_get_irq(isadev, iib->isairq);
>          iib->bt.use_irq = 1;
>          iib->bt.raise_irq = isa_ipmi_bt_raise_irq;
>          iib->bt.lower_irq = isa_ipmi_bt_lower_irq;
> -- 
> 2.35.1
>