qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [PULL 2/9] keyval: Fix grammar comment to cover downstream prefix
Date: Mon, 28 Feb 2022 12:26:06 +0100	[thread overview]
Message-ID: <20220228112613.520040-3-armbru@redhat.com> (raw)
In-Reply-To: <20220228112613.520040-1-armbru@redhat.com>

According to the grammar, a key __com.redhat_foo would be parsed as
two key fragments __com and redhat_foo.  It's actually parsed as a
single fragment.  Fix the grammar.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20220218145551.892787-2-armbru@redhat.com>
---
 util/keyval.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/util/keyval.c b/util/keyval.c
index 904337c8a1..0cf2e84dc8 100644
--- a/util/keyval.c
+++ b/util/keyval.c
@@ -16,7 +16,9 @@
  *   key-vals     = [ key-val { ',' key-val } [ ',' ] ]
  *   key-val      = key '=' val | help
  *   key          = key-fragment { '.' key-fragment }
- *   key-fragment = / [^=,.]+ /
+ *   key-fragment = qapi-name | index
+ *   qapi-name    = '__' / [a-z0-9.-]+ / '_' / [A-Za-z][A-Za-z0-9_-]* /
+ *   index        = / [0-9]+ /
  *   val          = { / [^,]+ / | ',,' }
  *   help         = 'help' | '?'
  *
-- 
2.35.1



  parent reply	other threads:[~2022-02-28 11:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 11:26 [PULL 0/9] QAPI patches patches for 2022-02-28 Markus Armbruster
2022-02-28 11:26 ` [PULL 1/9] scripts/qapi: minor delinting Markus Armbruster
2022-02-28 11:26 ` Markus Armbruster [this message]
2022-02-28 11:26 ` [PULL 3/9] qapi: Fix stale reference to scripts/qapi.py in a comment Markus Armbruster
2022-02-28 11:26 ` [PULL 4/9] qapi/migration: Fix examples document wrong field name for arguments Markus Armbruster
2022-02-28 11:26 ` [PULL 5/9] qapi: Move RTC_CHANGE back out of target schema Markus Armbruster
2022-02-28 11:26 ` [PULL 6/9] qapi: Document some missing details of RTC_CHANGE event Markus Armbruster
2022-02-28 11:26 ` [PULL 7/9] hw/rtc: Compile pl031 once-only Markus Armbruster
2022-02-28 11:26 ` [PULL 8/9] rtc: Have event RTC_CHANGE identify the RTC by QOM path Markus Armbruster
2022-02-28 11:26 ` [PULL 9/9] qapi: Belatedly adjust limitations documentation Markus Armbruster
2022-03-01 13:25 ` [PULL 0/9] QAPI patches patches for 2022-02-28 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220228112613.520040-3-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).