From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ani Sinha <ani@anisinha.ca>
Cc: imammedo@redhat.com, shentey@gmail.com,
Liav Albani <liavalb@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v4 3/3] tests/acpi: i386: update FACP table differences
Date: Tue, 1 Mar 2022 06:21:34 -0500 [thread overview]
Message-ID: <20220301062008-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2203010829190.1505325@anisinha-lenovo>
On Tue, Mar 01, 2022 at 08:29:57AM +0530, Ani Sinha wrote:
>
>
> On Mon, 28 Feb 2022, Liav Albani wrote:
>
> > After changing the IAPC boot flags register to indicate support of i8042
> > in the machine chipset to help the guest OS to determine its existence
> > "faster", we need to have the updated FACP ACPI binary images in tree.
> >
> > @@ -1,32 +1,32 @@
> > /*
> > * Intel ACPI Component Architecture
> > * AML/ASL+ Disassembler version 20211217 (64-bit version)
> > * Copyright (c) 2000 - 2021 Intel Corporation
> > *
> > - * Disassembly of tests/data/acpi/q35/FACP, Wed Feb 23 22:37:39 2022
> > + * Disassembly of /tmp/aml-BBFBI1, Wed Feb 23 22:37:39 2022
cut this out pls
> > *
> > * ACPI Data Table [FACP]
> > *
> > * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue (in hex)
> > */
> >
> > [000h 0000 4] Signature : "FACP" [Fixed ACPI Description Table (FADT)]
> > [004h 0004 4] Table Length : 000000F4
> > [008h 0008 1] Revision : 03
> > -[009h 0009 1] Checksum : B9
> > +[009h 0009 1] Checksum : B7
and this
> > [00Ah 0010 6] Oem ID : "BOCHS "
> > [010h 0016 8] Oem Table ID : "BXPC "
> > [018h 0024 4] Oem Revision : 00000001
> > [01Ch 0028 4] Asl Compiler ID : "BXPC"
> > [020h 0032 4] Asl Compiler Revision : 00000001
> >
> > [024h 0036 4] FACS Address : 00000000
> > [028h 0040 4] DSDT Address : 00000000
> > [02Ch 0044 1] Model : 01
> > [02Dh 0045 1] PM Profile : 00 [Unspecified]
> > [02Eh 0046 2] SCI Interrupt : 0009
> > [030h 0048 4] SMI Command Port : 000000B2
> > [034h 0052 1] ACPI Enable Value : 02
> > [035h 0053 1] ACPI Disable Value : 03
> > [036h 0054 1] S4BIOS Command : 00
> > [037h 0055 1] P-State Control : 00
> > @@ -42,35 +42,35 @@
> > [059h 0089 1] PM1 Control Block Length : 02
> > [05Ah 0090 1] PM2 Control Block Length : 00
> > [05Bh 0091 1] PM Timer Block Length : 04
> > [05Ch 0092 1] GPE0 Block Length : 10
> > [05Dh 0093 1] GPE1 Block Length : 00
> > [05Eh 0094 1] GPE1 Base Offset : 00
> > [05Fh 0095 1] _CST Support : 00
> > [060h 0096 2] C2 Latency : 0FFF
> > [062h 0098 2] C3 Latency : 0FFF
> > [064h 0100 2] CPU Cache Size : 0000
> > [066h 0102 2] Cache Flush Stride : 0000
> > [068h 0104 1] Duty Cycle Offset : 00
> > [069h 0105 1] Duty Cycle Width : 00
> > [06Ah 0106 1] RTC Day Alarm Index : 00
> > [06Bh 0107 1] RTC Month Alarm Index : 00
> > [06Ch 0108 1] RTC Century Index : 32
> > -[06Dh 0109 2] Boot Flags (decoded below) : 0000
> > +[06Dh 0109 2] Boot Flags (decoded below) : 0002
> > Legacy Devices Supported (V2) : 0
> > - 8042 Present on ports 60/64 (V2) : 0
> > + 8042 Present on ports 60/64 (V2) : 1
> > VGA Not Present (V4) : 0
> > MSI Not Supported (V4) : 0
> > PCIe ASPM Not Supported (V4) : 0
> > CMOS RTC Not Present (V5) : 0
leaving just this
> > [06Fh 0111 1] Reserved : 00
> > [070h 0112 4] Flags (decoded below) : 000084A5
> > WBINVD instruction is operational (V1) : 1
> > WBINVD flushes all caches (V1) : 0
> > All CPUs support C1 (V1) : 1
> > C2 works on MP system (V1) : 0
> > Control Method Power Button (V1) : 0
> > Control Method Sleep Button (V1) : 1
> > RTC wake not in fixed reg space (V1) : 0
> > RTC can wake system from S4 (V1) : 1
> > 32-bit PM Timer (V1) : 0
> > Docking Supported (V1) : 0
> > @@ -148,32 +148,32 @@
> > [0DCh 0220 1] Space ID : 01 [SystemIO]
> > [0DDh 0221 1] Bit Width : 80
> > [0DEh 0222 1] Bit Offset : 00
> > [0DFh 0223 1] Encoded Access Width : 00 [Undefined/Legacy]
> > [0E0h 0224 8] Address : 0000000000000620
> >
> > [0E8h 0232 12] GPE1 Block : [Generic Address Structure]
> > [0E8h 0232 1] Space ID : 00 [SystemMemory]
> > [0E9h 0233 1] Bit Width : 00
> > [0EAh 0234 1] Bit Offset : 00
> > [0EBh 0235 1] Encoded Access Width : 00 [Undefined/Legacy]
> > [0ECh 0236 8] Address : 0000000000000000
> >
> > Raw Table Data: Length 244 (0xF4)
> >
> > - 0000: 46 41 43 50 F4 00 00 00 03 B9 42 4F 43 48 53 20 // FACP......BOCHS
> > + 0000: 46 41 43 50 F4 00 00 00 03 B7 42 4F 43 48 53 20 // FACP......BOCHS
> > 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ....BXPC
> > 0020: 01 00 00 00 00 00 00 00 00 00 00 00 01 00 09 00 // ................
> > 0030: B2 00 00 00 02 03 00 00 00 06 00 00 00 00 00 00 // ................
> > 0040: 04 06 00 00 00 00 00 00 00 00 00 00 08 06 00 00 // ................
> > 0050: 20 06 00 00 00 00 00 00 04 02 00 04 10 00 00 00 // ...............
> > - 0060: FF 0F FF 0F 00 00 00 00 00 00 00 00 32 00 00 00 // ............2...
> > + 0060: FF 0F FF 0F 00 00 00 00 00 00 00 00 32 02 00 00 // ............2...
> > 0070: A5 84 00 00 01 08 00 00 F9 0C 00 00 00 00 00 00 // ................
> > 0080: 0F 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ................
> > 0090: 00 00 00 00 01 20 00 00 00 06 00 00 00 00 00 00 // ..... ..........
> > 00A0: 00 00 00 00 00 00 00 00 00 00 00 00 01 10 00 00 // ................
> > 00B0: 04 06 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ................
> > 00C0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ................
> > 00D0: 01 20 00 00 08 06 00 00 00 00 00 00 01 80 00 00 // . ..............
> > 00E0: 20 06 00 00 00 00 00 00 00 00 00 00 00 00 00 00 // ...............
> > 00F0: 00 00 00 00 // ....
this isn't helpful either and will be wrong if cherry picked.
> > **
>
> Please retain tags from earlier revisions of the patch.
>
> >
> > Signed-off-by: Liav Albani <liavalb@gmail.com>
>
> Acked-by: Ani Sinha <ani@anisinha.ca>
>
> > ---
> > tests/data/acpi/q35/FACP | Bin 244 -> 244 bytes
> > tests/data/acpi/q35/FACP.nosmm | Bin 244 -> 244 bytes
> > tests/data/acpi/q35/FACP.slic | Bin 244 -> 244 bytes
> > tests/data/acpi/q35/FACP.xapic | Bin 244 -> 244 bytes
> > tests/qtest/bios-tables-test-allowed-diff.h | 4 ----
> > 5 files changed, 4 deletions(-)
> >
> > diff --git a/tests/data/acpi/q35/FACP b/tests/data/acpi/q35/FACP
> > index f6a864cc863c7763f6c09d3814ad184a658fa0a0..a8f6a8961109d01059aceef9f1869cde09a2f10c 100644
> > GIT binary patch
> > delta 23
> > ecmeyu_=S<n&CxmF3j+fK^Y)2c$&5@B^V$GgGY3Ne
> >
> > delta 23
> > ecmeyu_=S<n&CxmF3j+fK^UjG}$&3sW^V$GgJqJSo
> >
> > diff --git a/tests/data/acpi/q35/FACP.nosmm b/tests/data/acpi/q35/FACP.nosmm
> > index 6a9aa5f370eb9af6a03dc739d8a159be58fdee01..c4e6d18ee5fc64159160d4589aa96b4d648c913a 100644
> > GIT binary patch
> > delta 23
> > ecmeyu_=S<n&CxmF3j+fKbKXR*WJacmd2Ik#q6Yc^
> >
> > delta 23
> > ecmeyu_=S<n&CxmF3j+fKbHPNeWJZRGd2Ik#tOoi3
> >
> > diff --git a/tests/data/acpi/q35/FACP.slic b/tests/data/acpi/q35/FACP.slic
> > index 15986e095cf2db7ee92f7ce113c1d46d54018c62..48bbb1cf5ad0ceda1d2f6d56edf5c1e207bd1a04 100644
> > GIT binary patch
> > delta 23
> > ecmeyu_=S<n&CxmF3j+fK^M#3A$&5@B^V$Gh6bD=Y
> >
> > delta 23
> > ecmeyu_=S<n&CxmF3j+fK^QDPg$&3sW^V$Gh9tT_i
> >
> > diff --git a/tests/data/acpi/q35/FACP.xapic b/tests/data/acpi/q35/FACP.xapic
> > index 2d3659c9c6753d07c3d48742343cb8e8cc034de7..31fa5dd19c213034eef4eeefa6a04e61dadd8a2a 100644
> > GIT binary patch
> > delta 23
> > ecmeyu_=S<n&CxmF3j+fK^X7?M$&5@B^V$Gg4+lR0
> >
> > delta 23
> > ecmeyu_=S<n&CxmF3j+fK^VW%6$&3sW^V$Gg83#WA
> >
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > index 7570e39369..dfb8523c8b 100644
> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > @@ -1,5 +1 @@
> > /* List of comma-separated changed AML files to ignore */
> > -"tests/data/acpi/q35/FACP",
> > -"tests/data/acpi/q35/FACP.nosmm",
> > -"tests/data/acpi/q35/FACP.slic",
> > -"tests/data/acpi/q35/FACP.xapic",
> > --
> > 2.35.1
> >
> >
next prev parent reply other threads:[~2022-03-01 11:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 20:17 [PATCH v4 0/3] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table Liav Albani
2022-02-28 20:17 ` [PATCH v4 1/3] tests/acpi: i386: allow FACP acpi table changes Liav Albani
2022-03-01 2:55 ` Ani Sinha
2022-02-28 20:17 ` [PATCH v4 2/3] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table Liav Albani
2022-03-01 2:59 ` Ani Sinha
2022-03-01 8:48 ` Igor Mammedov
2022-03-01 8:43 ` Igor Mammedov
2022-03-01 9:52 ` Ani Sinha
2022-03-01 11:51 ` Igor Mammedov
2022-03-01 19:20 ` Liav Albani
2022-03-02 5:14 ` Ani Sinha
2022-03-02 12:42 ` Michael S. Tsirkin
2022-03-02 15:43 ` Liav Albani
2022-03-02 15:51 ` Ani Sinha
2022-03-02 15:58 ` Ani Sinha
2022-03-01 11:19 ` Michael S. Tsirkin
2022-03-01 11:47 ` Igor Mammedov
2022-03-01 12:18 ` Michael S. Tsirkin
2022-03-02 15:45 ` Liav Albani
2022-03-04 10:58 ` Igor Mammedov
2022-03-01 19:11 ` Liav Albani
2022-03-02 5:12 ` Ani Sinha
2022-03-02 8:47 ` Michael S. Tsirkin
2022-02-28 20:17 ` [PATCH v4 3/3] tests/acpi: i386: update FACP table differences Liav Albani
2022-03-01 2:59 ` Ani Sinha
2022-03-01 11:21 ` Michael S. Tsirkin [this message]
2022-03-01 19:13 ` Liav Albani
2022-03-02 5:05 ` Ani Sinha
2022-03-02 8:48 ` Michael S. Tsirkin
2022-03-04 10:26 ` [PATCH v4 0/3] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table Michael S. Tsirkin
2022-03-04 10:34 ` Ani Sinha
2022-03-04 10:39 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301062008-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ani@anisinha.ca \
--cc=imammedo@redhat.com \
--cc=liavalb@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).