qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Volker Rümelin" <vr_qemu@t-online.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>, qemu-devel@nongnu.org
Subject: [PATCH v3 07/15] audio: copy playback stream in sequential order
Date: Tue,  1 Mar 2022 20:13:03 +0100	[thread overview]
Message-ID: <20220301191311.26695-7-vr_qemu@t-online.de> (raw)
In-Reply-To: <3d0bd2ac-e5b9-9cf6-c98f-c047390a3ec5@t-online.de>

Change the code to copy the playback stream in sequential order.
The advantage can be seen in the next patches where the stream
copy operation effectively becomes a write through operation.

The following diagram shows the average buffer fill level and
the stream copy sequence. ### represents a timer_period sized
chunk. The rest of the buffer sizes are not to scale.

With current code:
         |--------| |#####111| |---#####|
          sw->buf    mix_buf    backend buffer
  1. clip
         |--------| |---#####| |111##222|
          sw->buf    mix_buf    backend buffer
  2. write to audio device
  333 -> |--------| |---#####| |---111##| -> 222
          sw->buf    mix_buf    backend buffer
  3a. sw device write
         |-----333| |---#####| |---111##|
          sw->buf    mix_buf    backend buffer
  3b. resample and mix
         |--------| |333#####| |---111##|
          sw->buf    mix_buf    backend buffer

With this patch:
  111 -> |--------| |---#####| |---#####|
          sw->buf    mix_buf    backend buffer
  1a: sw device write
         |-----111| |---#####| |---#####|
          sw->buf    mix_buf    backend buffer
  1b. resample and mix
         |--------| |111##222| |---#####|
          sw->buf    mix_buf    backend buffer
  2. clip
         |--------| |---111##| |222##333|
          sw->buf    mix_buf    backend buffer
  3. write to audio device
         |--------| |---111##| |---222##| -> 333
          sw->buf    mix_buf    backend buffer

The effective total playback buffer size is reduced by
timer_period.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
 audio/audio.c | 24 +++++++++---------------
 1 file changed, 9 insertions(+), 15 deletions(-)

diff --git a/audio/audio.c b/audio/audio.c
index 35437986d9..9e2d7fb209 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1134,6 +1134,15 @@ static void audio_run_out (AudioState *s)
         size_t played, live, prev_rpos, free;
         int nb_live;
 
+        for (sw = hw->sw_head.lh_first; sw; sw = sw->entries.le_next) {
+            if (sw->active) {
+                free = audio_get_free(sw);
+                if (free > 0) {
+                    sw->callback.fn(sw->callback.opaque, free);
+                }
+            }
+        }
+
         live = audio_pcm_hw_get_live_out (hw, &nb_live);
         if (!nb_live) {
             live = 0;
@@ -1162,14 +1171,6 @@ static void audio_run_out (AudioState *s)
         }
 
         if (!live) {
-            for (sw = hw->sw_head.lh_first; sw; sw = sw->entries.le_next) {
-                if (sw->active) {
-                    free = audio_get_free (sw);
-                    if (free > 0) {
-                        sw->callback.fn (sw->callback.opaque, free);
-                    }
-                }
-            }
             if (hw->pcm_ops->run_buffer_out) {
                 hw->pcm_ops->run_buffer_out(hw);
             }
@@ -1210,13 +1211,6 @@ static void audio_run_out (AudioState *s)
             if (!sw->total_hw_samples_mixed) {
                 sw->empty = 1;
             }
-
-            if (sw->active) {
-                free = audio_get_free (sw);
-                if (free > 0) {
-                    sw->callback.fn (sw->callback.opaque, free);
-                }
-            }
         }
     }
 }
-- 
2.34.1



  parent reply	other threads:[~2022-03-01 19:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 19:11 [PATCH v3 00/15] reduce audio playback latency Volker Rümelin
2022-03-01 19:12 ` [PATCH v3 01/15] audio: replace open-coded buffer arithmetic Volker Rümelin
2022-03-02  0:12   ` Akihiko Odaki
2022-03-01 19:12 ` [PATCH v3 02/15] audio: move function audio_pcm_hw_clip_out() Volker Rümelin
2022-03-01 19:12 ` [PATCH v3 03/15] audio: add function audio_pcm_hw_conv_in() Volker Rümelin
2022-03-01 19:13 ` [PATCH v3 04/15] audio: inline function audio_pcm_sw_get_rpos_in() Volker Rümelin
2022-03-01 19:13 ` [PATCH v3 05/15] paaudio: increase default latency to 46ms Volker Rümelin
2022-03-01 19:13 ` [PATCH v3 06/15] jackaudio: use more jack audio buffers Volker Rümelin
2022-03-02 18:11   ` Christian Schoenebeck
2022-03-02 20:51     ` Volker Rümelin
2022-03-01 19:13 ` Volker Rümelin [this message]
2022-03-01 19:13 ` [PATCH v3 08/15] audio: add pcm_ops function table for capture backend Volker Rümelin
2022-03-01 19:13 ` [PATCH v3 09/15] Revert "audio: fix wavcapture segfault" Volker Rümelin
2022-03-01 19:13 ` [PATCH v3 10/15] audio: restore mixing-engine playback buffer size Volker Rümelin
2022-03-02  0:13   ` Akihiko Odaki
2022-03-01 19:13 ` [PATCH v3 11/15] paaudio: reduce effective " Volker Rümelin
2022-03-01 19:13 ` [PATCH v3 12/15] dsoundaudio: " Volker Rümelin
2022-03-01 19:13 ` [PATCH v3 13/15] ossaudio: " Volker Rümelin
2022-03-01 19:13 ` [PATCH v3 14/15] paaudio: fix samples vs. frames mix-up Volker Rümelin
2022-03-01 19:13 ` [PATCH v3 15/15] sdlaudio: " Volker Rümelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220301191311.26695-7-vr_qemu@t-online.de \
    --to=vr_qemu@t-online.de \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).