From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "open list:PReP" <qemu-ppc@nongnu.org>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Bernhard Beschow" <shentey@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH v3 2/7] hw/rtc/m48t59-isa: QOM'ify IRQ number
Date: Tue, 1 Mar 2022 23:00:32 +0100 [thread overview]
Message-ID: <20220301220037.76555-3-shentey@gmail.com> (raw)
In-Reply-To: <20220301220037.76555-1-shentey@gmail.com>
Exposing the IRQ number as a QOM property not only allows it to be
configurable but also to be printed by standard QOM mechanisms. This allows
isabus_dev_print() to be retired eventually.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/rtc/m48t59-isa.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/rtc/m48t59-isa.c b/hw/rtc/m48t59-isa.c
index dc21fb10a5..e9086eada4 100644
--- a/hw/rtc/m48t59-isa.c
+++ b/hw/rtc/m48t59-isa.c
@@ -42,6 +42,7 @@ struct M48txxISAState {
ISADevice parent_obj;
M48t59State state;
uint32_t io_base;
+ uint8_t isairq;
MemoryRegion io;
};
@@ -79,6 +80,7 @@ static void m48txx_isa_toggle_lock(Nvram *obj, int lock)
static Property m48t59_isa_properties[] = {
DEFINE_PROP_INT32("base-year", M48txxISAState, state.base_year, 0),
DEFINE_PROP_UINT32("iobase", M48txxISAState, io_base, 0x74),
+ DEFINE_PROP_UINT8("irq", M48txxISAState, isairq, 8),
DEFINE_PROP_END_OF_LIST(),
};
@@ -97,9 +99,14 @@ static void m48t59_isa_realize(DeviceState *dev, Error **errp)
M48txxISAState *d = M48TXX_ISA(dev);
M48t59State *s = &d->state;
+ if (d->isairq >= ISA_NUM_IRQS) {
+ error_setg(errp, "Maximum value for \"irq\" is: %u", ISA_NUM_IRQS - 1);
+ return;
+ }
+
s->model = u->info.model;
s->size = u->info.size;
- isa_init_irq(isadev, &s->IRQ, 8);
+ isa_init_irq(isadev, &s->IRQ, d->isairq);
m48t59_realize_common(s, errp);
memory_region_init_io(&d->io, OBJECT(dev), &m48t59_io_ops, s, "m48t59", 4);
if (d->io_base != 0) {
--
2.35.1
next prev parent reply other threads:[~2022-03-01 22:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 22:00 [PATCH v3 0/7] isa: Resolve unneeded IRQ attributes from ISADevice Bernhard Beschow
2022-03-01 22:00 ` [PATCH v3 1/7] hw/rtc/mc146818rtc: QOM'ify IRQ number Bernhard Beschow
2022-03-01 22:00 ` Bernhard Beschow [this message]
2022-03-01 22:00 ` [PATCH v3 3/7] hw/input/pckbd: QOM'ify IRQ numbers Bernhard Beschow
2022-03-01 22:00 ` [PATCH v3 4/7] hw/isa/isa-bus: Remove isabus_dev_print() Bernhard Beschow
2022-03-01 22:00 ` [PATCH v3 5/7] hw/ppc/pnv: Determine ns16550's IRQ number from QOM property Bernhard Beschow
2022-03-01 22:00 ` [PATCH v3 6/7] isa: Drop unused attributes from ISADevice Bernhard Beschow
2022-03-01 22:00 ` [PATCH v3 7/7] isa: Inline and remove one-line isa_init_irq() Bernhard Beschow
2022-03-02 8:05 ` Gerd Hoffmann
2022-03-07 0:34 ` [PATCH v3 0/7] isa: Resolve unneeded IRQ attributes from ISADevice Philippe Mathieu-Daudé
2022-03-12 21:54 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301220037.76555-3-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).