qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yan-Jie Wang <ubzeme@gmail.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Roman Bolshakov <r.bolshakov@yadro.com>,
	Alexander Graf <agraf@csgraf.de>,
	Cameron Esfahani <dirty@apple.com>,
	Yan-Jie Wang <ubzeme@gmail.com>
Subject: [PATCH v2 8/9] hvf: only consider directly writeable memory regions for dirty-tracking
Date: Wed,  2 Mar 2022 20:26:10 +0800	[thread overview]
Message-ID: <20220302122611.15237-9-ubzeme@gmail.com> (raw)
In-Reply-To: <20220302122611.15237-1-ubzeme@gmail.com>

It is no need to dirty-track MMIO regions or other readonly regions.

Before we start or stop to dirty-track a memory region, check the type of
the memory region. The region must be a writeable ram to be dirty-tracked.

Signed-off-by: Yan-Jie Wang <ubzeme@gmail.com>
---
 accel/hvf/hvf-mem.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/accel/hvf/hvf-mem.c b/accel/hvf/hvf-mem.c
index 2f70ceb307..b215386bc8 100644
--- a/accel/hvf/hvf-mem.c
+++ b/accel/hvf/hvf-mem.c
@@ -180,6 +180,11 @@ static void hvf_set_dirty_tracking(MemoryRegionSection *section, bool on)
 {
     HVFSlot *slot;
 
+    if (!memory_region_is_ram(section->mr) || memory_region_is_rom(section)) {
+        /* do not consider memory regions which are not directly writeable */
+        return;
+    }
+
     qemu_mutex_lock(&memlock);
 
     slot = hvf_find_overlap_slot(
-- 
2.32.0 (Apple Git-132)



  parent reply	other threads:[~2022-03-02 12:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02 12:26 [PATCH v2 0/9] Many improvements to HVF memory-related codes Yan-Jie Wang
2022-03-02 12:26 ` [PATCH v2 1/9] hvf: move memory related functions from hvf-accel-ops.c to hvf-mem.c Yan-Jie Wang
2022-03-02 12:26 ` [PATCH v2 2/9] hvf: simplify data structures and codes of memory related functions Yan-Jie Wang
2022-03-02 12:26 ` [PATCH v2 3/9] hvf: use correct data types for addresses in " Yan-Jie Wang
2022-03-02 12:26 ` [PATCH v2 4/9] hvf: rename struct hvf_slot to HVFSlot Yan-Jie Wang
2022-03-02 12:26 ` [PATCH v2 5/9] hvf: fix memory dirty-tracking Yan-Jie Wang
2022-03-02 12:26 ` [PATCH v2 6/9] hvf: add a lock for memory related functions Yan-Jie Wang
2022-03-02 12:26 ` [PATCH v2 7/9] hvf: use GTree to store memory slots instead of fixed-size array Yan-Jie Wang
2022-03-02 12:26 ` Yan-Jie Wang [this message]
2022-03-02 12:26 ` [PATCH v2 9/9] hvf: remove the need to lookup memory slots when clearing dirty-bits Yan-Jie Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220302122611.15237-9-ubzeme@gmail.com \
    --to=ubzeme@gmail.com \
    --cc=agraf@csgraf.de \
    --cc=dirty@apple.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=r.bolshakov@yadro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).