From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AE4FC433F5 for ; Wed, 2 Mar 2022 17:51:01 +0000 (UTC) Received: from localhost ([::1]:37026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPT7r-0006Ft-RG for qemu-devel@archiver.kernel.org; Wed, 02 Mar 2022 12:50:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPT6G-0004nN-SQ for qemu-devel@nongnu.org; Wed, 02 Mar 2022 12:49:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:45019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPT6F-0007tx-D7 for qemu-devel@nongnu.org; Wed, 02 Mar 2022 12:49:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646243358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KHov4rSdmNSpCoaSX9M+1g7hJvbhTgSvzT20Bw+TISY=; b=DmZLPnB/drdNyWIq8WIEoKRcJ2GLHJsKdM5J3Gpaz44lg/j5KA6b+WREYdBP0mP9lH8qC8 4c3aXkRnnDLOubOCgY+VeskaA9NWh8Xg+iWxuZfHXEfxHanvLwWtLHAC22f71kx/FJJgpP pEzbNblEwm8gyLotsa7ztE5IkHIfeZw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-403-tAcapSSUMKiCycft13Cvow-1; Wed, 02 Mar 2022 12:49:15 -0500 X-MC-Unique: tAcapSSUMKiCycft13Cvow-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 96EB751FC; Wed, 2 Mar 2022 17:49:13 +0000 (UTC) Received: from localhost (unknown [10.33.36.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id DDD25865A4; Wed, 2 Mar 2022 17:48:53 +0000 (UTC) Date: Wed, 2 Mar 2022 18:49:13 +0100 From: Sergio Lopez To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 2/2] Allow building vhost-user in BSD Message-ID: <20220302174913.bcrnlhgkpvjayyrw@mhamilton> References: <20220302113644.43717-1-slp@redhat.com> <20220302113644.43717-3-slp@redhat.com> <66b68bcc-8d7e-a5f7-5e6c-b2d20c26ab01@redhat.com> <8dfc9854-4d59-0759-88d0-d502ae7c552f@gmail.com> <20220302173009.26auqvy4t4rx74td@mhamilton> <85ed0856-308a-7774-a751-b20588f3d9cd@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tpkexuwipkv6mgvo" Content-Disposition: inline In-Reply-To: <85ed0856-308a-7774-a751-b20588f3d9cd@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Received-SPF: pass client-ip=170.10.129.124; envelope-from=slp@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Elena Ufimtseva , kvm@vger.kernel.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Jagannathan Raman , Matthew Rosato , qemu-block@nongnu.org, David Hildenbrand , Halil Pasic , Thomas Huth , Christian Borntraeger , vgoyal@redhat.com, Eric Farman , Richard Henderson , qemu-s390x@nongnu.org, Stefan Hajnoczi , Kevin Wolf , John G Johnson , Cornelia Huck , Alex Williamson , Hanna Reitz , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --tpkexuwipkv6mgvo Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 02, 2022 at 06:38:07PM +0100, Philippe Mathieu-Daud=E9 wrote: > On 2/3/22 18:31, Sergio Lopez wrote: > > On Wed, Mar 02, 2022 at 06:18:59PM +0100, Philippe Mathieu-Daud=E9 wrot= e: > > > On 2/3/22 18:10, Paolo Bonzini wrote: > > > > On 3/2/22 12:36, Sergio Lopez wrote: > > > > > With the possibility of using pipefd as a replacement on operating > > > > > systems that doesn't support eventfd, vhost-user can also work on= BSD > > > > > systems. > > > > >=20 > > > > > This change allows enabling vhost-user on BSD platforms too and > > > > > makes libvhost_user (which still depends on eventfd) a linux-only > > > > > feature. > > > > >=20 > > > > > Signed-off-by: Sergio Lopez > > > >=20 > > > > I would just check for !windows. > > >=20 > > > What about Darwin / Haiku / Illumnos? > >=20 > > It should work on every system providing pipe() or pipe2(), so I guess > > Paolo's right, every platform except Windows. FWIW, I already tested > > it with Darwin. >=20 > Wow, nice. >=20 > So maybe simply check for pipe/pipe2 rather than !windows? >=20 Is it worth it? In "configure", CONFIG_POSIX is set to "y" if the target isn't "mingw32", and CONFIG_POSIX brings "util/oslib-posix.c" into the build, which expects to have either pipe or pipe2. Thanks, Sergio. --tpkexuwipkv6mgvo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEvtX891EthoCRQuii9GknjS8MAjUFAmIfrhgACgkQ9GknjS8M AjVzrRAAsTcf522XpDZJHdkqrJ4iY87nqERGww2Xz99TuNvzoxVAuvfbGTa4O6ZQ Vf8GUpbfJcvvwaQu/Cb0KbZCYY/7o/KKAWSYeLYO4SvA0aoSqExJoeLVYf9nhgaq RGpuZLgMWC1LGNeXf3QeQHcSZaQ6XqZn8aAAO+oeX+tK6kql05l2ZxE/p+Hs+RnP 3Wr+yxUZnr0ljHOUWZ7luQ0+C9bKso9WQhKXiS59cPRg3tK3bx0OP1gyyxwD1+gB 268XBEDOgcH9jBXZpQx//iyPQJJQNWnXHdDhW0w/WmkAdt/DaHkEYmfKWV/oAzoq TdCx6Eh5OKzBoOYBd/CXpLbdxoWPHtvzZ+UUbxBdco+jNuhUmn8hquC32GtmTR05 o+H5WCcQvVmAvk75sOUlEgkRHaZcmnply1bIBf5pea40pFzbTimjEnnqwxGfNBrD eplli9xkBixcArtWDafK21YJsva/8TxkzgysGUb5JlHLRx78PkJ0C7sNFympBpBN oTQYx5T5PLhfYQEacbaGWcWS2T15mw3oCXAltJopULif5nijp83xY+tlKJVRiFgM RNB1M/aB2/cpcEOI75xx2glEt9GeJUMgqAcco4VCkifFb3n8tIFh/01vEfABvNMc i6crm15PxBagb9QUpk9+HxEAduKR6BAaCRtWlySn++KtKNgXkWk= =+Zlf -----END PGP SIGNATURE----- --tpkexuwipkv6mgvo--