From: Alex Williamson <alex.williamson@redhat.com>
To: Steve Sistare <steven.sistare@oracle.com>
Cc: "Jason Zeng" <jason.zeng@linux.intel.com>,
"Juan Quintela" <quintela@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Zheng Chuan" <zhengchuan@huawei.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH V7 18/29] vfio-pci: refactor for cpr
Date: Thu, 3 Mar 2022 16:21:03 -0700 [thread overview]
Message-ID: <20220303162103.0dbe93a1.alex.williamson@redhat.com> (raw)
In-Reply-To: <1640199934-455149-19-git-send-email-steven.sistare@oracle.com>
On Wed, 22 Dec 2021 11:05:23 -0800
Steve Sistare <steven.sistare@oracle.com> wrote:
> + if (vfio_notifier_init(vdev, &vdev->intx.unmask, "intx-unmask", 0)) {
...
> + vfio_notifier_cleanup(vdev, &vdev->intx.unmask, "intx-unmask", 0);
...
> + vfio_notifier_cleanup(vdev, &vdev->intx.unmask, "intx-unmask", 0);
...
> + ret = vfio_notifier_init(vdev, &vdev->intx.interrupt, "intx-interrupt", 0);
...
> + vfio_notifier_cleanup(vdev, &vdev->intx.interrupt, "intx-interrupt", 0);
...
> + vfio_notifier_cleanup(vdev, &vdev->intx.interrupt, "intx-interrupt", 0);
...
> + const char *name = "kvm_interrupt";
...
> + if (vfio_notifier_init(vdev, &vector->kvm_interrupt, name, nr)) {
...
> + vfio_notifier_cleanup(vdev, &vector->kvm_interrupt, name, nr);
...
> + vfio_notifier_cleanup(vdev, &vector->kvm_interrupt, name, nr);
...
> + vfio_notifier_cleanup(vdev, &vector->kvm_interrupt, "kvm_interrupt", nr);
...
> + if (vfio_notifier_init(vdev, &vector->interrupt, "interrupt", nr)) {
...
> + if (vfio_notifier_init(vdev, &vector->interrupt, "interrupt", i)) {
...
> + vfio_notifier_cleanup(vdev, &vector->interrupt, "interrupt", i);
...
> + vfio_notifier_cleanup(vdev, &vector->interrupt, "interrupt", i);
...
> + if (vfio_notifier_init(vdev, &vdev->err_notifier, "err", 0)) {
...
> + vfio_notifier_cleanup(vdev, &vdev->err_notifier, "err_notifier", 0);
...
> + vfio_notifier_cleanup(vdev, &vdev->err_notifier, "err_notifier", 0);
...
> + if (vfio_notifier_init(vdev, &vdev->req_notifier, "req", 0)) {
...
> + vfio_notifier_cleanup(vdev, &vdev->req_notifier, "req_notifier", 0);
...
> + vfio_notifier_cleanup(vdev, &vdev->req_notifier, "req_notifier", 0);
Something seems to have gone astray with "err" and "req" vs
"err_notifier" and "req_notifier". The pattern is broken. Thanks,
Alex
next prev parent reply other threads:[~2022-03-03 23:21 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 19:05 [PATCH V7 00/29] Live Update Steve Sistare
2021-12-22 19:05 ` [PATCH V7 01/29] memory: qemu_check_ram_volatile Steve Sistare
2022-02-24 18:28 ` Dr. David Alan Gilbert
2022-03-03 15:55 ` Steven Sistare
2022-03-04 12:47 ` Philippe Mathieu-Daudé
2021-12-22 19:05 ` [PATCH V7 02/29] migration: fix populate_vfio_info Steve Sistare
2022-02-24 18:42 ` Peter Maydell
2022-03-03 15:55 ` Steven Sistare
2022-03-03 16:21 ` Peter Maydell
2022-03-03 16:38 ` Steven Sistare
2021-12-22 19:05 ` [PATCH V7 03/29] migration: qemu file wrappers Steve Sistare
2022-02-24 18:21 ` Dr. David Alan Gilbert
2022-03-03 15:55 ` Steven Sistare
2021-12-22 19:05 ` [PATCH V7 04/29] migration: simplify savevm Steve Sistare
2022-02-24 18:25 ` Dr. David Alan Gilbert
2022-03-03 15:55 ` Steven Sistare
2021-12-22 19:05 ` [PATCH V7 05/29] vl: start on wakeup request Steve Sistare
2022-02-24 18:51 ` Dr. David Alan Gilbert
2022-03-03 15:56 ` Steven Sistare
2021-12-22 19:05 ` [PATCH V7 06/29] cpr: reboot mode Steve Sistare
2021-12-22 19:05 ` [PATCH V7 07/29] cpr: reboot HMP interfaces Steve Sistare
2021-12-22 19:05 ` [PATCH V7 08/29] memory: flat section iterator Steve Sistare
2022-03-04 12:48 ` Philippe Mathieu-Daudé
2022-03-07 14:42 ` Steven Sistare
2022-03-09 14:18 ` Marc-André Lureau
2021-12-22 19:05 ` [PATCH V7 09/29] oslib: qemu_clear_cloexec Steve Sistare
2021-12-22 19:05 ` [PATCH V7 10/29] machine: memfd-alloc option Steve Sistare
2022-02-18 8:05 ` Guoyi Tu
2022-03-03 15:55 ` Steven Sistare
2022-02-24 17:56 ` Dr. David Alan Gilbert
2022-03-03 15:56 ` Steven Sistare
2022-03-03 17:21 ` Michael S. Tsirkin
2022-03-04 10:41 ` Igor Mammedov
2022-03-07 14:41 ` Steven Sistare
2022-03-08 6:50 ` Michael S. Tsirkin
2022-03-08 7:20 ` Igor Mammedov
2022-03-10 15:36 ` Steven Sistare
2022-03-10 16:00 ` Igor Mammedov
2022-03-10 17:28 ` Steven Sistare
2022-03-10 18:18 ` Steven Sistare
2022-03-11 9:42 ` Igor Mammedov
2022-03-29 17:43 ` Steven Sistare
2022-03-11 10:08 ` Daniel P. Berrangé
2022-03-11 10:25 ` David Hildenbrand
2022-03-11 9:54 ` David Hildenbrand
2021-12-22 19:05 ` [PATCH V7 11/29] qapi: list utility functions Steve Sistare
2022-03-09 14:11 ` Marc-André Lureau
2022-03-11 16:45 ` Steven Sistare
2022-03-11 21:59 ` Marc-André Lureau
2021-12-22 19:05 ` [PATCH V7 12/29] vl: helper to request re-exec Steve Sistare
2022-03-09 14:16 ` Marc-André Lureau
2022-03-11 16:45 ` Steven Sistare
2021-12-22 19:05 ` [PATCH V7 13/29] cpr: preserve extra state Steve Sistare
2021-12-22 19:05 ` [PATCH V7 14/29] cpr: restart mode Steve Sistare
2021-12-22 19:05 ` [PATCH V7 15/29] cpr: restart HMP interfaces Steve Sistare
2021-12-22 19:05 ` [PATCH V7 16/29] hostmem-memfd: cpr for memory-backend-memfd Steve Sistare
2021-12-22 19:05 ` [PATCH V7 17/29] pci: export functions for cpr Steve Sistare
2021-12-22 23:07 ` Michael S. Tsirkin
2022-01-05 17:22 ` Steven Sistare
2022-01-05 20:16 ` Michael S. Tsirkin
2022-01-06 22:48 ` Steven Sistare
2022-01-07 10:03 ` Michael S. Tsirkin
2021-12-22 19:05 ` [PATCH V7 18/29] vfio-pci: refactor " Steve Sistare
2022-03-03 23:21 ` Alex Williamson [this message]
2022-03-07 14:42 ` Steven Sistare
2021-12-22 19:05 ` [PATCH V7 19/29] vfio-pci: cpr part 1 (fd and dma) Steve Sistare
2021-12-22 23:15 ` Michael S. Tsirkin
2022-01-05 17:24 ` Steven Sistare
2022-01-05 21:14 ` Michael S. Tsirkin
2022-01-05 21:40 ` Steven Sistare
2022-01-05 23:09 ` Michael S. Tsirkin
2022-01-05 23:24 ` Steven Sistare
2022-01-06 9:12 ` Michael S. Tsirkin
2022-01-06 19:13 ` Steven Sistare
2022-03-07 22:16 ` Alex Williamson
2022-03-10 15:00 ` Steven Sistare
2022-03-10 18:35 ` Alex Williamson
2022-03-10 19:55 ` Steven Sistare
2022-03-10 22:30 ` Alex Williamson
2022-03-11 16:22 ` Steven Sistare
2021-12-22 19:05 ` [PATCH V7 20/29] vfio-pci: cpr part 2 (msi) Steve Sistare
2021-12-22 19:05 ` [PATCH V7 21/29] vfio-pci: cpr part 3 (intx) Steve Sistare
2021-12-22 19:05 ` [PATCH V7 22/29] vfio-pci: recover from unmap-all-vaddr failure Steve Sistare
2021-12-22 19:05 ` [PATCH V7 23/29] vhost: reset vhost devices for cpr Steve Sistare
2021-12-22 19:05 ` [PATCH V7 24/29] loader: suppress rom_reset during cpr Steve Sistare
2021-12-22 19:05 ` [PATCH V7 25/29] chardev: cpr framework Steve Sistare
2021-12-22 19:05 ` [PATCH V7 26/29] chardev: cpr for simple devices Steve Sistare
2021-12-22 19:05 ` [PATCH V7 27/29] chardev: cpr for pty Steve Sistare
2021-12-22 19:05 ` [PATCH V7 28/29] chardev: cpr for sockets Steve Sistare
2022-02-18 9:03 ` Guoyi Tu
2022-03-03 15:55 ` Steven Sistare
2021-12-22 19:05 ` [PATCH V7 29/29] cpr: only-cpr-capable option Steve Sistare
2022-02-18 9:43 ` Guoyi Tu
2022-03-03 15:54 ` Steven Sistare
2022-01-07 18:45 ` [PATCH V7 00/29] Live Update Steven Sistare
2022-02-18 13:36 ` Steven Sistare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303162103.0dbe93a1.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=jason.zeng@linux.intel.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=steven.sistare@oracle.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).