From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, armbru@redhat.com, fam@euphon.net,
stefanha@redhat.com, eblake@redhat.com, hreitz@redhat.com,
kwolf@redhat.com, vsementsov@virtuozzo.com, jsnow@redhat.com,
Nikita Lapshin <nikita.lapshin@virtuozzo.com>
Subject: [PATCH v6 09/16] block/reqlist: add reqlist_wait_all()
Date: Thu, 3 Mar 2022 20:43:42 +0100 [thread overview]
Message-ID: <20220303194349.2304213-10-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20220303194349.2304213-1-vsementsov@virtuozzo.com>
Add function to wait for all intersecting requests.
To be used in the further commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
---
include/block/reqlist.h | 8 ++++++++
block/reqlist.c | 8 ++++++++
2 files changed, 16 insertions(+)
diff --git a/include/block/reqlist.h b/include/block/reqlist.h
index 0fa1eef259..5253497bae 100644
--- a/include/block/reqlist.h
+++ b/include/block/reqlist.h
@@ -53,6 +53,14 @@ BlockReq *reqlist_find_conflict(BlockReqList *reqs, int64_t offset,
bool coroutine_fn reqlist_wait_one(BlockReqList *reqs, int64_t offset,
int64_t bytes, CoMutex *lock);
+/*
+ * Wait for all intersecting requests. It just calls reqlist_wait_one() in a
+ * loop, caller is responsible to stop producing new requests in this region
+ * in parallel, otherwise reqlist_wait_all() may never return.
+ */
+void coroutine_fn reqlist_wait_all(BlockReqList *reqs, int64_t offset,
+ int64_t bytes, CoMutex *lock);
+
/*
* Shrink request and wake all waiting coroutines (maybe some of them are not
* intersecting with shrunk request).
diff --git a/block/reqlist.c b/block/reqlist.c
index 09fecbd48c..08cb57cfa4 100644
--- a/block/reqlist.c
+++ b/block/reqlist.c
@@ -58,6 +58,14 @@ bool coroutine_fn reqlist_wait_one(BlockReqList *reqs, int64_t offset,
return true;
}
+void coroutine_fn reqlist_wait_all(BlockReqList *reqs, int64_t offset,
+ int64_t bytes, CoMutex *lock)
+{
+ while (reqlist_wait_one(reqs, offset, bytes, lock)) {
+ /* continue */
+ }
+}
+
void coroutine_fn reqlist_shrink_req(BlockReq *req, int64_t new_bytes)
{
if (new_bytes == req->bytes) {
--
2.31.1
next prev parent reply other threads:[~2022-03-03 19:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 19:43 [PATCH v6 00/16] Make image fleecing more usable Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 01/16] block/block-copy: move copy_bitmap initialization to block_copy_state_new() Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 02/16] block/dirty-bitmap: bdrv_merge_dirty_bitmap(): add return value Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 03/16] block/block-copy: block_copy_state_new(): add bitmap parameter Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 04/16] block/copy-before-write: add bitmap open parameter Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 05/16] block/block-copy: add block_copy_reset() Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 06/16] block: intoduce reqlist Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 07/16] block/reqlist: reqlist_find_conflict(): use ranges_overlap() Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 08/16] block/dirty-bitmap: introduce bdrv_dirty_bitmap_status() Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` Vladimir Sementsov-Ogievskiy [this message]
2022-03-03 19:43 ` [PATCH v6 10/16] block/io: introduce block driver snapshot-access API Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 11/16] block: introduce snapshot-access block driver Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 12/16] block: copy-before-write: realize snapshot-access API Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 13/16] iotests/image-fleecing: add test-case for fleecing format node Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 14/16] iotests.py: add qemu_io_pipe_and_status() Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 15/16] iotests/image-fleecing: add test case with bitmap Vladimir Sementsov-Ogievskiy
2022-03-03 19:43 ` [PATCH v6 16/16] iotests/image-fleecing: test push backup with fleecing Vladimir Sementsov-Ogievskiy
2022-03-04 10:20 ` [PATCH v6 00/16] Make image fleecing more usable Hanna Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303194349.2304213-10-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=nikita.lapshin@virtuozzo.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).