From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Thomas Huth <thuth@redhat.com>,
Beraldo Leal <bleal@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Hanna Reitz <hreitz@redhat.com>, Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH 5/5] iotests: fortify compare_images() against crashes
Date: Thu, 3 Mar 2022 20:49:16 -0600 [thread overview]
Message-ID: <20220304024916.mcvswhwaz4ihekoi@redhat.com> (raw)
In-Reply-To: <20220303205902.4106779-6-jsnow@redhat.com>
On Thu, Mar 03, 2022 at 03:59:02PM -0500, John Snow wrote:
> Fority compare_images() to be more discerning about the status codes it
Fortify
> receives. If qemu_img() returns an exit code that implies it didn't
> actually perform the comparison, treat that as an exceptional
> circumstance and force the caller to be aware of the peril.
>
> If a negative test is desired (Perhaps to test how qemu_img compare
perhaps
> behaves on malformed images, for instance), it is still possible to
> catch the exception in the test and deal with that circumstance
> manually.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/qemu-iotests/iotests.py | 21 ++++++++++++++++-----
> 1 file changed, 16 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2022-03-04 2:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 20:58 [PATCH 0/5] iotests: add enhanced debugging info to qemu-img failures John Snow
2022-03-03 20:58 ` [PATCH 1/5] python/utils: add add_visual_margin() text decoration utility John Snow
2022-03-03 22:43 ` Eric Blake
2022-03-04 16:21 ` John Snow
2022-03-03 20:58 ` [PATCH 2/5] python/utils: add VerboseProcessError John Snow
2022-03-04 2:41 ` Eric Blake
2022-03-03 20:59 ` [PATCH 3/5] iotests: Remove explicit checks for qemu_img() == 0 John Snow
2022-03-03 20:59 ` [PATCH 4/5] iotests: make qemu_img raise on non-zero rc by default John Snow
2022-03-04 2:46 ` Eric Blake
2022-03-03 20:59 ` [PATCH 5/5] iotests: fortify compare_images() against crashes John Snow
2022-03-04 2:49 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304024916.mcvswhwaz4ihekoi@redhat.com \
--to=eblake@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).