qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: German Maglione <gmaglione@redhat.com>,
	Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>,
	qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	virtio-fs@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 0/2] virtiofsd: Support FUSE_SYNCFS on unannounced submounts
Date: Fri, 4 Mar 2022 14:56:57 +0100	[thread overview]
Message-ID: <20220304145657.3a5fdec4@bahia> (raw)
In-Reply-To: <YiIB8XnpQPqktxWG@redhat.com>

On Fri, 4 Mar 2022 07:11:29 -0500
Vivek Goyal <vgoyal@redhat.com> wrote:

> On Thu, Mar 03, 2022 at 06:13:21PM +0100, Greg Kurz wrote:
> > This is the current patches I have : one to track submounts
> > and the other to call syncfs() on them. Tested on simple
> > cases only.
> > 
> > I won't be able to work on this anymore, so I'm posting for the
> > records. Anyone is welcome to pick it up as there won't be a v2
> > from my side.
> 
> Thanks Greg. Hopefully somebody else will be able to pick it up.
> 
> What are TODO items to take this patch series to completion.
> 

Compared to the previous try, this basically tracks submount inodes
in a dedicated hash to avoid browsing through all inodes at sync
time.

Given the limited time I had to spend on this, it certainly
requires some more thinking and testing around corner cases.
Since C virtiofsd is being deprecated, I don't think it's
worth investing much in supporting all possible scenarios.
Maybe add sanity checks and proper error handling for things
that would obviously break.

Cheers,

--
Greg

> Vivek
> 
> > 
> > Cheers,
> > 
> > --
> > Greg
> > 
> > Greg Kurz (2):
> >   virtiofsd: Track submounts
> >   virtiofsd: Support FUSE_SYNCFS on unannounced submounts
> > 
> >  tools/virtiofsd/passthrough_ll.c | 61 ++++++++++++++++++++++++++++----
> >  1 file changed, 55 insertions(+), 6 deletions(-)
> > 
> > -- 
> > 2.34.1
> > 
> > 
> 



      reply	other threads:[~2022-03-04 14:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 17:13 [PATCH 0/2] virtiofsd: Support FUSE_SYNCFS on unannounced submounts Greg Kurz
2022-03-03 17:13 ` [PATCH 1/2] virtiofsd: Track submounts Greg Kurz
2022-03-03 17:13 ` [PATCH 2/2] virtiofsd: Support FUSE_SYNCFS on unannounced submounts Greg Kurz
2022-03-04 12:11 ` [PATCH 0/2] " Vivek Goyal
2022-03-04 13:56   ` Greg Kurz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304145657.3a5fdec4@bahia \
    --to=groug@kaod.org \
    --cc=dgilbert@redhat.com \
    --cc=gmaglione@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sebastian.hasler@stuvus.uni-stuttgart.de \
    --cc=stefanha@redhat.com \
    --cc=vgoyal@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).