From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 520CBC433F5 for ; Fri, 4 Mar 2022 18:13:13 +0000 (UTC) Received: from localhost ([::1]:44738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQCQS-0003Cd-AW for qemu-devel@archiver.kernel.org; Fri, 04 Mar 2022 13:13:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQBb0-0006X5-G1 for qemu-devel@nongnu.org; Fri, 04 Mar 2022 12:20:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQBax-0002LU-OF for qemu-devel@nongnu.org; Fri, 04 Mar 2022 12:20:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646414399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ID5mupimfLBZu/spbTsCoV4zKthHncrJ3KdCKqRw40M=; b=ZdXcaooCPscAZ0Eo4LT37MCVCrlMLU/jLYRBzCoZaRZ1ZoZKbB6TuDkNtTmxP009WL/KHG GVI0iyVGDFefU/ofA94GDLkiBBfXPCfhGstrAE12u478y+454TvFhi//99lEVrxPqOV5DI lZcJlQnTrLVgih4RiB+TUP6KOIjzTRE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-256-P_MSywbNMdmwHk_GDVzpTw-1; Fri, 04 Mar 2022 12:19:55 -0500 X-MC-Unique: P_MSywbNMdmwHk_GDVzpTw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 13D5E51E0; Fri, 4 Mar 2022 17:19:55 +0000 (UTC) Received: from redhat.com (unknown [10.2.16.226]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 150FA106F77A; Fri, 4 Mar 2022 17:19:45 +0000 (UTC) Date: Fri, 4 Mar 2022 11:19:44 -0600 From: Eric Blake To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH 2/4] os-posix: refactor code handling the -runas argument Message-ID: <20220304171944.ie7wjbbycxqqzyfd@redhat.com> References: <20220304115657.3177925-1-berrange@redhat.com> <20220304115657.3177925-3-berrange@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220304115657.3177925-3-berrange@redhat.com> User-Agent: NeoMutt/20211029-378-f757a4 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , libvir-list@redhat.com, Stefan Weil , qemu-devel@nongnu.org, Hanna Reitz , Gerd Hoffmann , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Mar 04, 2022 at 11:56:55AM +0000, Daniel P. Berrangé wrote: > Change the change_process_uid() function so that it takes its input as > parameters instead of relying on static global variables. > > Signed-off-by: Daniel P. Berrangé > --- > os-posix.c | 83 +++++++++++++++++++++++++----------------------------- > 1 file changed, 39 insertions(+), 44 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org