qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	libvir-list@redhat.com, "Stefan Weil" <sw@weilnetz.de>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Eric Blake" <eblake@redhat.com>
Subject: [PATCH v2 5/8] softmmu: refactor use of is_daemonized() method
Date: Fri,  4 Mar 2022 18:56:17 +0000	[thread overview]
Message-ID: <20220304185620.3272401-6-berrange@redhat.com> (raw)
In-Reply-To: <20220304185620.3272401-1-berrange@redhat.com>

Use of the is_daemonized() method is isolated to allow it to be
more easily eliminated in a future change.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 softmmu/vl.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/softmmu/vl.c b/softmmu/vl.c
index f6f33e15e4..30342b9df2 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -1371,11 +1371,11 @@ static void qemu_disable_default_devices(void)
     }
 }
 
-static void qemu_create_default_devices(void)
+static void qemu_create_default_devices(bool daemonize)
 {
     MachineClass *machine_class = MACHINE_GET_CLASS(current_machine);
 
-    if (is_daemonized()) {
+    if (daemonize) {
         /* According to documentation and historically, -nographic redirects
          * serial port, parallel port and monitor to stdio, which does not work
          * with -daemonize.  We can redirect these to null instead, but since
@@ -2455,7 +2455,8 @@ static void create_default_memdev(MachineState *ms, const char *path)
                             &error_fatal);
 }
 
-static void qemu_validate_options(const QDict *machine_opts)
+static void qemu_validate_options(const QDict *machine_opts,
+                                  bool daemonize)
 {
     const char *kernel_filename = qdict_get_try_str(machine_opts, "kernel");
     const char *initrd_filename = qdict_get_try_str(machine_opts, "initrd");
@@ -2484,7 +2485,7 @@ static void qemu_validate_options(const QDict *machine_opts)
     }
 
 #ifdef CONFIG_CURSES
-    if (is_daemonized() && dpy.type == DISPLAY_TYPE_CURSES) {
+    if (daemonize && dpy.type == DISPLAY_TYPE_CURSES) {
         error_report("curses display cannot be used with -daemonize");
         exit(1);
     }
@@ -3676,7 +3677,7 @@ void qemu_init(int argc, char **argv, char **envp)
      */
     loc_set_none();
 
-    qemu_validate_options(machine_opts_dict);
+    qemu_validate_options(machine_opts_dict, is_daemonized());
     qemu_process_sugar_options();
 
     /*
@@ -3714,7 +3715,7 @@ void qemu_init(int argc, char **argv, char **envp)
     suspend_mux_open();
 
     qemu_disable_default_devices();
-    qemu_create_default_devices();
+    qemu_create_default_devices(is_daemonized());
     qemu_create_early_backends();
 
     qemu_apply_legacy_machine_options(machine_opts_dict);
-- 
2.34.1



  parent reply	other threads:[~2022-03-04 19:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04 18:56 [PATCH v2 0/8] softmmu: move and refactor -runas, -chroot and -daemonize Daniel P. Berrangé
2022-03-04 18:56 ` [PATCH v2 1/8] softmmu: remove deprecated --enable-fips option Daniel P. Berrangé
2022-03-04 18:56 ` [PATCH v2 2/8] os-posix: refactor code handling the -runas argument Daniel P. Berrangé
2022-03-04 18:56 ` [PATCH v2 3/8] os-posix: refactor code handling the -chroot argument Daniel P. Berrangé
2022-03-04 18:56 ` [PATCH v2 4/8] util: remove use of is_daemonized flag from logging code Daniel P. Berrangé
2022-03-04 21:46   ` Eric Blake
2022-03-04 18:56 ` Daniel P. Berrangé [this message]
2022-03-04 22:02   ` [PATCH v2 5/8] softmmu: refactor use of is_daemonized() method Eric Blake
2022-03-04 18:56 ` [PATCH v2 6/8] chardev: add API to block use of the stdio implementation Daniel P. Berrangé
2022-03-04 22:03   ` Eric Blake
2022-03-04 18:56 ` [PATCH v2 7/8] softmmu: move parsing of -runas, -chroot and -daemonize code Daniel P. Berrangé
2022-03-04 22:09   ` Eric Blake
2022-03-04 18:56 ` [PATCH v2 8/8] softmmu: remove is_daemonized() method Daniel P. Berrangé
2022-03-04 22:11   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304185620.3272401-6-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).