qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	libvir-list@redhat.com, "Stefan Weil" <sw@weilnetz.de>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Eric Blake" <eblake@redhat.com>
Subject: [PATCH v2 8/8] softmmu: remove is_daemonized() method
Date: Fri,  4 Mar 2022 18:56:20 +0000	[thread overview]
Message-ID: <20220304185620.3272401-9-berrange@redhat.com> (raw)
In-Reply-To: <20220304185620.3272401-1-berrange@redhat.com>

There are no longer any users of this method, so it can be removed to
prevent future accidental (mis)use.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 include/sysemu/os-posix.h | 2 --
 include/sysemu/os-win32.h | 5 -----
 os-posix.c                | 5 -----
 stubs/is-daemonized.c     | 9 ---------
 stubs/meson.build         | 1 -
 5 files changed, 22 deletions(-)
 delete mode 100644 stubs/is-daemonized.c

diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
index 390f3f8396..2c375f5b49 100644
--- a/include/sysemu/os-posix.h
+++ b/include/sysemu/os-posix.h
@@ -57,8 +57,6 @@ int os_mlock(void);
 typedef struct timeval qemu_timeval;
 #define qemu_gettimeofday(tp) gettimeofday(tp, NULL)
 
-bool is_daemonized(void);
-
 /**
  * qemu_alloc_stack:
  * @sz: pointer to a size_t holding the requested usable stack size
diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h
index 4879f8731d..a81f4fa9c1 100644
--- a/include/sysemu/os-win32.h
+++ b/include/sysemu/os-win32.h
@@ -76,11 +76,6 @@ typedef struct {
 } qemu_timeval;
 int qemu_gettimeofday(qemu_timeval *tp);
 
-static inline bool is_daemonized(void)
-{
-    return false;
-}
-
 static inline int os_mlock(void)
 {
     return -ENOSYS;
diff --git a/os-posix.c b/os-posix.c
index f598a52a4f..bd1140ab22 100644
--- a/os-posix.c
+++ b/os-posix.c
@@ -232,11 +232,6 @@ void os_set_line_buffering(void)
     setvbuf(stdout, NULL, _IOLBF, 0);
 }
 
-bool is_daemonized(void)
-{
-    return daemonize;
-}
-
 int os_mlock(void)
 {
 #ifdef HAVE_MLOCKALL
diff --git a/stubs/is-daemonized.c b/stubs/is-daemonized.c
deleted file mode 100644
index 8f63325bb2..0000000000
--- a/stubs/is-daemonized.c
+++ /dev/null
@@ -1,9 +0,0 @@
-#include "qemu/osdep.h"
-
-/* Win32 has its own inline stub */
-#ifndef _WIN32
-bool is_daemonized(void)
-{
-    return false;
-}
-#endif
diff --git a/stubs/meson.build b/stubs/meson.build
index d359cbe1ad..3d092b808e 100644
--- a/stubs/meson.build
+++ b/stubs/meson.build
@@ -18,7 +18,6 @@ if linux_io_uring.found()
 endif
 stub_ss.add(files('iothread-lock.c'))
 stub_ss.add(files('isa-bus.c'))
-stub_ss.add(files('is-daemonized.c'))
 if libaio.found()
   stub_ss.add(files('linux-aio.c'))
 endif
-- 
2.34.1



  parent reply	other threads:[~2022-03-04 19:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04 18:56 [PATCH v2 0/8] softmmu: move and refactor -runas, -chroot and -daemonize Daniel P. Berrangé
2022-03-04 18:56 ` [PATCH v2 1/8] softmmu: remove deprecated --enable-fips option Daniel P. Berrangé
2022-03-04 18:56 ` [PATCH v2 2/8] os-posix: refactor code handling the -runas argument Daniel P. Berrangé
2022-03-04 18:56 ` [PATCH v2 3/8] os-posix: refactor code handling the -chroot argument Daniel P. Berrangé
2022-03-04 18:56 ` [PATCH v2 4/8] util: remove use of is_daemonized flag from logging code Daniel P. Berrangé
2022-03-04 21:46   ` Eric Blake
2022-03-04 18:56 ` [PATCH v2 5/8] softmmu: refactor use of is_daemonized() method Daniel P. Berrangé
2022-03-04 22:02   ` Eric Blake
2022-03-04 18:56 ` [PATCH v2 6/8] chardev: add API to block use of the stdio implementation Daniel P. Berrangé
2022-03-04 22:03   ` Eric Blake
2022-03-04 18:56 ` [PATCH v2 7/8] softmmu: move parsing of -runas, -chroot and -daemonize code Daniel P. Berrangé
2022-03-04 22:09   ` Eric Blake
2022-03-04 18:56 ` Daniel P. Berrangé [this message]
2022-03-04 22:11   ` [PATCH v2 8/8] softmmu: remove is_daemonized() method Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304185620.3272401-9-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).