From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Eric Blake" <eblake@redhat.com>
Subject: [PATCH v2 00/12] nbd: enable use of TLS on non-TCP transports and other TLS improvements
Date: Fri, 4 Mar 2022 19:35:58 +0000 [thread overview]
Message-ID: <20220304193610.3293146-1-berrange@redhat.com> (raw)
This series was principally motivated by a desire to enabl use of TLS
on non-TCP transports. For x509 certificates this means we need a way
to set the hostname to use for validation. This also lets us override
the hostname when connecting on a TCP transport that is tunnelled or
port-forwarded. It also unlocks the ability to use PSK (pre-shared
keys) with UNIX sockets which would always have worked, had it not
been blocked by explicit checks in NBD code.
NB, the first patch in this series is common with my corresponding
migration series for TLS
https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg00556.html
In v2:
- Tweak the filter for qemu-nbd export list to expose export name
- Add "since" tag to QAPI addition
- Minor docs fixes
Daniel P. Berrangé (12):
crypto: mandate a hostname when checking x509 creds on a client
block: pass desired TLS hostname through from block driver client
block/nbd: support override of hostname for TLS certificate validation
qemu-nbd: add --tls-hostname option for TLS certificate validation
block/nbd: don't restrict TLS usage to IP sockets
tests/qemu-iotests: add QEMU_IOTESTS_REGEN=1 to update reference file
tests/qemu-iotests: expand _filter_nbd rules
tests/qemu-iotests: introduce filter for qemu-nbd export list
tests/qemu-iotests: convert NBD TLS test to use standard filters
tests/qemu-iotests: validate NBD TLS with hostname mismatch
tests/qemu-iotests: validate NBD TLS with UNIX sockets
tests/qemu-iotests: validate NBD TLS with UNIX sockets and PSK
block/nbd.c | 25 +++++---
blockdev-nbd.c | 6 --
crypto/tlssession.c | 6 ++
docs/tools/qemu-nbd.rst | 13 +++++
include/block/nbd.h | 3 +-
nbd/client-connection.c | 12 +++-
qapi/block-core.json | 3 +
qemu-nbd.c | 25 ++++++--
tests/qemu-iotests/233 | 99 +++++++++++++++++++++++++++-----
tests/qemu-iotests/233.out | 56 +++++++++++++++---
tests/qemu-iotests/241 | 6 +-
tests/qemu-iotests/241.out | 6 ++
tests/qemu-iotests/common.filter | 9 +++
tests/qemu-iotests/common.tls | 31 +++++++++-
tests/qemu-iotests/testrunner.py | 6 ++
15 files changed, 255 insertions(+), 51 deletions(-)
--
2.34.1
next reply other threads:[~2022-03-04 19:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 19:35 Daniel P. Berrangé [this message]
2022-03-04 19:35 ` [PATCH v2 01/12] crypto: mandate a hostname when checking x509 creds on a client Daniel P. Berrangé
2022-03-04 19:36 ` [PATCH v2 02/12] block: pass desired TLS hostname through from block driver client Daniel P. Berrangé
2022-03-04 19:36 ` [PATCH v2 03/12] block/nbd: support override of hostname for TLS certificate validation Daniel P. Berrangé
2022-03-04 19:36 ` [PATCH v2 04/12] qemu-nbd: add --tls-hostname option " Daniel P. Berrangé
2022-03-04 19:36 ` [PATCH v2 05/12] block/nbd: don't restrict TLS usage to IP sockets Daniel P. Berrangé
2022-03-04 19:36 ` [PATCH v2 06/12] tests/qemu-iotests: add QEMU_IOTESTS_REGEN=1 to update reference file Daniel P. Berrangé
2022-03-04 19:36 ` [PATCH v2 07/12] tests/qemu-iotests: expand _filter_nbd rules Daniel P. Berrangé
2022-03-04 19:36 ` [PATCH v2 08/12] tests/qemu-iotests: introduce filter for qemu-nbd export list Daniel P. Berrangé
2022-03-04 20:38 ` Eric Blake
2022-03-04 19:36 ` [PATCH v2 09/12] tests/qemu-iotests: convert NBD TLS test to use standard filters Daniel P. Berrangé
2022-03-04 19:36 ` [PATCH v2 10/12] tests/qemu-iotests: validate NBD TLS with hostname mismatch Daniel P. Berrangé
2022-03-04 19:36 ` [PATCH v2 11/12] tests/qemu-iotests: validate NBD TLS with UNIX sockets Daniel P. Berrangé
2022-03-04 21:08 ` Eric Blake
2022-03-04 19:36 ` [PATCH v2 12/12] tests/qemu-iotests: validate NBD TLS with UNIX sockets and PSK Daniel P. Berrangé
2022-03-04 21:27 ` Eric Blake
2022-03-07 16:59 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304193610.3293146-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).