From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Thomas Huth <thuth@redhat.com>,
Beraldo Leal <bleal@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Hanna Reitz <hreitz@redhat.com>, Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH v2 3/5] iotests: Remove explicit checks for qemu_img() == 0
Date: Fri, 4 Mar 2022 14:23:26 -0600 [thread overview]
Message-ID: <20220304202326.cj265z3pxrm45c34@redhat.com> (raw)
In-Reply-To: <20220304194746.486226-4-jsnow@redhat.com>
On Fri, Mar 04, 2022 at 02:47:44PM -0500, John Snow wrote:
> qemu_img() returning zero ought to be the rule, not the
> exception. Remove all explicit checks against the condition in
> preparation for making non-zero returns an Exception.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> +++ b/tests/qemu-iotests/310
> @@ -105,8 +105,8 @@ with iotests.FilePath('base.img') as base_img_path, \
> log('')
>
> # Detach backing to check that we can read the data from the top level now
> - assert qemu_img('rebase', '-u', '-b', '', '-f', iotests.imgfmt,
> - top_img_path) == 0
> + qemu_img('rebase', '-u', '-b', '', '-f', iotests.imgfmt,
> + top_img_path)
You collapsed other wrapped lines into one where they fit, why not
this one? But it's not essential.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2022-03-04 20:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 19:47 [PATCH v2 0/5] iotests: add enhanced debugging info to qemu-img failures John Snow
2022-03-04 19:47 ` [PATCH v2 1/5] python/utils: add add_visual_margin() text decoration utility John Snow
2022-03-04 19:47 ` [PATCH v2 2/5] python/utils: add VerboseProcessError John Snow
2022-03-04 19:47 ` [PATCH v2 3/5] iotests: Remove explicit checks for qemu_img() == 0 John Snow
2022-03-04 20:23 ` Eric Blake [this message]
2022-03-05 2:03 ` John Snow
2022-03-04 19:47 ` [PATCH v2 4/5] iotests: make qemu_img raise on non-zero rc by default John Snow
2022-03-04 19:47 ` [PATCH v2 5/5] iotests: fortify compare_images() against crashes John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304202326.cj265z3pxrm45c34@redhat.com \
--to=eblake@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).