* Re: [PATCH] hw/block: m25p80: Add support for w25q01jvq
2022-03-04 18:09 [PATCH] hw/block: m25p80: Add support for w25q01jvq Patrick Williams
@ 2022-03-04 19:30 ` Philippe Mathieu-Daudé
2022-03-04 19:47 ` Michael Walle
2022-03-07 16:39 ` Francisco Iglesias
2022-03-08 8:02 ` Cédric Le Goater
2 siblings, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-03-04 19:30 UTC (permalink / raw)
To: Patrick Williams
Cc: Kevin Wolf, open list:Block layer core, Potin Lai,
Alistair Francis, open list:All patches CC here, Hanna Reitz,
Michael Walle
On 4/3/22 19:09, Patrick Williams wrote:
> The w25q01jvq is a 128MB part. Support is being added to the kernel[1]
> and the two have been tested together.
>
> 1. https://lore.kernel.org/lkml/20220222092222.23108-1-potin.lai@quantatw.com/
>
> Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
> Cc: Potin Lai <potin.lai@quantatw.com>
> ---
> hw/block/m25p80.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index c6bf3c6bfa..7d3d8b12e0 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -340,6 +340,7 @@ static const FlashPartInfo known_devices[] = {
> { INFO("w25q80bl", 0xef4014, 0, 64 << 10, 16, ER_4K) },
> { INFO("w25q256", 0xef4019, 0, 64 << 10, 512, ER_4K) },
> { INFO("w25q512jv", 0xef4020, 0, 64 << 10, 1024, ER_4K) },
> + { INFO("w25q01jvq", 0xef4021, 0, 64 << 10, 2048, ER_4K) },
> };
>
> typedef enum {
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hw/block: m25p80: Add support for w25q01jvq
2022-03-04 19:30 ` Philippe Mathieu-Daudé
@ 2022-03-04 19:47 ` Michael Walle
2022-03-05 8:06 ` Cédric Le Goater
0 siblings, 1 reply; 6+ messages in thread
From: Michael Walle @ 2022-03-04 19:47 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Kevin Wolf, open list:Block layer core, Potin Lai,
Alistair Francis, open list:All patches CC here, Patrick Williams,
Hanna Reitz
Am 2022-03-04 20:30, schrieb Philippe Mathieu-Daudé:
> On 4/3/22 19:09, Patrick Williams wrote:
>> The w25q01jvq is a 128MB part. Support is being added to the
>> kernel[1]
>> and the two have been tested together.
>>
>> 1.
>> https://lore.kernel.org/lkml/20220222092222.23108-1-potin.lai@quantatw.com/
>>
>> Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
>> Cc: Potin Lai <potin.lai@quantatw.com>
>> ---
>> hw/block/m25p80.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
>> index c6bf3c6bfa..7d3d8b12e0 100644
>> --- a/hw/block/m25p80.c
>> +++ b/hw/block/m25p80.c
>> @@ -340,6 +340,7 @@ static const FlashPartInfo known_devices[] = {
>> { INFO("w25q80bl", 0xef4014, 0, 64 << 10, 16, ER_4K)
>> },
>> { INFO("w25q256", 0xef4019, 0, 64 << 10, 512, ER_4K)
>> },
>> { INFO("w25q512jv", 0xef4020, 0, 64 << 10, 1024, ER_4K)
>> },
>> + { INFO("w25q01jvq", 0xef4021, 0, 64 << 10, 2048, ER_4K)
>> },
>> };
>> typedef enum {
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
FWIW, the linux spi nor subsystem will rely more and more on the SFDP
for newer flashes. I had a quick look at qemu's source and command
RDSFDP (0x5a) isn't emulated. Might be worth implementing ;)
-michael
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hw/block: m25p80: Add support for w25q01jvq
2022-03-04 19:47 ` Michael Walle
@ 2022-03-05 8:06 ` Cédric Le Goater
0 siblings, 0 replies; 6+ messages in thread
From: Cédric Le Goater @ 2022-03-05 8:06 UTC (permalink / raw)
To: Michael Walle, Philippe Mathieu-Daudé
Cc: Kevin Wolf, open list:Block layer core, Francisco Iglesias,
Potin Lai, Alistair Francis, open list:All patches CC here,
Patrick Williams, Hanna Reitz
On 3/4/22 20:47, Michael Walle wrote:
> Am 2022-03-04 20:30, schrieb Philippe Mathieu-Daudé:
>> On 4/3/22 19:09, Patrick Williams wrote:
>>> The w25q01jvq is a 128MB part. Support is being added to the kernel[1]
>>> and the two have been tested together.
>>>
>>> 1. https://lore.kernel.org/lkml/20220222092222.23108-1-potin.lai@quantatw.com/
>>>
>>> Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
>>> Cc: Potin Lai <potin.lai@quantatw.com>
>>> ---
>>> hw/block/m25p80.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
>>> index c6bf3c6bfa..7d3d8b12e0 100644
>>> --- a/hw/block/m25p80.c
>>> +++ b/hw/block/m25p80.c
>>> @@ -340,6 +340,7 @@ static const FlashPartInfo known_devices[] = {
>>> { INFO("w25q80bl", 0xef4014, 0, 64 << 10, 16, ER_4K) },
>>> { INFO("w25q256", 0xef4019, 0, 64 << 10, 512, ER_4K) },
>>> { INFO("w25q512jv", 0xef4020, 0, 64 << 10, 1024, ER_4K) },
>>> + { INFO("w25q01jvq", 0xef4021, 0, 64 << 10, 2048, ER_4K) },
>>> };
>>> typedef enum {
>>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> FWIW, the linux spi nor subsystem will rely more and more on the SFDP
> for newer flashes. I had a quick look at qemu's source and command
> RDSFDP (0x5a) isn't emulated. Might be worth implementing ;)
Indeed. I really pulled my hair out when mx25l25635_post_bfpt_fixups was
introduced for the MX25L25635F to activate 4B opcodes.
I have sent a patchset adding SFDP support :
http://patchwork.ozlabs.org/project/qemu-devel/list/?series=199024
but Francisco had comments I didn't have time to address.
Anyhow, the series is still in use in the aspeed branch :
https://github.com/legoater/qemu/commits/aspeed-7.0
I can respin.
Thanks,
C.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hw/block: m25p80: Add support for w25q01jvq
2022-03-04 18:09 [PATCH] hw/block: m25p80: Add support for w25q01jvq Patrick Williams
2022-03-04 19:30 ` Philippe Mathieu-Daudé
@ 2022-03-07 16:39 ` Francisco Iglesias
2022-03-08 8:02 ` Cédric Le Goater
2 siblings, 0 replies; 6+ messages in thread
From: Francisco Iglesias @ 2022-03-07 16:39 UTC (permalink / raw)
To: Patrick Williams
Cc: Kevin Wolf, open list:Block layer core, Potin Lai,
Alistair Francis, open list:All patches CC here, Hanna Reitz
On [2022 Mar 04] Fri 12:09:20, Patrick Williams wrote:
> The w25q01jvq is a 128MB part. Support is being added to the kernel[1]
> and the two have been tested together.
>
> 1. https://lore.kernel.org/lkml/20220222092222.23108-1-potin.lai@quantatw.com/
>
> Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
> Cc: Potin Lai <potin.lai@quantatw.com>
> ---
> hw/block/m25p80.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index c6bf3c6bfa..7d3d8b12e0 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -340,6 +340,7 @@ static const FlashPartInfo known_devices[] = {
> { INFO("w25q80bl", 0xef4014, 0, 64 << 10, 16, ER_4K) },
> { INFO("w25q256", 0xef4019, 0, 64 << 10, 512, ER_4K) },
> { INFO("w25q512jv", 0xef4020, 0, 64 << 10, 1024, ER_4K) },
> + { INFO("w25q01jvq", 0xef4021, 0, 64 << 10, 2048, ER_4K) },
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
> };
>
> typedef enum {
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hw/block: m25p80: Add support for w25q01jvq
2022-03-04 18:09 [PATCH] hw/block: m25p80: Add support for w25q01jvq Patrick Williams
2022-03-04 19:30 ` Philippe Mathieu-Daudé
2022-03-07 16:39 ` Francisco Iglesias
@ 2022-03-08 8:02 ` Cédric Le Goater
2 siblings, 0 replies; 6+ messages in thread
From: Cédric Le Goater @ 2022-03-08 8:02 UTC (permalink / raw)
To: Patrick Williams
Cc: Kevin Wolf, open list:Block layer core, Potin Lai,
Alistair Francis, open list:All patches CC here, Hanna Reitz
On 3/4/22 19:09, Patrick Williams wrote:
> The w25q01jvq is a 128MB part. Support is being added to the kernel[1]
> and the two have been tested together.
>
> 1. https://lore.kernel.org/lkml/20220222092222.23108-1-potin.lai@quantatw.com/
>
> Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
> Cc: Potin Lai <potin.lai@quantatw.com>
> ---
> hw/block/m25p80.c | 1 +
> 1 file changed, 1 insertion(+)
If that's ok with the maintainers, I am going to take this patch through
the aspeed machine queue since the new 'bletchley-bmc' machine depends
on it :
http://patchwork.ozlabs.org/project/qemu-devel/patch/20220305000656.1944589-2-patrick@stwcx.xyz/
I should send the PR today.
Thanks,
C.
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index c6bf3c6bfa..7d3d8b12e0 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -340,6 +340,7 @@ static const FlashPartInfo known_devices[] = {
> { INFO("w25q80bl", 0xef4014, 0, 64 << 10, 16, ER_4K) },
> { INFO("w25q256", 0xef4019, 0, 64 << 10, 512, ER_4K) },
> { INFO("w25q512jv", 0xef4020, 0, 64 << 10, 1024, ER_4K) },
> + { INFO("w25q01jvq", 0xef4021, 0, 64 << 10, 2048, ER_4K) },
> };
>
> typedef enum {
^ permalink raw reply [flat|nested] 6+ messages in thread