From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au
Subject: [PATCH 0/9] add LOG_UNSUPP log type + mark hcalls as unsupp
Date: Mon, 7 Mar 2022 16:15:44 -0300 [thread overview]
Message-ID: <20220307191553.429236-1-danielhb413@gmail.com> (raw)
Hi,
I got a lot of noise trying to debug an AIX guest in a pseries machine when running with
'-d unimp'. The reason is that there is no distinction between features
(in my case, hypercalls) that are unimplemented because we never considered,
versus features that we made a design choice not to implement.
This series adds a new log type, LOG_UNSUPP, as a way to filter the
second case. After changing the log level of existing unsupported
pseries hypercalls, -d unimp was reporting just the ones that I need to
worry about and decide whether we should implement it or mark as
unsupported in our model. After this series there's still one hypercall
thgat is being thrown by AIX. We'll deal with that another day.
I am posting this a little too close of the soft freeze. If we manage
to get it reviewed in time, since it's a debug QoL change that doesn't
break anything, I'd say we take it.
Also, I didn't find the maintainer for the util/log.c file. Let me know
if I need to CC someone in special for this file.
Daniel Henrique Barboza (9):
util/log.c: add LOG_UNSUPP type
hw/ppc/spapr_hcall.c: log h_clean_slb() as unsupported
hw/ppc/spapr_hcall.c: log h_invalidate_pid() as unsupported
hw/ppc/spapr_hcall.c: log h_copy_tofrom_guest() as unsupported
hw/ppc/spapr_hcall.c: log H_GET_EM_PARMS as unsupported
hw/ppc/spapr_hcall.c: log H_BEST_ENERGY as unsupported
hw/ppc/spapr_hcall.c: log H_QUERY_VAS_CAPABILITIES as unsupported
hw/ppc/spapr_hcall.c: log H_GET_PPP as unsupported
hw/ppc/spapr_hcall.c: log H_VIOCTL as unsupported
hw/ppc/spapr_hcall.c | 98 +++++++++++++++++++++++++++++++++++++++++-
include/hw/ppc/spapr.h | 3 ++
include/qemu/log.h | 3 +-
util/log.c | 2 +
4 files changed, 103 insertions(+), 3 deletions(-)
--
2.35.1
next reply other threads:[~2022-03-07 19:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 19:15 Daniel Henrique Barboza [this message]
2022-03-07 19:15 ` [PATCH 1/9] util/log.c: add LOG_UNSUPP type Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 2/9] hw/ppc/spapr_hcall.c: log h_clean_slb() as unsupported Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 3/9] hw/ppc/spapr_hcall.c: log h_invalidate_pid() " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 4/9] hw/ppc/spapr_hcall.c: log h_copy_tofrom_guest() " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 5/9] hw/ppc/spapr_hcall.c: log H_GET_EM_PARMS " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 6/9] hw/ppc/spapr_hcall.c: log H_BEST_ENERGY " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 7/9] hw/ppc/spapr_hcall.c: log H_QUERY_VAS_CAPABILITIES " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 8/9] hw/ppc/spapr_hcall.c: log H_GET_PPP " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 9/9] hw/ppc/spapr_hcall.c: log H_VIOCTL " Daniel Henrique Barboza
2022-03-07 19:58 ` [PATCH 0/9] add LOG_UNSUPP log type + mark hcalls as unsupp Philippe Mathieu-Daudé
2022-03-07 20:21 ` Peter Maydell
2022-03-07 22:00 ` Daniel Henrique Barboza
2022-03-08 9:18 ` Peter Maydell
2022-03-08 12:33 ` Daniel Henrique Barboza
2022-03-08 13:29 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307191553.429236-1-danielhb413@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).