From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au
Subject: [PATCH 1/9] util/log.c: add LOG_UNSUPP type
Date: Mon, 7 Mar 2022 16:15:45 -0300 [thread overview]
Message-ID: <20220307191553.429236-2-danielhb413@gmail.com> (raw)
In-Reply-To: <20220307191553.429236-1-danielhb413@gmail.com>
The existing log type 'LOG_UNIMP' is being used as a way to indicate
that a certain feature is not implemented, and to indicate that a
feature is unsupported. Most of the time both cases are similar, until
you want to debug a guest that is running a not so common OS (e.g. AIX
guest in a pseries machine).
The result is that you can be overwhelmed with lots of '-d unimp'
messages of hypercalls and have to do code searches to verify whether a
specific hypercall is something we never considered adding versus
something that we decided to not support. Note that while the first case
is eligible for further investigation the second is already settled. It
would be helpful to able to distinguish between both.
This patch adds a new log type called LOG_UNSUPP to represent this
subset of features that we are aware of and we decided to not support.
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
include/qemu/log.h | 3 ++-
util/log.c | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/qemu/log.h b/include/qemu/log.h
index 9b80660207..884a81495b 100644
--- a/include/qemu/log.h
+++ b/include/qemu/log.h
@@ -14,7 +14,7 @@ typedef struct QemuLogFile {
extern QemuLogFile *qemu_logfile;
-/*
+/*
* The new API:
*
*/
@@ -64,6 +64,7 @@ static inline bool qemu_log_separate(void)
#define CPU_LOG_PLUGIN (1 << 18)
/* LOG_STRACE is used for user-mode strace logging. */
#define LOG_STRACE (1 << 19)
+#define LOG_UNSUPP (1 << 20)
/* Lock output for a series of related logs. Since this is not needed
* for a single qemu_log / qemu_log_mask / qemu_log_mask_and_addr, we
diff --git a/util/log.c b/util/log.c
index 2ee1500bee..3e19859ab3 100644
--- a/util/log.c
+++ b/util/log.c
@@ -334,6 +334,8 @@ const QEMULogItem qemu_log_items[] = {
#endif
{ LOG_STRACE, "strace",
"log every user-mode syscall, its input, and its result" },
+ { LOG_UNSUPP, "unsupp",
+ "log unsupported functionality" },
{ 0, NULL, NULL },
};
--
2.35.1
next prev parent reply other threads:[~2022-03-07 19:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 19:15 [PATCH 0/9] add LOG_UNSUPP log type + mark hcalls as unsupp Daniel Henrique Barboza
2022-03-07 19:15 ` Daniel Henrique Barboza [this message]
2022-03-07 19:15 ` [PATCH 2/9] hw/ppc/spapr_hcall.c: log h_clean_slb() as unsupported Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 3/9] hw/ppc/spapr_hcall.c: log h_invalidate_pid() " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 4/9] hw/ppc/spapr_hcall.c: log h_copy_tofrom_guest() " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 5/9] hw/ppc/spapr_hcall.c: log H_GET_EM_PARMS " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 6/9] hw/ppc/spapr_hcall.c: log H_BEST_ENERGY " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 7/9] hw/ppc/spapr_hcall.c: log H_QUERY_VAS_CAPABILITIES " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 8/9] hw/ppc/spapr_hcall.c: log H_GET_PPP " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 9/9] hw/ppc/spapr_hcall.c: log H_VIOCTL " Daniel Henrique Barboza
2022-03-07 19:58 ` [PATCH 0/9] add LOG_UNSUPP log type + mark hcalls as unsupp Philippe Mathieu-Daudé
2022-03-07 20:21 ` Peter Maydell
2022-03-07 22:00 ` Daniel Henrique Barboza
2022-03-08 9:18 ` Peter Maydell
2022-03-08 12:33 ` Daniel Henrique Barboza
2022-03-08 13:29 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307191553.429236-2-danielhb413@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).