qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
	qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au
Subject: [PATCH 7/9] hw/ppc/spapr_hcall.c: log H_QUERY_VAS_CAPABILITIES as unsupported
Date: Mon,  7 Mar 2022 16:15:51 -0300	[thread overview]
Message-ID: <20220307191553.429236-8-danielhb413@gmail.com> (raw)
In-Reply-To: <20220307191553.429236-1-danielhb413@gmail.com>

This hcall is VAS (Virtual Accelerator Switchboard) related. VAS is a
hardware feature that allows kernelspace and userspace to communicate
directly with Nested Accelerators (NX). A description of VAS can be
found at [1].

QEMU does not implement neither VAS nor NXs. AIX guests will query VAS
capabilities once during boot.

Log this hcall as unsupported. It is worth noticing that VAS has a
handful of other hcalls (H_ALLOCATE_VAS_WINDOW, H_QUERY_VAS_WINDOW,
H_GET_NX_FAULT and others), but the AIX guest seems to be satisfied
when H_QUERY_VAS_CAPABILITIES returns H_FUNCTION and give up trying
the others. This means that there is no need to log all of them as
unsupported in QEMU.

[1] https://www.kernel.org/doc/html/latest/powerpc/vas-api.html

Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 hw/ppc/spapr_hcall.c   | 18 ++++++++++++++++++
 include/hw/ppc/spapr.h |  1 +
 2 files changed, 19 insertions(+)

diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
index db6cb6bb89..fdce44daf7 100644
--- a/hw/ppc/spapr_hcall.c
+++ b/hw/ppc/spapr_hcall.c
@@ -1589,6 +1589,20 @@ static target_ulong h_best_energy(PowerPCCPU *cpu,
     return H_FUNCTION;
 }
 
+static target_ulong h_query_vas_capabilities(PowerPCCPU *cpu,
+                                             SpaprMachineState *spapr,
+                                             target_ulong opcode,
+                                             target_ulong *args)
+{
+    /*
+     * This HCALL is VAS (Virtual Accelerator Switchboard) related. VAS
+     * is not supported in QEMU.
+     */
+    qemu_log_mask(LOG_UNSUPP, "Unsupported SPAPR hcall 0x"TARGET_FMT_lx"%s\n",
+                  opcode, " (H_QUERY_VAS_CAPABILITIES)");
+    return H_FUNCTION;
+}
+
 /*
  * When this handler returns, the environment is switched to the L2 guest
  * and TCG begins running that. spapr_exit_nested() performs the switch from
@@ -1931,6 +1945,10 @@ static void hypercall_register_types(void)
     /* Unsupported PEM option h-calls */
     spapr_register_hypercall(H_GET_EM_PARMS, h_get_em_parms);
     spapr_register_hypercall(H_BEST_ENERGY, h_best_energy);
+
+    /* Unsupported VAS h-calls */
+    spapr_register_hypercall(H_QUERY_VAS_CAPABILITIES,
+                             h_query_vas_capabilities);
 }
 
 type_init(hypercall_register_types)
diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index 7995bc0cb6..10df519b0a 100644
--- a/include/hw/ppc/spapr.h
+++ b/include/hw/ppc/spapr.h
@@ -545,6 +545,7 @@ struct SpaprMachineState {
 #define H_INVALIDATE_PID        0x378
 #define H_REGISTER_PROC_TBL     0x37C
 #define H_SIGNAL_SYS_RESET      0x380
+#define H_QUERY_VAS_CAPABILITIES 0x398
 
 #define H_INT_GET_SOURCE_INFO   0x3A8
 #define H_INT_SET_SOURCE_CONFIG 0x3AC
-- 
2.35.1



  parent reply	other threads:[~2022-03-07 19:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 19:15 [PATCH 0/9] add LOG_UNSUPP log type + mark hcalls as unsupp Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 1/9] util/log.c: add LOG_UNSUPP type Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 2/9] hw/ppc/spapr_hcall.c: log h_clean_slb() as unsupported Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 3/9] hw/ppc/spapr_hcall.c: log h_invalidate_pid() " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 4/9] hw/ppc/spapr_hcall.c: log h_copy_tofrom_guest() " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 5/9] hw/ppc/spapr_hcall.c: log H_GET_EM_PARMS " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 6/9] hw/ppc/spapr_hcall.c: log H_BEST_ENERGY " Daniel Henrique Barboza
2022-03-07 19:15 ` Daniel Henrique Barboza [this message]
2022-03-07 19:15 ` [PATCH 8/9] hw/ppc/spapr_hcall.c: log H_GET_PPP " Daniel Henrique Barboza
2022-03-07 19:15 ` [PATCH 9/9] hw/ppc/spapr_hcall.c: log H_VIOCTL " Daniel Henrique Barboza
2022-03-07 19:58 ` [PATCH 0/9] add LOG_UNSUPP log type + mark hcalls as unsupp Philippe Mathieu-Daudé
2022-03-07 20:21 ` Peter Maydell
2022-03-07 22:00   ` Daniel Henrique Barboza
2022-03-08  9:18     ` Peter Maydell
2022-03-08 12:33       ` Daniel Henrique Barboza
2022-03-08 13:29       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220307191553.429236-8-danielhb413@gmail.com \
    --to=danielhb413@gmail.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).