From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Thomas Huth <thuth@redhat.com>,
Beraldo Leal <bleal@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Hanna Reitz <hreitz@redhat.com>, Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH v3 3/5] iotests: Remove explicit checks for qemu_img() == 0
Date: Tue, 8 Mar 2022 09:15:54 -0600 [thread overview]
Message-ID: <20220308151554.tvew6nriqpt5i2vq@redhat.com> (raw)
In-Reply-To: <20220308015728.1269649-4-jsnow@redhat.com>
On Mon, Mar 07, 2022 at 08:57:26PM -0500, John Snow wrote:
> qemu_img() returning zero ought to be the rule, not the
> exception. Remove all explicit checks against the condition in
> preparation for making non-zero returns an Exception.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
As this is a testsuite improvement rather than a new feature, I think
it's fine for the series to go in during soft freeze.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2022-03-08 15:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 1:57 [PATCH v3 0/5] iotests: add enhanced debugging info to qemu-img failures John Snow
2022-03-08 1:57 ` [PATCH v3 1/5] python/utils: add add_visual_margin() text decoration utility John Snow
2022-03-17 10:29 ` Hanna Reitz
2022-03-08 1:57 ` [PATCH v3 2/5] python/utils: add VerboseProcessError John Snow
2022-03-17 9:23 ` Hanna Reitz
2022-03-17 15:13 ` John Snow
2022-03-17 15:56 ` Hanna Reitz
2022-03-17 16:31 ` John Snow
2022-03-17 16:34 ` Hanna Reitz
2022-03-17 16:48 ` John Snow
2022-03-08 1:57 ` [PATCH v3 3/5] iotests: Remove explicit checks for qemu_img() == 0 John Snow
2022-03-08 15:15 ` Eric Blake [this message]
2022-03-08 17:04 ` John Snow
2022-03-17 10:28 ` Hanna Reitz
2022-03-08 1:57 ` [PATCH v3 4/5] iotests: make qemu_img raise on non-zero rc by default John Snow
2022-03-17 10:25 ` Hanna Reitz
2022-03-17 10:41 ` Hanna Reitz
2022-03-17 14:23 ` John Snow
2022-03-17 15:24 ` John Snow
2022-03-17 15:58 ` Hanna Reitz
2022-03-17 16:06 ` Hanna Reitz
2022-03-08 1:57 ` [PATCH v3 5/5] iotests: fortify compare_images() against crashes John Snow
2022-03-17 10:28 ` Hanna Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308151554.tvew6nriqpt5i2vq@redhat.com \
--to=eblake@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).