qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: "Eugenio Pérez" <eperezma@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>
Subject: [PULL V2 13/15] vdpa: Adapt vhost_vdpa_get_vring_base to SVQ
Date: Thu, 10 Mar 2022 10:39:05 +0800	[thread overview]
Message-ID: <20220310023907.2443-14-jasowang@redhat.com> (raw)
In-Reply-To: <20220310023907.2443-1-jasowang@redhat.com>

From: Eugenio Pérez <eperezma@redhat.com>

This is needed to achieve migration, so the destination can restore its
index.

Setting base as last used idx, so destination will see as available all
the entries that the device did not use, including the in-flight
processing ones.

This is ok for networking, but other kinds of devices might have
problems with these retransmissions.

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 hw/virtio/vhost-vdpa.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index a7db129..12ca10f 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1144,8 +1144,25 @@ static int vhost_vdpa_set_vring_base(struct vhost_dev *dev,
 static int vhost_vdpa_get_vring_base(struct vhost_dev *dev,
                                        struct vhost_vring_state *ring)
 {
+    struct vhost_vdpa *v = dev->opaque;
     int ret;
 
+    if (v->shadow_vqs_enabled) {
+        VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs,
+                                                      ring->index);
+
+        /*
+         * Setting base as last used idx, so destination will see as available
+         * all the entries that the device did not use, including the in-flight
+         * processing ones.
+         *
+         * TODO: This is ok for networking, but other kinds of devices might
+         * have problems with these retransmissions.
+         */
+        ring->num = svq->last_used_idx;
+        return 0;
+    }
+
     ret = vhost_vdpa_call(dev, VHOST_GET_VRING_BASE, ring);
     trace_vhost_vdpa_get_vring_base(dev, ring->index, ring->num);
     return ret;
-- 
2.7.4



  parent reply	other threads:[~2022-03-10  2:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10  2:38 [PULL V2 00/15] Net patches Jason Wang
2022-03-10  2:38 ` [PULL V2 01/15] virtio-net: fix map leaking on error during receive Jason Wang
2022-03-10  2:38 ` [PULL V2 02/15] vhost: Add VhostShadowVirtqueue Jason Wang
2022-03-10  2:38 ` [PULL V2 03/15] vhost: Add Shadow VirtQueue kick forwarding capabilities Jason Wang
2022-03-10  2:38 ` [PULL V2 04/15] vhost: Add Shadow VirtQueue call " Jason Wang
2022-03-10  2:38 ` [PULL V2 05/15] vhost: Add vhost_svq_valid_features to shadow vq Jason Wang
2022-03-10  2:38 ` [PULL V2 06/15] virtio: Add vhost_svq_get_vring_addr Jason Wang
2022-03-10  2:38 ` [PULL V2 07/15] vdpa: adapt vhost_ops callbacks to svq Jason Wang
2022-03-10  2:39 ` [PULL V2 08/15] vhost: Shadow virtqueue buffers forwarding Jason Wang
2022-03-10  2:39 ` [PULL V2 09/15] util: Add iova_tree_alloc_map Jason Wang
2022-03-10  2:39 ` [PULL V2 10/15] util: add iova_tree_find_iova Jason Wang
2022-03-10  2:39 ` [PULL V2 11/15] vhost: Add VhostIOVATree Jason Wang
2022-03-10  2:39 ` [PULL V2 12/15] vdpa: Add custom IOTLB translations to SVQ Jason Wang
2022-03-10  2:39 ` Jason Wang [this message]
2022-03-10  2:39 ` [PULL V2 14/15] vdpa: Never set log_base addr if SVQ is enabled Jason Wang
2022-03-10  2:39 ` [PULL V2 15/15] vdpa: Expose VHOST_F_LOG_ALL on SVQ Jason Wang
2022-03-10 17:06 ` [PULL V2 00/15] Net patches Peter Maydell
2022-03-11  4:43   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220310023907.2443-14-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).