From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: "Eugenio Pérez" <eperezma@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: [PULL V3 14/15] vdpa: Never set log_base addr if SVQ is enabled
Date: Tue, 15 Mar 2022 14:14:19 +0800 [thread overview]
Message-ID: <20220315061420.31910-15-jasowang@redhat.com> (raw)
In-Reply-To: <20220315061420.31910-1-jasowang@redhat.com>
From: Eugenio Pérez <eperezma@redhat.com>
Setting the log address would make the device start reporting invalid
dirty memory because the SVQ vrings are located in qemu's memory.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/virtio/vhost-vdpa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 93dbe10..89d59f8 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1090,7 +1090,8 @@ static int vhost_vdpa_dev_start(struct vhost_dev *dev, bool started)
static int vhost_vdpa_set_log_base(struct vhost_dev *dev, uint64_t base,
struct vhost_log *log)
{
- if (vhost_vdpa_one_time_request(dev)) {
+ struct vhost_vdpa *v = dev->opaque;
+ if (v->shadow_vqs_enabled || vhost_vdpa_one_time_request(dev)) {
return 0;
}
--
2.7.4
next prev parent reply other threads:[~2022-03-15 6:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 6:14 [PULL V3 00/15] Net patches Jason Wang
2022-03-15 6:14 ` [PULL V3 01/15] virtio-net: fix map leaking on error during receive Jason Wang
2022-03-15 6:14 ` [PULL V3 02/15] vhost: Add VhostShadowVirtqueue Jason Wang
2022-03-15 6:14 ` [PULL V3 03/15] vhost: Add Shadow VirtQueue kick forwarding capabilities Jason Wang
2022-03-15 6:14 ` [PULL V3 04/15] vhost: Add Shadow VirtQueue call " Jason Wang
2022-03-15 6:14 ` [PULL V3 05/15] vhost: Add vhost_svq_valid_features to shadow vq Jason Wang
2022-03-15 6:14 ` [PULL V3 06/15] virtio: Add vhost_svq_get_vring_addr Jason Wang
2022-03-15 6:14 ` [PULL V3 07/15] vdpa: adapt vhost_ops callbacks to svq Jason Wang
2022-03-15 6:14 ` [PULL V3 08/15] vhost: Shadow virtqueue buffers forwarding Jason Wang
2022-05-12 15:47 ` Peter Maydell
2022-05-12 18:01 ` Eugenio Perez Martin
2022-03-15 6:14 ` [PULL V3 09/15] util: Add iova_tree_alloc_map Jason Wang
2022-03-15 6:14 ` [PULL V3 10/15] util: add iova_tree_find_iova Jason Wang
2022-03-15 6:14 ` [PULL V3 11/15] vhost: Add VhostIOVATree Jason Wang
2022-03-15 6:14 ` [PULL V3 12/15] vdpa: Add custom IOTLB translations to SVQ Jason Wang
2022-03-15 6:14 ` [PULL V3 13/15] vdpa: Adapt vhost_vdpa_get_vring_base " Jason Wang
2022-03-15 6:14 ` Jason Wang [this message]
2022-03-15 6:14 ` [PULL V3 15/15] vdpa: Expose VHOST_F_LOG_ALL on SVQ Jason Wang
2022-03-15 11:26 ` [PULL V3 00/15] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315061420.31910-15-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).