qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PULL 6/8] accel/tcg: Fix cpu_ldq_be_mmu typo
Date: Tue, 15 Mar 2022 12:20:50 +0100	[thread overview]
Message-ID: <20220315112052.515467-7-thuth@redhat.com> (raw)
In-Reply-To: <20220315112052.515467-1-thuth@redhat.com>

From: Richard Henderson <richard.henderson@linaro.org>

In the conversion to cpu_ld_*_mmu, the retaddr parameter
was corrupted in the one case of cpu_ldq_be_mmu.

Fixes: f83bcecb1 ("accel/tcg: Add cpu_{ld,st}*_mmu interfaces")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/902
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220315002506.152030-1-richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 accel/tcg/cputlb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index 3b918fe018..2035b2ac0a 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -2174,7 +2174,7 @@ uint32_t cpu_ldl_be_mmu(CPUArchState *env, abi_ptr addr,
 uint64_t cpu_ldq_be_mmu(CPUArchState *env, abi_ptr addr,
                         MemOpIdx oi, uintptr_t ra)
 {
-    return cpu_load_helper(env, addr, oi, MO_BEUQ, helper_be_ldq_mmu);
+    return cpu_load_helper(env, addr, oi, ra, helper_be_ldq_mmu);
 }
 
 uint16_t cpu_ldw_le_mmu(CPUArchState *env, abi_ptr addr,
-- 
2.27.0



  parent reply	other threads:[~2022-03-15 11:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 11:20 [PULL 0/8] s390x and misc fixes Thomas Huth
2022-03-15 11:20 ` [PULL 1/8] tests/tcg: drop -cpu max from s390x sha512-mvx invocation Thomas Huth
2022-03-15 11:20 ` [PULL 2/8] s390x/tcg: Fix BRASL with a large negative offset Thomas Huth
2022-03-15 11:20 ` [PULL 3/8] s390x/tcg: Fix BRCL " Thomas Huth
2022-03-15 11:20 ` [PULL 4/8] tests/tcg/s390x: Test BRASL and BRCL with large negative offsets Thomas Huth
2022-05-02 13:43   ` Thomas Huth
2022-03-15 11:20 ` [PULL 5/8] tests/avocado: start PhoneServer upfront Thomas Huth
2022-03-15 11:20 ` Thomas Huth [this message]
2022-03-15 11:20 ` [PULL 7/8] softmmu: List CPU types again Thomas Huth
2022-03-15 11:20 ` [PULL 8/8] meson: Update to version 0.61.3 Thomas Huth
2022-03-15 18:58 ` [PULL 0/8] s390x and misc fixes Peter Maydell
2022-03-15 19:30   ` Peter Maydell
2022-03-16  7:35     ` Thomas Huth
2022-03-16 12:14     ` Paolo Bonzini
2022-03-16 12:18   ` Paolo Bonzini
2022-03-16 13:19     ` Peter Maydell
2022-03-16 14:26       ` Paolo Bonzini
2022-03-16 12:30   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220315112052.515467-7-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).