From: "Richard W.M. Jones" <rjones@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>,
nsoffer@redhat.com, Hanna Reitz <hreitz@redhat.com>,
v.sementsov-og@ya.ru
Subject: Re: [PATCH v3 3/3] nbd/server: Allow MULTI_CONN for shared writable exports
Date: Tue, 15 Mar 2022 13:14:41 +0000 [thread overview]
Message-ID: <20220315131441.GD1127@redhat.com> (raw)
In-Reply-To: <20220314203818.3681277-4-eblake@redhat.com>
The patches seem OK to me, but I don't really know enough about the
internals of qemu-nbd to give a line-by-line review. I did however
build and test qemu-nbd with the patches:
$ ./build/qemu-nbd /var/tmp/test.qcow2
$ nbdinfo nbd://localhost
...
can_multi_conn: false
$ ./build/qemu-nbd -e 2 /var/tmp/test.qcow2
$ nbdinfo nbd://localhost
...
can_multi_conn: false
^^^ Is this expected? It also happens with -e 0.
$ ./build/qemu-nbd -e 2 -m on /var/tmp/test.qcow2
$ nbdinfo nbd://localhost
...
can_multi_conn: true
$ ./build/qemu-nbd -e 2 -m off /var/tmp/test.qcow2
$ nbdinfo nbd://localhost
...
can_multi_conn: false
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
next prev parent reply other threads:[~2022-03-15 13:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 20:38 [PATCH v3 0/3] nbd: MULTI_CONN for shared writable exports Eric Blake
2022-03-14 20:38 ` [PATCH v3 1/3] docs: Consistent typography for options of qemu-nbd Eric Blake
2022-03-17 8:15 ` Daniel P. Berrangé
2022-03-14 20:38 ` [PATCH v3 2/3] qemu-nbd: Pass max connections to blockdev layer Eric Blake
2022-03-14 20:38 ` [PATCH v3 3/3] nbd/server: Allow MULTI_CONN for shared writable exports Eric Blake
2022-03-15 13:14 ` Richard W.M. Jones [this message]
2022-03-16 21:07 ` Eric Blake
2022-03-16 21:15 ` Eric Blake
2022-03-16 23:01 ` Richard W.M. Jones
2022-04-27 15:52 ` Kevin Wolf
2022-04-27 21:39 ` Eric Blake
2022-04-29 12:49 ` Kevin Wolf
2022-05-02 21:12 ` Eric Blake
2022-05-03 7:56 ` Kevin Wolf
2022-04-22 20:23 ` [PATCH v3 0/3] nbd: " Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315131441.GD1127@redhat.com \
--to=rjones@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=v.sementsov-og@ya.ru \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).