From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D7C1C433F5 for ; Wed, 16 Mar 2022 12:14:41 +0000 (UTC) Received: from localhost ([::1]:35024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUSY4-0007bt-9P for qemu-devel@archiver.kernel.org; Wed, 16 Mar 2022 08:14:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47600) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUSRg-0002vQ-N5 for qemu-devel@nongnu.org; Wed, 16 Mar 2022 08:08:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:57072) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUSRc-0006BR-Q4 for qemu-devel@nongnu.org; Wed, 16 Mar 2022 08:08:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647432479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hI9oM4T/Cw4CENK1lsjhdZP+mZpEDPOyBD7/RkxbPg=; b=iNpsv52f29zOUHFEcOxN0kacOu4+maPFlm2juNTLMUZDpr2PkUuGAVTlKL8JLTBYBe1R8T XZyzlOY5HVzoQN+DnUVP2yySxVcnIyFdj7dZGqOqw1iiJZmbearVnjwy2bXdbpe/v00jSW AKcWio1jF5SHMuM2s0JaFh0Cws93dR0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-43-Yzg7gNJ1OcuUqGNCspEPWA-1; Wed, 16 Mar 2022 08:07:56 -0400 X-MC-Unique: Yzg7gNJ1OcuUqGNCspEPWA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 46F6080088A; Wed, 16 Mar 2022 12:07:55 +0000 (UTC) Received: from localhost (unknown [10.39.192.129]) by smtp.corp.redhat.com (Postfix) with ESMTP id 72BC3C33265; Wed, 16 Mar 2022 12:07:54 +0000 (UTC) Date: Wed, 16 Mar 2022 12:07:53 +0000 From: "Richard W.M. Jones" To: marcandre.lureau@redhat.com Subject: Re: [PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF Message-ID: <20220316120753.GI1127@redhat.com> References: <20220316095248.2613601-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220316095248.2613601-1-marcandre.lureau@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=rjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=rjones@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Jason Wang , Christian Schoenebeck , qemu-devel@nongnu.org, Yanan Wang , Konstantin Kostiuk , Gerd Hoffmann , Ani Sinha , Eric Blake , Warner Losh , Stefano Stabellini , "open list:blkverify" , Huacai Chen , Markus Armbruster , Michael Roth , Anthony Perard , "open list:X86 Xen CPUs" , Laurent Vivier , Eduardo Habkost , Jiri Pirko , Kyle Evans , Greg Kurz , "Dr. David Alan Gilbert" , Paul Durrant , Stefan Hajnoczi , Paolo Bonzini , Kevin Wolf , Vladimir Sementsov-Ogievskiy , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Thomas Huth , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Hanna Reitz , Igor Mammedov , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Mar 16, 2022 at 01:52:48PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > One less qemu-specific macro. It also helps to make some headers/units > only depend on glib, and thus moved in standalone projects eventually. > > Signed-off-by: Marc-André Lureau I checked the replacements and couldn't spot any differences (I assume you used a 'perl -pi.bak -e s///' or similar rather than doing it by hand?). Also I checked the macro definitions in include/qemu/compiler.h vs /usr/include/glib-2.0/glib/gmacros.h and they're pretty much identical. I even learned about gnu_printf. So: Reviewed-by: Richard W.M. Jones Shouldn't there be a hunk which removes the definition of GCC_FMT_ATTR from include/qemu/compiler.h? Maybe that's in another place in the patch series. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top