qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: marex@denx.de, Peter Maydell <peter.maydell@linaro.org>,
	amir.gonnen@neuroblade.ai
Subject: [PATCH for-7.1 v6 09/51] linux-user/nios2: Only initialize SP and PC in target_cpu_copy_regs
Date: Wed, 16 Mar 2022 22:04:56 -0700	[thread overview]
Message-ID: <20220317050538.924111-10-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220317050538.924111-1-richard.henderson@linaro.org>

Drop the set of estatus in init_thread; it was clearly intended
to be setting the value of CR_STATUS for the application, but we
never actually performed that copy.  However, the proper value is
set in nios2_cpu_reset so we don't need to do anything here.

We only initialize SP and EA in init_thread, there's no value in
copying other uninitialized data into ENV.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/elfload.c        |  1 -
 linux-user/nios2/cpu_loop.c | 22 ----------------------
 2 files changed, 23 deletions(-)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 23ff9659a5..8c85c933b7 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -1096,7 +1096,6 @@ static void init_thread(struct target_pt_regs *regs, struct image_info *infop)
 {
     regs->ea = infop->entry;
     regs->sp = infop->start_stack;
-    regs->estatus = 0x3;
 }
 
 #define LO_COMMPAGE  TARGET_PAGE_SIZE
diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c
index 7b20c024db..fa234cb2af 100644
--- a/linux-user/nios2/cpu_loop.c
+++ b/linux-user/nios2/cpu_loop.c
@@ -132,28 +132,6 @@ void cpu_loop(CPUNios2State *env)
 
 void target_cpu_copy_regs(CPUArchState *env, struct target_pt_regs *regs)
 {
-    env->regs[0] = 0;
-    env->regs[1] = regs->r1;
-    env->regs[2] = regs->r2;
-    env->regs[3] = regs->r3;
-    env->regs[4] = regs->r4;
-    env->regs[5] = regs->r5;
-    env->regs[6] = regs->r6;
-    env->regs[7] = regs->r7;
-    env->regs[8] = regs->r8;
-    env->regs[9] = regs->r9;
-    env->regs[10] = regs->r10;
-    env->regs[11] = regs->r11;
-    env->regs[12] = regs->r12;
-    env->regs[13] = regs->r13;
-    env->regs[14] = regs->r14;
-    env->regs[15] = regs->r15;
-    /* TODO: unsigned long  orig_r2; */
-    env->regs[R_RA] = regs->ra;
-    env->regs[R_FP] = regs->fp;
     env->regs[R_SP] = regs->sp;
-    env->regs[R_GP] = regs->gp;
-    env->regs[CR_ESTATUS] = regs->estatus;
     env->pc = regs->ea;
-    /* TODO: unsigned long  orig_r7; */
 }
-- 
2.25.1



  parent reply	other threads:[~2022-03-17  5:13 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17  5:04 [PATCH for-7.1 v6 00/51] target/nios2: Shadow register set, EIC and VIC Richard Henderson
2022-03-17  5:04 ` [PATCH for-7.1 v6 01/51] tcg: Fix indirect lowering vs TCG_OPF_COND_BRANCH Richard Henderson
2022-03-17 13:38   ` Peter Maydell
2022-03-17  5:04 ` [PATCH for-7.1 v6 02/51] target/nios2: Check supervisor on eret Richard Henderson
2022-03-17  5:04 ` [PATCH for-7.1 v6 03/51] target/nios2: Stop generating code if gen_check_supervisor fails Richard Henderson
2022-03-17  5:04 ` [PATCH for-7.1 v6 04/51] target/nios2: Add NUM_GP_REGS and NUM_CP_REGS Richard Henderson
2022-03-17  5:04 ` [PATCH for-7.1 v6 05/51] target/nios2: Split PC out of env->regs[] Richard Henderson
2022-03-17  5:04 ` [PATCH for-7.1 v6 06/51] target/nios2: Split out helper for eret instruction Richard Henderson
2022-03-17  5:04 ` [PATCH for-7.1 v6 07/51] target/nios2: Fix BRET instruction Richard Henderson
2022-03-17  5:04 ` [PATCH for-7.1 v6 08/51] target/nios2: Do not create TCGv for control registers Richard Henderson
2022-03-17  5:04 ` Richard Henderson [this message]
2022-03-17  5:04 ` [PATCH for-7.1 v6 10/51] target/nios2: Remove cpu_interrupts_enabled Richard Henderson
2022-03-17  5:04 ` [PATCH for-7.1 v6 11/51] target/nios2: Split control registers away from general registers Richard Henderson
2022-03-17  5:04 ` [PATCH for-7.1 v6 12/51] target/nios2: Clean up nios2_cpu_dump_state Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 13/51] target/nios2: Use hw/registerfields.h for CR_STATUS fields Richard Henderson
2022-03-17 15:13   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 14/51] target/nios2: Use hw/registerfields.h for CR_EXCEPTION fields Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 15/51] target/nios2: Use hw/registerfields.h for CR_TLBADDR fields Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 16/51] target/nios2: Use hw/registerfields.h for CR_TLBACC fields Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 17/51] target/nios2: Rename CR_TLBMISC_WR to CR_TLBMISC_WE Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 18/51] target/nios2: Use hw/registerfields.h for CR_TLBMISC fields Richard Henderson
2022-03-17 15:15   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 19/51] target/nios2: Move R_FOO and CR_BAR into enumerations Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 20/51] target/nios2: Create EXCP_SEMIHOST for semi-hosting Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 21/51] target/nios2: Clean up nios2_cpu_do_interrupt Richard Henderson
2022-03-17 15:24   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 22/51] target/nios2: Hoist CPU_LOG_INT logging Richard Henderson
2022-03-17 15:25   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 23/51] target/nios2: Handle EXCP_UNALIGN and EXCP_UALIGND Richard Henderson
2022-03-17 15:27   ` Peter Maydell
2022-03-17 16:47     ` Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 24/51] target/nios2: Cleanup set of CR_EXCEPTION for do_interrupt Richard Henderson
2022-03-17 15:28   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 25/51] target/nios2: Clean up handling of tlbmisc in do_exception Richard Henderson
2022-03-17 15:41   ` Peter Maydell
2022-03-17 17:01     ` Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 26/51] target/nios2: Prevent writes to read-only or reserved control fields Richard Henderson
2022-03-17 15:49   ` Peter Maydell
2022-03-17 17:16     ` Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 27/51] target/nios2: Implement cpuid Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 28/51] target/nios2: Implement CR_STATUS.RSIE Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 29/51] target/nios2: Remove CPU_INTERRUPT_NMI Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 30/51] target/nios2: Support division error exception Richard Henderson
2022-03-17 15:52   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 31/51] target/nios2: Use tcg_constant_tl Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 32/51] target/nios2: Introduce dest_gpr Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 33/51] target/nios2: Drop CR_STATUS_EH from tb->flags Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 34/51] target/nios2: Enable unaligned traps for system mode Richard Henderson
2022-03-17 16:06   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 35/51] target/nios2: Create gen_jumpr Richard Henderson
2022-03-17 16:24   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 36/51] target/nios2: Hoist set of is_jmp into gen_goto_tb Richard Henderson
2022-03-17 16:25   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 37/51] target/nios2: Use gen_goto_tb for DISAS_TOO_MANY Richard Henderson
2022-03-17 16:28   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 38/51] target/nios2: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2022-03-17 16:29   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 39/51] target/nios2: Implement Misaligned destination exception Richard Henderson
2022-03-17 16:37   ` Peter Maydell
2022-03-17 17:41     ` Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 40/51] linux-user/nios2: Handle various SIGILL exceptions Richard Henderson
2022-03-17 16:38   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 41/51] target/nios2: Introduce shadow register sets Richard Henderson
2022-03-17 18:33   ` Peter Maydell
2022-03-17 19:31     ` Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 42/51] target/nios2: Implement rdprs, wrprs Richard Henderson
2022-03-17 18:47   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 43/51] target/nios2: Update helper_eret for shadow registers Richard Henderson
2022-03-17 18:53   ` Peter Maydell
2022-03-17  5:05 ` [PATCH for-7.1 v6 44/51] target/nios2: Implement EIC interrupt processing Richard Henderson
2022-03-17 19:11   ` Peter Maydell
2022-03-17 19:54     ` Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 45/51] hw/intc: Vectored Interrupt Controller (VIC) Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 46/51] hw/nios2: Introduce Nios2MachineState Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 47/51] hw/nios2: Move memory regions into Nios2Machine Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 48/51] hw/nios2: Machine with a Vectored Interrupt Controller Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 49/51] tests/tcg: Expose AR to test build environment if needed Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 50/51] test/tcg/nios2: Add semihosting multiarch tests Richard Henderson
2022-03-17  5:05 ` [PATCH for-7.1 v6 51/51] tests/tcg/nios2: Add test-shadow-1 Richard Henderson
2022-03-22 12:17 ` [PATCH for-7.1 v6 00/51] target/nios2: Shadow register set, EIC and VIC Amir Gonnen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220317050538.924111-10-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=amir.gonnen@neuroblade.ai \
    --cc=marex@denx.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).