From: Hanna Reitz <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org
Subject: [PATCH 0/2] iotests/207: Filter host fingerprint
Date: Fri, 18 Mar 2022 13:53:02 +0100 [thread overview]
Message-ID: <20220318125304.66131-1-hreitz@redhat.com> (raw)
Hi,
Commit e3296cc796aeaf (“block: print the server key type and fingerprint
on failure”) improved the verbosity of our ssh block driver's error
messages for fingerprint mismatches. However, iotest 207, which tests
such errors, has not been adjusted accordingly.
Since the fingerprint will differ between hosts, we need to filter it
(and can’t just statically adjust the reference output). The problem is
that the error condition is printed by iotest.py’s VM.run_job(), so we
need to pass the filter to that function. Right now, VM.run_job()
doesn’t support any filters, though, so patch 1 adds a filter parameter
and makes VM.run_job() use it.
Patch 2 then has the fix for iotest 207.
Hanna Reitz (2):
iotests.py: Filters for VM.run_job()
iotests/207: Filter host fingerprint
tests/qemu-iotests/207 | 7 ++++++-
tests/qemu-iotests/207.out | 6 +++---
tests/qemu-iotests/iotests.py | 26 ++++++++++++++++----------
3 files changed, 25 insertions(+), 14 deletions(-)
--
2.35.1
next reply other threads:[~2022-03-18 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 12:53 Hanna Reitz [this message]
2022-03-18 12:53 ` [PATCH 1/2] iotests.py: Filters for VM.run_job() Hanna Reitz
2022-03-18 22:36 ` John Snow
2022-03-18 12:53 ` [PATCH 2/2] iotests/207: Filter host fingerprint Hanna Reitz
2022-03-18 22:40 ` John Snow
2022-03-22 9:50 ` [PATCH 0/2] " Hanna Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318125304.66131-1-hreitz@redhat.com \
--to=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).