From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Beraldo Leal <bleal@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Hanna Reitz <hreitz@redhat.com>, Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH v5 18/18] iotests: make qemu_img_log and img_info_log raise on error
Date: Mon, 21 Mar 2022 16:33:03 -0500 [thread overview]
Message-ID: <20220321213303.xjfelyctamduycef@redhat.com> (raw)
In-Reply-To: <20220321201618.903471-19-jsnow@redhat.com>
On Mon, Mar 21, 2022 at 04:16:18PM -0400, John Snow wrote:
> Add a `check: bool = True` parameter to both functions and make their
> qemu_img() invocations raise on error by default.
>
> users of img_info_log:
> 206, 207, 210, 211, 212, 213, 237, 242, 266, 274, 302
>
> users of qemu_img_log:
> 044, 209, 274, 302, 304
>
> iotests 242 and 266 need to use check=False for their negative tests.
> iotests 206, 210, 211, 212, 213, 237, 274 and 302 continue working
> normally.
>
> As of this commit, all calls to QEMU_IMG made from iotests enforce a
> return code of zero by default unless explicitly disabled or suppressed
> by passing check=False or with an exception handler.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/qemu-iotests/242 | 2 +-
> tests/qemu-iotests/266 | 2 +-
> tests/qemu-iotests/iotests.py | 8 +++++---
> 3 files changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2022-03-21 21:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 20:16 [PATCH v5 00/18] iotests: add enhanced debugging info to qemu-img failures John Snow
2022-03-21 20:16 ` [PATCH v5 01/18] python/utils: add add_visual_margin() text decoration utility John Snow
2022-03-21 20:16 ` [PATCH v5 02/18] python/utils: add VerboseProcessError John Snow
2022-03-21 20:16 ` [PATCH v5 03/18] iotests: Remove explicit checks for qemu_img() == 0 John Snow
2022-03-21 20:16 ` [PATCH v5 04/18] iotests: make qemu_img raise on non-zero rc by default John Snow
2022-03-21 20:16 ` [PATCH v5 05/18] iotests: fortify compare_images() against crashes John Snow
2022-03-21 20:16 ` [PATCH v5 06/18] iotests: add qemu_img_json() John Snow
2022-03-21 20:16 ` [PATCH v5 07/18] iotests: use qemu_img_json() when applicable John Snow
2022-03-21 20:16 ` [PATCH v5 08/18] iotests: add qemu_img_info() John Snow
2022-03-21 20:16 ` [PATCH v5 09/18] iotests/remove-bitmap-from-backing: use qemu_img_info() John Snow
2022-03-21 20:16 ` [PATCH v5 10/18] iotests: add qemu_img_map() function John Snow
2022-03-21 20:16 ` [PATCH v5 11/18] iotests: change supports_quorum to use qemu_img John Snow
2022-03-21 20:16 ` [PATCH v5 12/18] iotests: replace unchecked calls to qemu_img_pipe() John Snow
2022-03-21 20:16 ` [PATCH v5 13/18] iotests/149: Remove qemu_img_pipe() call John Snow
2022-03-21 20:16 ` [PATCH v5 14/18] iotests: remove remaining calls to qemu_img_pipe() John Snow
2022-03-21 20:16 ` [PATCH v5 15/18] iotests: use qemu_img() in has_working_luks() John Snow
2022-03-21 20:16 ` [PATCH v5 16/18] iotests: replace qemu_img_log('create', ...) calls John Snow
2022-03-21 20:16 ` [PATCH v5 17/18] iotests: remove qemu_img_pipe_and_status() John Snow
2022-03-21 21:31 ` Eric Blake
2022-03-21 20:16 ` [PATCH v5 18/18] iotests: make qemu_img_log and img_info_log raise on error John Snow
2022-03-21 21:33 ` Eric Blake [this message]
2022-03-22 9:42 ` [PATCH v5 00/18] iotests: add enhanced debugging info to qemu-img failures Hanna Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321213303.xjfelyctamduycef@redhat.com \
--to=eblake@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).