From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEBA8C433EF for ; Mon, 21 Mar 2022 21:34:34 +0000 (UTC) Received: from localhost ([::1]:47200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWPfc-0003Eg-Uu for qemu-devel@archiver.kernel.org; Mon, 21 Mar 2022 17:34:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWPeH-0001Bb-95 for qemu-devel@nongnu.org; Mon, 21 Mar 2022 17:33:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWPeF-0004hL-Mo for qemu-devel@nongnu.org; Mon, 21 Mar 2022 17:33:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647898386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nbXSs1q0bwKSukey17yPFZdW8b0LCB9k5/tyrQ2dcVw=; b=YyYSTrOxPNGAYjaj7UvBfeKme0iA3ElUF7v/0/Qiap/qzVUD8uCbS0Zxy6eTSYY/lZw1Zi VVm4m3bGbDTK/zg8L77Zqp6w7sSlTloQGJ5ShdyrV8vT6kT9BbzbPrf6jTFKa858YWwERw Wy+9/qYmYLBJ3M4gXIiAK5fuEb03vhs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-322-kaPRsirPMTKlwaq9CD3iwg-1; Mon, 21 Mar 2022 17:33:05 -0400 X-MC-Unique: kaPRsirPMTKlwaq9CD3iwg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 970581044563; Mon, 21 Mar 2022 21:33:05 +0000 (UTC) Received: from redhat.com (unknown [10.2.16.194]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 00DB540C1241; Mon, 21 Mar 2022 21:33:04 +0000 (UTC) Date: Mon, 21 Mar 2022 16:33:03 -0500 From: Eric Blake To: John Snow Subject: Re: [PATCH v5 18/18] iotests: make qemu_img_log and img_info_log raise on error Message-ID: <20220321213303.xjfelyctamduycef@redhat.com> References: <20220321201618.903471-1-jsnow@redhat.com> <20220321201618.903471-19-jsnow@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220321201618.903471-19-jsnow@redhat.com> User-Agent: NeoMutt/20211029-454-6adf99 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Beraldo Leal , qemu-block@nongnu.org, qemu-devel@nongnu.org, Hanna Reitz , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Mar 21, 2022 at 04:16:18PM -0400, John Snow wrote: > Add a `check: bool = True` parameter to both functions and make their > qemu_img() invocations raise on error by default. > > users of img_info_log: > 206, 207, 210, 211, 212, 213, 237, 242, 266, 274, 302 > > users of qemu_img_log: > 044, 209, 274, 302, 304 > > iotests 242 and 266 need to use check=False for their negative tests. > iotests 206, 210, 211, 212, 213, 237, 274 and 302 continue working > normally. > > As of this commit, all calls to QEMU_IMG made from iotests enforce a > return code of zero by default unless explicitly disabled or suppressed > by passing check=False or with an exception handler. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/242 | 2 +- > tests/qemu-iotests/266 | 2 +- > tests/qemu-iotests/iotests.py | 8 +++++--- > 3 files changed, 7 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org