From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82157C433F5 for ; Tue, 22 Mar 2022 03:10:39 +0000 (UTC) Received: from localhost ([::1]:37902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWUus-0005qu-Hj for qemu-devel@archiver.kernel.org; Mon, 21 Mar 2022 23:10:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWUtr-0004z3-1L; Mon, 21 Mar 2022 23:09:35 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:31736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWUtp-0005uJ-0U; Mon, 21 Mar 2022 23:09:34 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 22M2wV8h079675; Tue, 22 Mar 2022 10:58:31 +0800 (GMT-8) (envelope-from jamin_lin@aspeedtech.com) Received: from aspeedtech.com (192.168.70.87) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Mar 2022 11:08:59 +0800 Date: Tue, 22 Mar 2022 11:08:53 +0800 From: Jamin Lin To: =?utf-8?Q?C=C3=A9dric?= Le Goater Subject: Re: [PATCH v1 0/1] hw/gpio Add ASPEED GPIO model for AST1030 Message-ID: <20220322030852.GB4273@aspeedtech.com> References: <20220321091453.17113-1-jamin_lin@aspeedtech.com> <549ac24b-4636-374c-7086-33588f906be5@kaod.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <549ac24b-4636-374c-7086-33588f906be5@kaod.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.70.87] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 22M2wV8h079675 Received-SPF: pass client-ip=211.20.114.71; envelope-from=jamin_lin@aspeedtech.com; helo=twspam01.aspeedtech.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, SCC_BODY_URI_ONLY=0.833, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrew Jeffery , Troy Lee , Steven Lee , "open list:All patches CC here" , "open list:ASPEED BMCs" , Joel Stanley Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The 03/21/2022 10:55, Cédric Le Goater wrote: > Hello Jamin, > > On 3/21/22 10:14, Jamin Lin wrote: > > 1. Add GPIO read/write trace event. > > 2. Support GPIO index mode for write operation. > > It did not support GPIO index mode for read operation. > > 3. AST1030 integrates one set of Parallel GPIO Controller > > Is the AST1030 a new SoC you are developing ? We don't have a machine > for it in QEMU. We should introduce the models first if the changes > are specific to this SoC. > > Thanks, > > C. > > I submitted a new patch series for AST1030 model support. So far, only GPIO driver for AST1030 used "index mode" for write operation. Thanks-Jamin > > with maximum 151 control pins, which are 21 groups > > (A~U, exclude pin: M6 M7 Q5 Q6 Q7 R0 R1 R4 R5 R6 R7 S0 S3 S4 > > S5 S6 S7 ) and the group T and U are input only. > > > > Test Steps: > > 1. Download image from > > https://github.com/AspeedTech-BMC/zephyr/releases/download/v00.01.04/ast1030-evb-demo.zip > > 2. Extract the zip file to obtain zephyr.elf > > 3. Run ./qemu-system-arm -M ast1030-evb -kernel $PATH/zephyr.elf -nographic > > 4. Test GPIO D6 Pin > > uart:~$ gpio conf GPIO0_A_D 30 out > > uart:~$ gpio get GPIO0_A_D 30 > > [Result] > > Reading GPIO0_A_D pin 30 > > Value 0 > > uart:~$ gpio set GPIO0_A_D 30 1 > > uart:~$ gpio get GPIO0_A_D 30 > > [Result] > > Reading GPIO0_A_D pin 30 > > Value 1 > > uart:~$ gpio set GPIO0_A_D 30 0 > > uart:~$ gpio get GPIO0_A_D 30 > > [Result] > > Reading GPIO0_A_D pin 30 > > Value 0 > > > > Jamin Lin (1): > > hw/gpio: Add ASPEED GPIO model for AST1030 > > > > hw/gpio/aspeed_gpio.c | 250 ++++++++++++++++++++++++++++++++-- > > hw/gpio/trace-events | 5 + > > include/hw/gpio/aspeed_gpio.h | 16 ++- > > 3 files changed, 255 insertions(+), 16 deletions(-) > > >