From: Bin Meng <bmeng.cn@gmail.com>
To: Michael Rolnik <mrolnik@gmail.com>, qemu-devel@nongnu.org
Subject: [PATCH] target/avr: Drop avr_cpu_memory_rw_debug()
Date: Tue, 22 Mar 2022 17:50:04 +0800 [thread overview]
Message-ID: <20220322095004.70682-1-bmeng.cn@gmail.com> (raw)
CPUClass::memory_rw_debug() holds a callback for GDB memory access.
If not provided, cpu_memory_rw_debug() is used by the GDB stub.
Drop avr_cpu_memory_rw_debug() which does nothing special.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
target/avr/cpu.h | 2 --
target/avr/cpu.c | 1 -
target/avr/helper.c | 6 ------
3 files changed, 9 deletions(-)
diff --git a/target/avr/cpu.h b/target/avr/cpu.h
index 55497f851d..44c2b08bd7 100644
--- a/target/avr/cpu.h
+++ b/target/avr/cpu.h
@@ -184,8 +184,6 @@ void avr_cpu_tcg_init(void);
void avr_cpu_list(void);
int cpu_avr_exec(CPUState *cpu);
-int avr_cpu_memory_rw_debug(CPUState *cs, vaddr address, uint8_t *buf,
- int len, bool is_write);
enum {
TB_FLAGS_FULL_ACCESS = 1,
diff --git a/target/avr/cpu.c b/target/avr/cpu.c
index 5d70e34dd5..05b992ff73 100644
--- a/target/avr/cpu.c
+++ b/target/avr/cpu.c
@@ -214,7 +214,6 @@ static void avr_cpu_class_init(ObjectClass *oc, void *data)
cc->has_work = avr_cpu_has_work;
cc->dump_state = avr_cpu_dump_state;
cc->set_pc = avr_cpu_set_pc;
- cc->memory_rw_debug = avr_cpu_memory_rw_debug;
dc->vmsd = &vms_avr_cpu;
cc->sysemu_ops = &avr_sysemu_ops;
cc->disas_set_info = avr_cpu_disas_set_info;
diff --git a/target/avr/helper.c b/target/avr/helper.c
index c27f702901..db76452f9a 100644
--- a/target/avr/helper.c
+++ b/target/avr/helper.c
@@ -93,12 +93,6 @@ void avr_cpu_do_interrupt(CPUState *cs)
cs->exception_index = -1;
}
-int avr_cpu_memory_rw_debug(CPUState *cs, vaddr addr, uint8_t *buf,
- int len, bool is_write)
-{
- return cpu_memory_rw_debug(cs, addr, buf, len, is_write);
-}
-
hwaddr avr_cpu_get_phys_page_debug(CPUState *cs, vaddr addr)
{
return addr; /* I assume 1:1 address correspondence */
--
2.25.1
next reply other threads:[~2022-03-22 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 9:50 Bin Meng [this message]
2022-03-22 10:16 ` [PATCH] target/avr: Drop avr_cpu_memory_rw_debug() Philippe Mathieu-Daudé
2022-06-20 19:59 ` Richard Henderson
2022-07-12 21:44 ` Philippe Mathieu-Daudé via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322095004.70682-1-bmeng.cn@gmail.com \
--to=bmeng.cn@gmail.com \
--cc=mrolnik@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).