* [PATCH v2 0/2] CI fixes
@ 2022-03-22 19:14 Yonggang Luo
2022-03-22 19:14 ` [PATCH v2 1/2] ci: Add github workflow for getting cirrus working properly Yonggang Luo
2022-03-22 19:14 ` [PATCH v2 2/2] cirrus: upgrade mingw base packages Yonggang Luo
0 siblings, 2 replies; 6+ messages in thread
From: Yonggang Luo @ 2022-03-22 19:14 UTC (permalink / raw)
To: QEMU Devel
Cc: Peter Maydell, Thomas Huth, Beraldo Leal, QEMU Trivial,
Philippe Mathieu-Daudиж, Wainer dos Santos Moschetta,
Yonggang Luo, Alex Bennижe
* Fixes the cirrus CI
* Add an empty github actions to get cirrus CI works properly
Yonggang Luo (2):
ci: Add github workflow for getting cirrus working properly
cirrus: upgrade mingw base packages.
.cirrus.yml | 2 +-
.github/workflows/main.yml | 29 +++++++++++++++++++++++++++++
.gitlab-ci.d/windows.yml | 2 +-
MAINTAINERS | 4 +++-
4 files changed, 34 insertions(+), 3 deletions(-)
create mode 100644 .github/workflows/main.yml
--
2.31.1.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] ci: Add github workflow for getting cirrus working properly
2022-03-22 19:14 [PATCH v2 0/2] CI fixes Yonggang Luo
@ 2022-03-22 19:14 ` Yonggang Luo
2022-03-23 7:44 ` Thomas Huth
2022-03-23 9:20 ` Daniel P. Berrangé
2022-03-22 19:14 ` [PATCH v2 2/2] cirrus: upgrade mingw base packages Yonggang Luo
1 sibling, 2 replies; 6+ messages in thread
From: Yonggang Luo @ 2022-03-22 19:14 UTC (permalink / raw)
To: QEMU Devel
Cc: Peter Maydell, Thomas Huth, Beraldo Leal, QEMU Trivial,
Philippe Mathieu-Daudиж, Wainer dos Santos Moschetta,
Yonggang Luo, Alex Bennижe
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
.github/workflows/main.yml | 29 +++++++++++++++++++++++++++++
MAINTAINERS | 4 +++-
2 files changed, 32 insertions(+), 1 deletion(-)
create mode 100644 .github/workflows/main.yml
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
new file mode 100644
index 0000000000..85a392b962
--- /dev/null
+++ b/.github/workflows/main.yml
@@ -0,0 +1,29 @@
+# This is a basic workflow to help you get started with Actions
+
+name: CI
+
+# Controls when the action will run. Triggers the workflow on push or pull request
+# events but only for the master branch
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+ branches: [ master ]
+
+# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+jobs:
+ check-patch:
+ name: Check Patch
+ runs-on: ubuntu-latest
+ steps:
+ # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
+ - uses: actions/checkout@v2
+ with:
+ fetch-depth: 0
+ - name: Install dependent packages
+ run: sudo apt install perl
+ - name: Checkpatch
+ run: |
+ git fetch https://git.qemu.org/git/qemu.git master
+ git tag base_tag_to_rebase FETCH_HEAD --force
+ ./scripts/checkpatch.pl --mailback base_tag_to_rebase..
diff --git a/MAINTAINERS b/MAINTAINERS
index cc364afef7..6d1dcc36b0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3612,10 +3612,12 @@ Build and test automation, general continuous integration
M: Alex Bennée <alex.bennee@linaro.org>
M: Philippe Mathieu-Daudé <f4bug@amsat.org>
M: Thomas Huth <thuth@redhat.com>
+M: Yonggang Luo <luoyonggang@gmail>
R: Wainer dos Santos Moschetta <wainersm@redhat.com>
R: Beraldo Leal <bleal@redhat.com>
S: Maintained
-F: .github/lockdown.yml
+F: .github/workflows/lockdown.yml
+F: .github/workflows/main.yml
F: .gitlab-ci.yml
F: .gitlab-ci.d/
F: .travis.yml
--
2.31.1.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] ci: Add github workflow for getting cirrus working properly
2022-03-22 19:14 ` [PATCH v2 1/2] ci: Add github workflow for getting cirrus working properly Yonggang Luo
@ 2022-03-23 7:44 ` Thomas Huth
2022-03-23 7:54 ` 罗勇刚(Yonggang Luo)
2022-03-23 9:20 ` Daniel P. Berrangé
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2022-03-23 7:44 UTC (permalink / raw)
To: Yonggang Luo, QEMU Devel
Cc: Peter Maydell, Beraldo Leal, QEMU Trivial,
Philippe Mathieu-Daudиж, Wainer dos Santos Moschetta,
Alex Bennижe
On 22/03/2022 20.14, Yonggang Luo wrote:
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Missing patch description ... why is this needed? I can't see anything
related to Cirrus-CI in here?
> ---
> .github/workflows/main.yml | 29 +++++++++++++++++++++++++++++
> MAINTAINERS | 4 +++-
> 2 files changed, 32 insertions(+), 1 deletion(-)
> create mode 100644 .github/workflows/main.yml
>
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> new file mode 100644
> index 0000000000..85a392b962
> --- /dev/null
> +++ b/.github/workflows/main.yml
> @@ -0,0 +1,29 @@
> +# This is a basic workflow to help you get started with Actions
> +
> +name: CI
> +
> +# Controls when the action will run. Triggers the workflow on push or pull request
> +# events but only for the master branch
> +on:
> + push:
> + branches: [ master ]
> + pull_request:
> + branches: [ master ]
> +
> +# A workflow run is made up of one or more jobs that can run sequentially or in parallel
> +jobs:
> + check-patch:
> + name: Check Patch
> + runs-on: ubuntu-latest
> + steps:
> + # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
> + - uses: actions/checkout@v2
> + with:
> + fetch-depth: 0
> + - name: Install dependent packages
> + run: sudo apt install perl
> + - name: Checkpatch
> + run: |
> + git fetch https://git.qemu.org/git/qemu.git master
> + git tag base_tag_to_rebase FETCH_HEAD --force
> + ./scripts/checkpatch.pl --mailback base_tag_to_rebase..
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cc364afef7..6d1dcc36b0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3612,10 +3612,12 @@ Build and test automation, general continuous integration
> M: Alex Bennée <alex.bennee@linaro.org>
> M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> M: Thomas Huth <thuth@redhat.com>
> +M: Yonggang Luo <luoyonggang@gmail>
> R: Wainer dos Santos Moschetta <wainersm@redhat.com>
> R: Beraldo Leal <bleal@redhat.com>
> S: Maintained
> -F: .github/lockdown.yml
> +F: .github/workflows/lockdown.yml
> +F: .github/workflows/main.yml
> F: .gitlab-ci.yml
> F: .gitlab-ci.d/
> F: .travis.yml
You also don't mention that change anywhere. And IIRC you've also only been
involved in the Windows-related CI tasks so far? So it might make more sense
to update the "Windows Hosted Continuous Integration" section instead?
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] ci: Add github workflow for getting cirrus working properly
2022-03-23 7:44 ` Thomas Huth
@ 2022-03-23 7:54 ` 罗勇刚(Yonggang Luo)
0 siblings, 0 replies; 6+ messages in thread
From: 罗勇刚(Yonggang Luo) @ 2022-03-23 7:54 UTC (permalink / raw)
To: Thomas Huth
Cc: Peter Maydell, Beraldo Leal, QEMU Trivial, QEMU Devel,
Wainer dos Santos Moschetta, Philippe Mathieu-Daudиж,
Alex Bennижe
[-- Attachment #1: Type: text/plain, Size: 3025 bytes --]
On Wed, Mar 23, 2022 at 3:44 PM Thomas Huth <thuth@redhat.com> wrote:
>
> On 22/03/2022 20.14, Yonggang Luo wrote:
> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
>
> Missing patch description ... why is this needed? I can't see anything
> related to Cirrus-CI in here?
Here is the place report failure
https://github.com/qemu/qemu/runs/5652470682
Here is the place showing the valid ci result:
https://github.com/lygstate/qemu
>
> > ---
> > .github/workflows/main.yml | 29 +++++++++++++++++++++++++++++
> > MAINTAINERS | 4 +++-
> > 2 files changed, 32 insertions(+), 1 deletion(-)
> > create mode 100644 .github/workflows/main.yml
> >
> > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> > new file mode 100644
> > index 0000000000..85a392b962
> > --- /dev/null
> > +++ b/.github/workflows/main.yml
> > @@ -0,0 +1,29 @@
> > +# This is a basic workflow to help you get started with Actions
> > +
> > +name: CI
> > +
> > +# Controls when the action will run. Triggers the workflow on push or
pull request
> > +# events but only for the master branch
> > +on:
> > + push:
> > + branches: [ master ]
> > + pull_request:
> > + branches: [ master ]
> > +
> > +# A workflow run is made up of one or more jobs that can run
sequentially or in parallel
> > +jobs:
> > + check-patch:
> > + name: Check Patch
> > + runs-on: ubuntu-latest
> > + steps:
> > + # Checks-out your repository under $GITHUB_WORKSPACE, so your
job can access it
> > + - uses: actions/checkout@v2
> > + with:
> > + fetch-depth: 0
> > + - name: Install dependent packages
> > + run: sudo apt install perl
> > + - name: Checkpatch
> > + run: |
> > + git fetch https://git.qemu.org/git/qemu.git master
> > + git tag base_tag_to_rebase FETCH_HEAD --force
> > + ./scripts/checkpatch.pl --mailback base_tag_to_rebase..
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index cc364afef7..6d1dcc36b0 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3612,10 +3612,12 @@ Build and test automation, general continuous
integration
> > M: Alex Bennée <alex.bennee@linaro.org>
> > M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > M: Thomas Huth <thuth@redhat.com>
> > +M: Yonggang Luo <luoyonggang@gmail>
> > R: Wainer dos Santos Moschetta <wainersm@redhat.com>
> > R: Beraldo Leal <bleal@redhat.com>
> > S: Maintained
> > -F: .github/lockdown.yml
> > +F: .github/workflows/lockdown.yml
> > +F: .github/workflows/main.yml
> > F: .gitlab-ci.yml
> > F: .gitlab-ci.d/
> > F: .travis.yml
>
> You also don't mention that change anywhere. And IIRC you've also only
been
> involved in the Windows-related CI tasks so far? So it might make more
sense
> to update the "Windows Hosted Continuous Integration" section instead?
>
> Thomas
>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 4335 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] ci: Add github workflow for getting cirrus working properly
2022-03-22 19:14 ` [PATCH v2 1/2] ci: Add github workflow for getting cirrus working properly Yonggang Luo
2022-03-23 7:44 ` Thomas Huth
@ 2022-03-23 9:20 ` Daniel P. Berrangé
1 sibling, 0 replies; 6+ messages in thread
From: Daniel P. Berrangé @ 2022-03-23 9:20 UTC (permalink / raw)
To: Yonggang Luo
Cc: Peter Maydell, Thomas Huth, Beraldo Leal, QEMU Trivial,
Philippe Mathieu-Daudиж, Wainer dos Santos Moschetta,
QEMU Devel, Alex Bennижe
On Wed, Mar 23, 2022 at 03:14:08AM +0800, Yonggang Luo wrote:
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> .github/workflows/main.yml | 29 +++++++++++++++++++++++++++++
> MAINTAINERS | 4 +++-
> 2 files changed, 32 insertions(+), 1 deletion(-)
> create mode 100644 .github/workflows/main.yml
>
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> new file mode 100644
> index 0000000000..85a392b962
> --- /dev/null
> +++ b/.github/workflows/main.yml
> @@ -0,0 +1,29 @@
> +# This is a basic workflow to help you get started with Actions
> +
> +name: CI
> +
> +# Controls when the action will run. Triggers the workflow on push or pull request
> +# events but only for the master branch
> +on:
> + push:
> + branches: [ master ]
> + pull_request:
> + branches: [ master ]
> +
> +# A workflow run is made up of one or more jobs that can run sequentially or in parallel
> +jobs:
> + check-patch:
> + name: Check Patch
> + runs-on: ubuntu-latest
> + steps:
> + # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
> + - uses: actions/checkout@v2
> + with:
> + fetch-depth: 0
> + - name: Install dependent packages
> + run: sudo apt install perl
> + - name: Checkpatch
> + run: |
> + git fetch https://git.qemu.org/git/qemu.git master
> + git tag base_tag_to_rebase FETCH_HEAD --force
> + ./scripts/checkpatch.pl --mailback base_tag_to_rebase..
I really don't think we want to start duplicating our CI efforts into
GitHub. We are using GitLab as our primary hosting platform for QEMU,
and have standardized on using GitLab for CI, only using Cirrus CI
and Travis for specific non-x86 or non-Linux tasks.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] cirrus: upgrade mingw base packages.
2022-03-22 19:14 [PATCH v2 0/2] CI fixes Yonggang Luo
2022-03-22 19:14 ` [PATCH v2 1/2] ci: Add github workflow for getting cirrus working properly Yonggang Luo
@ 2022-03-22 19:14 ` Yonggang Luo
1 sibling, 0 replies; 6+ messages in thread
From: Yonggang Luo @ 2022-03-22 19:14 UTC (permalink / raw)
To: QEMU Devel
Cc: Peter Maydell, Thomas Huth, Beraldo Leal, QEMU Trivial,
Philippe Mathieu-Daudиж, Wainer dos Santos Moschetta,
Yonggang Luo, Alex Bennижe
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
.cirrus.yml | 2 +-
.gitlab-ci.d/windows.yml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.cirrus.yml b/.cirrus.yml
index 7552d70974..59b004721d 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -12,7 +12,7 @@ windows_msys2_task:
CIRRUS_SHELL: powershell
MSYS: winsymlinks:nativestrict
MSYSTEM: MINGW64
- MSYS2_URL: https://github.com/msys2/msys2-installer/releases/download/2021-04-19/msys2-base-x86_64-20210419.sfx.exe
+ MSYS2_URL: https://github.com/msys2/msys2-installer/releases/download/2022-03-19/msys2-base-x86_64-20220319.sfx.exe
MSYS2_FINGERPRINT: 0
MSYS2_PACKAGES: "
diffutils git grep make pkg-config sed
diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
index 1df1630349..e8b65faccc 100644
--- a/.gitlab-ci.d/windows.yml
+++ b/.gitlab-ci.d/windows.yml
@@ -16,7 +16,7 @@
}
- If ( !(Test-Path -Path msys64\var\cache\msys2.exe ) ) {
Invoke-WebRequest
- "https://github.com/msys2/msys2-installer/releases/download/2021-07-25/msys2-base-x86_64-20210725.sfx.exe"
+ "https://github.com/msys2/msys2-installer/releases/download/2022-03-19/msys2-base-x86_64-20220319.sfx.exe"
-outfile "msys64\var\cache\msys2.exe"
}
- msys64\var\cache\msys2.exe -y
--
2.31.1.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-23 9:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-22 19:14 [PATCH v2 0/2] CI fixes Yonggang Luo
2022-03-22 19:14 ` [PATCH v2 1/2] ci: Add github workflow for getting cirrus working properly Yonggang Luo
2022-03-23 7:44 ` Thomas Huth
2022-03-23 7:54 ` 罗勇刚(Yonggang Luo)
2022-03-23 9:20 ` Daniel P. Berrangé
2022-03-22 19:14 ` [PATCH v2 2/2] cirrus: upgrade mingw base packages Yonggang Luo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).