From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF6C0C433F5 for ; Thu, 24 Mar 2022 08:42:50 +0000 (UTC) Received: from localhost ([::1]:36586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXJ3R-0005yj-RN for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 04:42:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXIwT-0007kI-I6 for qemu-devel@nongnu.org; Thu, 24 Mar 2022 04:35:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:37078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXIwR-0007Ip-Gq for qemu-devel@nongnu.org; Thu, 24 Mar 2022 04:35:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648110934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5AYiOg0g6VI/yAB3L4J0toc2fwKBeYoB1YDFnmEmPSY=; b=SdyYfUK/JMNNZfrRR1XUuog0XBz7VsO5SHivJiPGAjX+WNHWapHtMu2gQguyRswILYjrxP emeI/d/qborlMw1iQ62eheiLwkIDpSaZJrAYRv38moJPe+SNzRt0RTvd2DgjPFKs4Hm9lG FxkYPYU1dB8h48rNo5ISKHRmzDorRe0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-199-44gU_I5ONXODwUpkr3D2fA-1; Thu, 24 Mar 2022 04:35:31 -0400 X-MC-Unique: 44gU_I5ONXODwUpkr3D2fA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AAFFF1C09405; Thu, 24 Mar 2022 08:35:30 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.196.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 70736401E29; Thu, 24 Mar 2022 08:35:30 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D0DB018000AA; Thu, 24 Mar 2022 09:35:28 +0100 (CET) Date: Thu, 24 Mar 2022 09:35:28 +0100 From: Gerd Hoffmann To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [RFC PATCH v3 17/36] pflash_cfi01/tdx: Introduce ram_mode of pflash for TDVF Message-ID: <20220324083528.deoh77e77swf67gb@sirius.home.kraxel.org> References: <20220317135913.2166202-1-xiaoyao.li@intel.com> <20220317135913.2166202-18-xiaoyao.li@intel.com> <7a8233e4-0cae-b05a-7931-695a7ee87fc9@intel.com> <20220322092141.qsgv3pqlvlemgrgw@sirius.home.kraxel.org> <20220322103518.ljbi4pvghbgjxm7k@sirius.home.kraxel.org> <20220322122024.blyut6mnszhyw6hz@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220322122024.blyut6mnszhyw6hz@sirius.home.kraxel.org> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: isaku.yamahata@intel.com, Marcelo Tosatti , kvm@vger.kernel.org, "Michael S. Tsirkin" , Connor Kuehl , Xiaoyao Li , Cornelia Huck , Richard Henderson , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Eric Blake , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , seanjc@google.com, erdemaktas@google.com, Paolo Bonzini , Laszlo Ersek Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Mar 22, 2022 at 01:20:24PM +0100, Gerd Hoffmann wrote: > Hi, > > > At the time I did try a gross hack that (IIRC) disabled the > > rom_reset logic, and munged x86_bios_rom_init so that it would > > force load it straight at the RAM location. > > Sounds reasonable. The whole rom logic exists to handle resets, > but with confidential guests we don't need that, we can't change > guest state to perform a reset anyway ... Completed, cleaned up a bit, but untested: https://git.kraxel.org/cgit/qemu/log/?h=sirius/cc Any chance you can give this a try? thanks, Gerd