From: Victor Toso <victortoso@redhat.com>
To: qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>, Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: [PATCH v2 07/14] qapi: fix example of UNPLUG_PRIMARY event
Date: Fri, 25 Mar 2022 23:07:00 +0100 [thread overview]
Message-ID: <20220325220707.52118-8-victortoso@redhat.com> (raw)
In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com>
* Timestamp is not optional, let's add for completeness.
* Add '<-' to signalize it is receiving the data
* Break lines like most of examples do
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/migration.json | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 18e2610e88..092a63354b 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1736,7 +1736,9 @@
# Since: 4.2
#
# Example:
-# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} }
+# <- { "event": "UNPLUG_PRIMARY",
+# "data": { "device-id": "hostdev0" },
+# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
#
##
{ 'event': 'UNPLUG_PRIMARY',
--
2.35.1
next prev parent reply other threads:[~2022-03-25 22:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 22:06 [PATCH v2 00/14] Fix some qapi examples and a TODO section Victor Toso
2022-03-25 22:06 ` [PATCH v2 01/14] qapi: BlockExportRemoveMode: move comments to TODO Victor Toso
2022-03-25 22:06 ` [PATCH v2 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event Victor Toso
2022-03-28 8:54 ` Markus Armbruster
2022-03-28 9:06 ` Victor Toso
2022-03-28 11:19 ` Markus Armbruster
2022-03-28 13:22 ` Victor Toso
2022-03-28 9:05 ` [PATCH v2.1] " Victor Toso
2022-03-28 11:16 ` Markus Armbruster
2022-03-25 22:06 ` [PATCH v2 03/14] qapi: fix example of BLOCK_IO_ERROR event Victor Toso
2022-03-25 22:06 ` [PATCH v2 04/14] qapi: fix example of BLOCK_JOB_PENDING event Victor Toso
2022-03-25 22:06 ` [PATCH v2 05/14] qapi: fix example of DUMP_COMPLETED event Victor Toso
2022-03-25 22:06 ` [PATCH v2 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event Victor Toso
2022-03-25 22:07 ` Victor Toso [this message]
2022-03-25 22:07 ` [PATCH v2 08/14] qapi: fix example of FAILOVER_NEGOTIATED event Victor Toso
2022-03-25 22:07 ` [PATCH v2 09/14] qapi: fix examples: SHUTDOWN and RESET events Victor Toso
2022-03-25 22:07 ` [PATCH v2 10/14] qapi: run-state examples: add missing timestamp Victor Toso
2022-03-25 22:07 ` [PATCH v2 11/14] qapi: fix example of MEMORY_FAILURE Victor Toso
2022-03-25 22:07 ` [PATCH v2 12/14] qapi: ui examples: add missing websocket member Victor Toso
2022-03-25 22:07 ` [PATCH v2 13/14] qapi: fix example of ACPI_DEVICE_OST event Victor Toso
2022-03-25 22:07 ` [PATCH v2 14/14] qapi: fix example of dump-guest-memory Victor Toso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325220707.52118-8-victortoso@redhat.com \
--to=victortoso@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).