From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: [PATCH 10/15] tests/tcg: remove CONFIG_USER_ONLY from config-target.mak
Date: Mon, 28 Mar 2022 10:02:35 -0400 [thread overview]
Message-ID: <20220328140240.40798-11-pbonzini@redhat.com> (raw)
In-Reply-To: <20220328140240.40798-1-pbonzini@redhat.com>
Just check the target name instead.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/tcg/Makefile.target | 8 ++++----
tests/tcg/configure.sh | 12 +++---------
2 files changed, 7 insertions(+), 13 deletions(-)
diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
index ae8004c76e..083b09c742 100644
--- a/tests/tcg/Makefile.target
+++ b/tests/tcg/Makefile.target
@@ -32,7 +32,7 @@
all:
-include ../../../config-host.mak
-include ../config-$(TARGET).mak
-ifeq ($(CONFIG_USER_ONLY),y)
+ifeq ($(filter %-softmmu, $(TARGET)),)
-include $(SRC_PATH)/configs/targets/$(TARGET)/default.mak
endif
@@ -42,7 +42,7 @@ COMMA := ,
quiet-command = $(if $(V),$1,$(if $(2),@printf " %-7s %s\n" $2 $3 && $1, @$1))
# $1 = test name, $2 = cmd, $3 = desc
-ifdef CONFIG_USER_ONLY
+ifeq ($(filter %-softmmu, $(TARGET)),)
run-test = $(call quiet-command, timeout --foreground $(TIMEOUT) $2 > $1.out, \
"TEST",$3)
else
@@ -89,7 +89,7 @@ QEMU_OPTS=
# 90s with --enable-tcg-interpreter
TIMEOUT=90
-ifdef CONFIG_USER_ONLY
+ifeq ($(filter %-softmmu, $(TARGET)),)
# The order we include is important. We include multiarch first and
# then the target. If there are common tests shared between
# sub-targets (e.g. ARM & AArch64) then it is up to
@@ -151,7 +151,7 @@ extract-plugin = $(wordlist 2, 2, $(subst -with-, ,$1))
RUN_TESTS+=$(EXTRA_RUNS)
-ifdef CONFIG_USER_ONLY
+ifeq ($(filter %-softmmu, $(TARGET)),)
run-%: %
$(call run-test, $<, $(QEMU) $(QEMU_OPTS) $<, "$< on $(TARGET_NAME)")
diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
index b09956c14d..a17db8ce64 100755
--- a/tests/tcg/configure.sh
+++ b/tests/tcg/configure.sh
@@ -225,18 +225,12 @@ for target in $target_list; do
echo "TARGET_NAME=$arch" >> $config_target_mak
echo "target=$target" >> $config_target_mak
case $target in
- *-linux-user)
- echo "CONFIG_USER_ONLY=y" >> $config_target_mak
- echo "QEMU=$PWD/qemu-$arch" >> $config_target_mak
- ;;
- *-bsd-user)
- echo "CONFIG_USER_ONLY=y" >> $config_target_mak
- echo "QEMU=$PWD/qemu-$arch" >> $config_target_mak
- ;;
*-softmmu)
- echo "CONFIG_SOFTMMU=y" >> $config_target_mak
echo "QEMU=$PWD/qemu-system-$arch" >> $config_target_mak
;;
+ *)
+ echo "QEMU=$PWD/qemu-$arch" >> $config_target_mak
+ ;;
esac
eval "target_compiler_cflags=\${cross_cc_cflags_$arch}"
--
2.31.1
next prev parent reply other threads:[~2022-03-28 14:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 14:02 [PATCH 00/15] tests/docker and tests/tcg cleanup and diet Paolo Bonzini
2022-03-28 14:02 ` [PATCH 01/15] tests/docker: remove dead code Paolo Bonzini
2022-03-28 16:18 ` Alex Bennée
2022-03-28 17:31 ` Paolo Bonzini
2022-03-28 14:02 ` [PATCH 02/15] tests/docker: remove test targets Paolo Bonzini
2022-03-28 16:44 ` Alex Bennée
2022-03-28 17:31 ` Paolo Bonzini
2022-03-28 14:02 ` [PATCH 03/15] tests/docker: remove dead variable Paolo Bonzini
2022-03-28 16:45 ` Alex Bennée
2022-03-28 14:02 ` [PATCH 04/15] tests/docker: remove unnecessary default definitions Paolo Bonzini
2022-03-30 16:32 ` Alex Bennée
2022-03-28 14:02 ` [PATCH 05/15] tests/docker: inline variable definitions or move close to use Paolo Bonzini
2022-03-28 14:02 ` [PATCH 06/15] tests/docker: remove unnecessary filtering of $(DOCKER_IMAGES) Paolo Bonzini
2022-03-28 14:02 ` [PATCH 07/15] tests/docker: simplify docker-TEST@IMAGE targets Paolo Bonzini
2022-03-28 22:34 ` Philippe Mathieu-Daudé
2022-03-28 14:02 ` [PATCH 08/15] tests/tcg: add compiler test variables when using containers Paolo Bonzini
2022-03-28 16:48 ` Alex Bennée
2022-03-28 14:02 ` [PATCH 09/15] tests/tcg: remove CONFIG_LINUX_USER from config-target.mak Paolo Bonzini
2022-03-28 22:35 ` Philippe Mathieu-Daudé
2022-03-28 14:02 ` Paolo Bonzini [this message]
2022-03-28 22:37 ` [PATCH 10/15] tests/tcg: remove CONFIG_USER_ONLY " Philippe Mathieu-Daudé
2022-03-28 14:02 ` [PATCH 11/15] tests/tcg: prepare Makefile.prereqs at configure time Paolo Bonzini
2022-03-28 14:02 ` [PATCH 12/15] tests/tcg: list test targets in Makefile.prereqs Paolo Bonzini
2022-03-28 14:02 ` [PATCH 13/15] tests/tcg: invoke Makefile.target directly from QEMU's makefile Paolo Bonzini
2022-03-28 14:02 ` [PATCH 14/15] tests/docker: remove SKIP_DOCKER_BUILD Paolo Bonzini
2022-03-28 14:02 ` [PATCH 15/15] tests/tcg: fix non-static build Paolo Bonzini
2022-03-28 15:53 ` [PATCH 00/15] tests/docker and tests/tcg cleanup and diet Richard Henderson
2022-03-28 17:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328140240.40798-11-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).