From: Damien Hedde <damien.hedde@greensocs.com>
To: qemu-devel@nongnu.org
Cc: "Damien Hedde" <damien.hedde@greensocs.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH 1/5] qdev: add uc_requires_machine_allowance flag
Date: Wed, 30 Mar 2022 18:12:11 +0200 [thread overview]
Message-ID: <20220330161215.235231-2-damien.hedde@greensocs.com> (raw)
In-Reply-To: <20220330161215.235231-1-damien.hedde@greensocs.com>
This flag will be used in device_add to check if
the device needs special allowance from the machine
model.
It will replace the current check based only on the
device being a TYPE_SYB_BUS_DEVICE.
Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
---
include/hw/qdev-core.h | 6 ++++++
hw/core/qdev.c | 1 +
hw/core/sysbus.c | 1 +
3 files changed, 8 insertions(+)
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index 92c3d65208..f5a05ced39 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -123,6 +123,12 @@ struct DeviceClass {
*/
bool user_creatable;
bool hotpluggable;
+ /*
+ * Some devices (eg: sysbus devices) are only user-creatable if
+ * the machine allowed it. user_creatable need still to be set to
+ * true, this is an additional constraint.
+ */
+ bool uc_requires_machine_allowance;
/* callbacks */
/*
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 84f3019440..0825277521 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -833,6 +833,7 @@ static void device_class_init(ObjectClass *class, void *data)
*/
dc->hotpluggable = true;
dc->user_creatable = true;
+ dc->uc_requires_machine_allowance = false;
vc->get_id = device_vmstate_if_get_id;
rc->get_state = device_get_reset_state;
rc->child_foreach = device_reset_child_foreach;
diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
index 05c1da3d31..462eb1116c 100644
--- a/hw/core/sysbus.c
+++ b/hw/core/sysbus.c
@@ -325,6 +325,7 @@ static void sysbus_device_class_init(ObjectClass *klass, void *data)
* subclass needs to override it and set user_creatable=true.
*/
k->user_creatable = false;
+ k->uc_requires_machine_allowance = true;
}
static const TypeInfo sysbus_device_type_info = {
--
2.35.1
next prev parent reply other threads:[~2022-03-30 16:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 16:12 [PATCH 0/5] Generalize the sysbus device machine allowance Damien Hedde
2022-03-30 16:12 ` Damien Hedde [this message]
2022-03-31 10:21 ` [PATCH 1/5] qdev: add uc_requires_machine_allowance flag Philippe Mathieu-Daudé
2022-03-31 10:48 ` Damien Hedde
2022-03-30 16:12 ` [PATCH 2/5] machine: update machine allowed list related functions/fields Damien Hedde
2022-03-31 10:20 ` Philippe Mathieu-Daudé
2022-03-30 16:12 ` [PATCH 3/5] qdev-monitor: use the newly uc_requires_machine_allowance Damien Hedde
2022-03-30 16:12 ` [PATCH 4/5] rename machine_class_allow_dynamic_sysbus_dev Damien Hedde
2022-03-31 10:19 ` Philippe Mathieu-Daudé
2022-03-30 16:12 ` [PATCH 5/5] machine: remove temporary inline functions Damien Hedde
2022-03-31 10:19 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330161215.235231-2-damien.hedde@greensocs.com \
--to=damien.hedde@greensocs.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).