qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>,
	peter.maydell@linaro.org, Victor Toso <victortoso@redhat.com>
Subject: [PULL 09/15] qapi: fix example of FAILOVER_NEGOTIATED event
Date: Thu, 31 Mar 2022 12:53:38 +0200	[thread overview]
Message-ID: <20220331105344.3471295-10-armbru@redhat.com> (raw)
In-Reply-To: <20220331105344.3471295-1-armbru@redhat.com>

From: Victor Toso <victortoso@redhat.com>

Example output lacks mandatory member @timestamp.  Provide it.

Event's documentation is not properly formatted. Fix it by:
- Adding @ to "device-id"
- Adding extra line for "Since" section

Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-Id: <20220328140604.41484-9-victortoso@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/net.json | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/qapi/net.json b/qapi/net.json
index 7fab2e7cd8..0d4578bd07 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -685,13 +685,15 @@
 # Failover primary devices which were hidden (not hotplugged when requested)
 # before will now be hotplugged by the virtio-net standby device.
 #
-# device-id: QEMU device id of the unplugged device
+# @device-id: QEMU device id of the unplugged device
+#
 # Since: 4.2
 #
 # Example:
 #
 # <- { "event": "FAILOVER_NEGOTIATED",
-#      "data": "net1" }
+#      "data": { "device-id": "net1" },
+#      "timestamp": { "seconds": 1368697518, "microseconds": 326866 } }
 #
 ##
 { 'event': 'FAILOVER_NEGOTIATED',
-- 
2.35.1



  parent reply	other threads:[~2022-03-31 11:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31 10:53 [PULL 00/15] QAPI patches patches for 2022-03-31 Markus Armbruster
2022-03-31 10:53 ` [PULL 01/15] schemas: add missing vim modeline Markus Armbruster
2022-03-31 10:53 ` [PULL 02/15] qapi: BlockExportRemoveMode: move comments to TODO Markus Armbruster
2022-03-31 10:53 ` [PULL 03/15] qapi: fix example of BLOCK_IMAGE_CORRUPTED event Markus Armbruster
2022-03-31 10:53 ` [PULL 04/15] qapi: fix example of BLOCK_IO_ERROR event Markus Armbruster
2022-03-31 10:53 ` [PULL 05/15] qapi: fix example of BLOCK_JOB_PENDING event Markus Armbruster
2022-03-31 10:53 ` [PULL 06/15] qapi: fix example of DUMP_COMPLETED event Markus Armbruster
2022-03-31 10:53 ` [PULL 07/15] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event Markus Armbruster
2022-03-31 10:53 ` [PULL 08/15] qapi: fix example of UNPLUG_PRIMARY event Markus Armbruster
2022-03-31 10:53 ` Markus Armbruster [this message]
2022-03-31 10:53 ` [PULL 10/15] qapi: fix examples: SHUTDOWN and RESET events Markus Armbruster
2022-03-31 10:53 ` [PULL 11/15] qapi: run-state examples: add missing @timestamp Markus Armbruster
2022-03-31 10:53 ` [PULL 12/15] qapi: fix example of MEMORY_FAILURE Markus Armbruster
2022-03-31 10:53 ` [PULL 13/15] qapi: ui examples: add missing @websocket member Markus Armbruster
2022-03-31 10:53 ` [PULL 14/15] qapi: fix example of ACPI_DEVICE_OST event Markus Armbruster
2022-03-31 10:53 ` [PULL 15/15] qapi: fix example of dump-guest-memory Markus Armbruster
2022-03-31 15:14 ` [PULL 00/15] QAPI patches patches for 2022-03-31 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220331105344.3471295-10-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=victortoso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).