From: Halil Pasic <pasic@linux.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: farman@linux.ibm.com, cohuck@redhat.com, thuth@redhat.com,
qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
qemu-s390x@nongnu.org, borntraeger@linux.ibm.com
Subject: Re: [PATCH 3/4] virtio-ccw: move device type declarations to .c files
Date: Thu, 31 Mar 2022 14:14:47 +0200 [thread overview]
Message-ID: <20220331141447.40af9138.pasic@linux.ibm.com> (raw)
In-Reply-To: <20220328143019.682245-4-pbonzini@redhat.com>
On Mon, 28 Mar 2022 16:30:18 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Just curious: is device type declarations for
leaf device types should be private a best practice in QEMU?
> ---
> hw/s390x/s390-virtio-ccw.c | 1 +
> hw/s390x/vhost-scsi-ccw.c | 9 +++
> hw/s390x/vhost-vsock-ccw.c | 9 +++
> hw/s390x/virtio-ccw-9p.c | 9 +++
> hw/s390x/virtio-ccw-balloon.c | 9 +++
> hw/s390x/virtio-ccw-blk.c | 9 +++
> hw/s390x/virtio-ccw-crypto.c | 9 +++
> hw/s390x/virtio-ccw-gpu.c | 9 +++
> hw/s390x/virtio-ccw-input.c | 20 +++++
> hw/s390x/virtio-ccw-net.c | 9 +++
> hw/s390x/virtio-ccw-rng.c | 9 +++
> hw/s390x/virtio-ccw-scsi.c | 9 +++
> hw/s390x/virtio-ccw-serial.c | 9 +++
> hw/s390x/virtio-ccw.c | 2 +
> hw/s390x/virtio-ccw.h | 133 ----------------------------------
> 15 files changed, 122 insertions(+), 133 deletions(-)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index 90480e7cf9..2d32647d08 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -25,6 +25,7 @@
> #include "qemu/error-report.h"
> #include "qemu/option.h"
> #include "qemu/qemu-print.h"
> +#include "qemu/units.h"
Unrelated?
[..]
> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
> index c845a92c3a..15b458527e 100644
> --- a/hw/s390x/virtio-ccw.c
> +++ b/hw/s390x/virtio-ccw.c
> @@ -12,6 +12,7 @@
>
> #include "qemu/osdep.h"
> #include "qapi/error.h"
> +#include "exec/address-spaces.h"
Unrelated?
> #include "sysemu/kvm.h"
> #include "net/net.h"
> #include "hw/virtio/virtio.h"
> @@ -19,6 +20,7 @@
> #include "hw/virtio/virtio-net.h"
> #include "qemu/bitops.h"
> #include "qemu/error-report.h"
> +#include "qemu/log.h"
Unrelated?
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
next prev parent reply other threads:[~2022-03-31 12:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 14:30 [PATCH 0/4] virtio-ccw: remove device declarations from virtio-ccw.h Paolo Bonzini
2022-03-28 14:30 ` [PATCH 1/4] s390x: follow qdev tree to detect SCSI device on a CCW bus Paolo Bonzini
2022-03-29 12:45 ` Thomas Huth
2022-03-31 0:21 ` Halil Pasic
2022-03-28 14:30 ` [PATCH 2/4] virtio-ccw: move vhost_ccw_scsi to a separate file Paolo Bonzini
2022-03-29 13:34 ` Thomas Huth
2022-03-29 20:09 ` Eric Farman
2022-03-31 11:46 ` Halil Pasic
2022-04-04 14:43 ` Cornelia Huck
2022-03-28 14:30 ` [PATCH 3/4] virtio-ccw: move device type declarations to .c files Paolo Bonzini
2022-03-30 7:11 ` Thomas Huth
2022-03-31 12:14 ` Halil Pasic [this message]
2022-03-28 14:30 ` [PATCH 4/4] virtio-ccw: do not include headers for all virtio devices Paolo Bonzini
2022-03-30 7:12 ` Thomas Huth
2022-03-31 13:50 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331141447.40af9138.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).