From: Francisco Iglesias <frasse.iglesias@gmail.com>
To: Tong Ho <tong.ho@xilinx.com>
Cc: edgar.iglesias@gmail.com, qemu-arm@nongnu.org,
qemu-devel@nongnu.org, alistair@alistair23.me,
peter.maydell@linaro.org
Subject: Re: [PATCH 1/1] xlnx-bbram: hw/nvram: Fix uninitialized Error *
Date: Mon, 4 Apr 2022 13:02:49 +0200 [thread overview]
Message-ID: <20220404110248.GA2422@fralle-msi> (raw)
In-Reply-To: <20220401190631.1697408-2-tong.ho@xilinx.com>
On [2022 Apr 01] Fri 12:06:31, Tong Ho wrote:
> This adds required initialization of Error * variable.
>
> Signed-off-by: Tong Ho <tong.ho@xilinx.com>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
> ---
> hw/nvram/xlnx-bbram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/nvram/xlnx-bbram.c b/hw/nvram/xlnx-bbram.c
> index b70828e5bf..6ed32adad9 100644
> --- a/hw/nvram/xlnx-bbram.c
> +++ b/hw/nvram/xlnx-bbram.c
> @@ -89,7 +89,7 @@ static bool bbram_pgm_enabled(XlnxBBRam *s)
>
> static void bbram_bdrv_error(XlnxBBRam *s, int rc, gchar *detail)
> {
> - Error *errp;
> + Error *errp = NULL;
>
> error_setg_errno(&errp, -rc, "%s: BBRAM backstore %s failed.",
> blk_name(s->blk), detail);
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2022-04-04 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 19:06 [PATCH 0/1] xlnx-bbram: hw/nvram: Fix Coverity CID 1487233 Tong Ho
2022-04-01 19:06 ` [PATCH 1/1] xlnx-bbram: hw/nvram: Fix uninitialized Error * Tong Ho
2022-04-04 11:02 ` Francisco Iglesias [this message]
2022-04-05 8:28 ` [PATCH 0/1] xlnx-bbram: hw/nvram: Fix Coverity CID 1487233 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220404110248.GA2422@fralle-msi \
--to=frasse.iglesias@gmail.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=tong.ho@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).