* [PATCH 0/1] xlnx-bbram: hw/nvram: Fix Coverity CID 1487233
@ 2022-04-01 19:06 Tong Ho
2022-04-01 19:06 ` [PATCH 1/1] xlnx-bbram: hw/nvram: Fix uninitialized Error * Tong Ho
2022-04-05 8:28 ` [PATCH 0/1] xlnx-bbram: hw/nvram: Fix Coverity CID 1487233 Peter Maydell
0 siblings, 2 replies; 4+ messages in thread
From: Tong Ho @ 2022-04-01 19:06 UTC (permalink / raw)
To: qemu-arm; +Cc: edgar.iglesias, alistair, tong.ho, qemu-devel, peter.maydell
This patch addresses Coverity CID 1487233 by adding the required
initialiation of a local variable of type Error *.
Tong Ho (1):
xlnx-bbram: hw/nvram: Fix uninitialized Error *
hw/nvram/xlnx-bbram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] xlnx-bbram: hw/nvram: Fix uninitialized Error *
2022-04-01 19:06 [PATCH 0/1] xlnx-bbram: hw/nvram: Fix Coverity CID 1487233 Tong Ho
@ 2022-04-01 19:06 ` Tong Ho
2022-04-04 11:02 ` Francisco Iglesias
2022-04-05 8:28 ` [PATCH 0/1] xlnx-bbram: hw/nvram: Fix Coverity CID 1487233 Peter Maydell
1 sibling, 1 reply; 4+ messages in thread
From: Tong Ho @ 2022-04-01 19:06 UTC (permalink / raw)
To: qemu-arm; +Cc: edgar.iglesias, alistair, tong.ho, qemu-devel, peter.maydell
This adds required initialization of Error * variable.
Signed-off-by: Tong Ho <tong.ho@xilinx.com>
---
hw/nvram/xlnx-bbram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/nvram/xlnx-bbram.c b/hw/nvram/xlnx-bbram.c
index b70828e5bf..6ed32adad9 100644
--- a/hw/nvram/xlnx-bbram.c
+++ b/hw/nvram/xlnx-bbram.c
@@ -89,7 +89,7 @@ static bool bbram_pgm_enabled(XlnxBBRam *s)
static void bbram_bdrv_error(XlnxBBRam *s, int rc, gchar *detail)
{
- Error *errp;
+ Error *errp = NULL;
error_setg_errno(&errp, -rc, "%s: BBRAM backstore %s failed.",
blk_name(s->blk), detail);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] xlnx-bbram: hw/nvram: Fix uninitialized Error *
2022-04-01 19:06 ` [PATCH 1/1] xlnx-bbram: hw/nvram: Fix uninitialized Error * Tong Ho
@ 2022-04-04 11:02 ` Francisco Iglesias
0 siblings, 0 replies; 4+ messages in thread
From: Francisco Iglesias @ 2022-04-04 11:02 UTC (permalink / raw)
To: Tong Ho; +Cc: edgar.iglesias, qemu-arm, qemu-devel, alistair, peter.maydell
On [2022 Apr 01] Fri 12:06:31, Tong Ho wrote:
> This adds required initialization of Error * variable.
>
> Signed-off-by: Tong Ho <tong.ho@xilinx.com>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
> ---
> hw/nvram/xlnx-bbram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/nvram/xlnx-bbram.c b/hw/nvram/xlnx-bbram.c
> index b70828e5bf..6ed32adad9 100644
> --- a/hw/nvram/xlnx-bbram.c
> +++ b/hw/nvram/xlnx-bbram.c
> @@ -89,7 +89,7 @@ static bool bbram_pgm_enabled(XlnxBBRam *s)
>
> static void bbram_bdrv_error(XlnxBBRam *s, int rc, gchar *detail)
> {
> - Error *errp;
> + Error *errp = NULL;
>
> error_setg_errno(&errp, -rc, "%s: BBRAM backstore %s failed.",
> blk_name(s->blk), detail);
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/1] xlnx-bbram: hw/nvram: Fix Coverity CID 1487233
2022-04-01 19:06 [PATCH 0/1] xlnx-bbram: hw/nvram: Fix Coverity CID 1487233 Tong Ho
2022-04-01 19:06 ` [PATCH 1/1] xlnx-bbram: hw/nvram: Fix uninitialized Error * Tong Ho
@ 2022-04-05 8:28 ` Peter Maydell
1 sibling, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2022-04-05 8:28 UTC (permalink / raw)
To: Tong Ho; +Cc: edgar.iglesias, qemu-arm, qemu-devel, alistair
On Fri, 1 Apr 2022 at 20:06, Tong Ho <tong.ho@xilinx.com> wrote:
>
> This patch addresses Coverity CID 1487233 by adding the required
> initialiation of a local variable of type Error *.
>
> Tong Ho (1):
> xlnx-bbram: hw/nvram: Fix uninitialized Error *
>
> hw/nvram/xlnx-bbram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to target-arm.next for 7.0, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-05 8:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-01 19:06 [PATCH 0/1] xlnx-bbram: hw/nvram: Fix Coverity CID 1487233 Tong Ho
2022-04-01 19:06 ` [PATCH 1/1] xlnx-bbram: hw/nvram: Fix uninitialized Error * Tong Ho
2022-04-04 11:02 ` Francisco Iglesias
2022-04-05 8:28 ` [PATCH 0/1] xlnx-bbram: hw/nvram: Fix Coverity CID 1487233 Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).