From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Victor Toso <victortoso@redhat.com>
Subject: [PULL 02/10] qapi: fix examples: replay-break and replay-seek
Date: Tue, 5 Apr 2022 12:34:47 +0200 [thread overview]
Message-ID: <20220405103455.4145273-3-armbru@redhat.com> (raw)
In-Reply-To: <20220405103455.4145273-1-armbru@redhat.com>
From: Victor Toso <victortoso@redhat.com>
Both examples outputs are using @data member for the arguments. This
is wrong. The expected member for the QMP is @arguments. Fix it.
Signed-off-by: Victor Toso <victortoso@redhat.com>
Message-Id: <20220331190633.121077-3-victortoso@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qapi/replay.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qapi/replay.json b/qapi/replay.json
index b4d1ba253b..351898f60d 100644
--- a/qapi/replay.json
+++ b/qapi/replay.json
@@ -81,7 +81,7 @@
#
# Example:
#
-# -> { "execute": "replay-break", "data": { "icount": 220414 } }
+# -> { "execute": "replay-break", "arguments": { "icount": 220414 } }
#
##
{ 'command': 'replay-break', 'data': { 'icount': 'int' } }
@@ -117,6 +117,6 @@
#
# Example:
#
-# -> { "execute": "replay-seek", "data": { "icount": 220414 } }
+# -> { "execute": "replay-seek", "arguments": { "icount": 220414 } }
##
{ 'command': 'replay-seek', 'data': { 'icount': 'int' } }
--
2.35.1
next prev parent reply other threads:[~2022-04-05 10:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 10:34 [PULL 00/10] QAPI patches patches for 2022-04-05 Markus Armbruster
2022-04-05 10:34 ` [PULL 01/10] qapi: fix example of netdev_add command Markus Armbruster
2022-04-05 10:34 ` Markus Armbruster [this message]
2022-04-05 10:34 ` [PULL 03/10] qapi: fix example of query-named-block-nodes command Markus Armbruster
2022-04-05 10:34 ` [PULL 04/10] qapi: fix example of query-spice command Markus Armbruster
2022-04-05 10:34 ` [PULL 05/10] qapi: fix example of query-vnc command Markus Armbruster
2022-04-05 10:34 ` [PULL 06/10] qapi: fix example of query-colo-status command Markus Armbruster
2022-04-05 10:34 ` [PULL 07/10] qapi: fix example of trace-event-get-state command Markus Armbruster
2022-04-05 10:34 ` [PULL 08/10] qapi: fix example of query-cpus-fast command Markus Armbruster
2022-04-05 10:34 ` [PULL 09/10] qapi: fix example of query-memdev command Markus Armbruster
2022-04-05 10:34 ` [PULL 10/10] qapi: Fix calc-dirty-rate example Markus Armbruster
2022-04-05 15:14 ` [PULL 00/10] QAPI patches patches for 2022-04-05 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405103455.4145273-3-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=victortoso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).