From: Hanna Reitz <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
qemu-devel@nongnu.org
Subject: [PATCH v3 0/3] qcow2: Improve refcount structure rebuilding
Date: Tue, 5 Apr 2022 15:46:49 +0200 [thread overview]
Message-ID: <20220405134652.19278-1-hreitz@redhat.com> (raw)
Hi,
v2 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2022-03/msg01260.html
v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2021-03/msg00651.html
This series fixes the qcow2 refcount structure rebuilding mechanism for
when the qcow2 image file doesn’t allow writes beyond the end of file
(e.g. because it’s on an LVM block device).
v3:
- Added patch 3 (didn’t squash this into patch 1, because (a) Eric gave
his R-b on 1 as-is, and (b) I ended up retouching
rebuild_refcount_structure() as a whole, not just the new helper, so a
dedicated patch made more sense)
- In patch 1: Changed `assert(reftable_size_changed == true)` to just
`assert(reftable_size_changed)`
- In patch 2: In comments, replaced “were” by “was”
git-backport-diff against v2:
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/3:[0002] [FC] 'qcow2: Improve refcount structure rebuilding'
002/3:[0006] [FC] 'iotests/108: Test new refcount rebuild algorithm'
003/3:[down] 'qcow2: Add errp to rebuild_refcount_structure()'
Hanna Reitz (3):
qcow2: Improve refcount structure rebuilding
iotests/108: Test new refcount rebuild algorithm
qcow2: Add errp to rebuild_refcount_structure()
block/qcow2-refcount.c | 353 ++++++++++++++++++++++++++-----------
tests/qemu-iotests/108 | 259 ++++++++++++++++++++++++++-
tests/qemu-iotests/108.out | 81 +++++++++
3 files changed, 587 insertions(+), 106 deletions(-)
--
2.35.1
next reply other threads:[~2022-04-05 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 13:46 Hanna Reitz [this message]
2022-04-05 13:46 ` [PATCH v3 1/3] qcow2: Improve refcount structure rebuilding Hanna Reitz
2022-04-05 13:46 ` [PATCH v3 2/3] iotests/108: Test new refcount rebuild algorithm Hanna Reitz
2022-04-05 13:46 ` [PATCH v3 3/3] qcow2: Add errp to rebuild_refcount_structure() Hanna Reitz
2022-04-05 16:08 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405134652.19278-1-hreitz@redhat.com \
--to=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).