qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: wliang@stu.xidian.edu.cn
Cc: eric.auger@redhat.com, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: Fix a potential Use-after-free in virtio_iommu_handle_command() (v6.2.0).
Date: Wed, 6 Apr 2022 07:21:07 -0400	[thread overview]
Message-ID: <20220406040445-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <26faef1d.aa6.17f2f07f0b4.Coremail.wliang@stu.xidian.edu.cn>

On Fri, Feb 25, 2022 at 11:58:43AM +0800, wliang@stu.xidian.edu.cn wrote:
> Hi all,
> 
> Here is a new patch with Signed-off-by tags.
> The old one is wrong for it did't have Signed-off-by tags.
> I am looking forward to your confirmation.
> 
> Thanks,
> Wentao

> From 8ece42bda1099a9a0df584cac2478ec5a6e83924 Mon Sep 17 00:00:00 2001
> From: Wentao_Liang <Wentao_Liang_g@163.com>
> Date: Fri, 25 Feb 2022 11:49:54 +0800
> Subject: [PATCH] Fix a potential Use-after-free in
>  virtio_iommu_handle_command() (v6.2.0).
> 
> Signed-off-by: Wentao_Liang <Wentao_Liang_g@163.com>
> ---
>  hw/virtio/virtio-iommu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
> index aa9c16a17b..a394901347 100644
> --- a/hw/virtio/virtio-iommu.c
> +++ b/hw/virtio/virtio-iommu.c
> @@ -657,6 +657,7 @@ out:
>          virtio_notify(vdev, vq);
>          g_free(elem);
>          g_free(buf);
> +        buf = NULL;
>      }
>  }

I merged this fix, adding the commit log description.
I also note it should be sent inline not as an attachment.

Thanks a lot for the contribution!

> -- 
> 2.25.1
> 



      reply	other threads:[~2022-04-06 11:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 14:36 Fix a potential Use-after-free in virtio_iommu_handle_command() (v6.2.0) wliang
2022-02-23 16:02 ` Thomas Huth
2022-02-23 16:18   ` Philippe Mathieu-Daudé
2022-02-24  1:49     ` wliang
2022-02-23 17:39   ` Eric Auger
2022-02-25  3:58     ` wliang
2022-04-06 11:21       ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220406040445-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wliang@stu.xidian.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).