From: Vladimir Sementsov-Ogievskiy <vladimir.sementsov-ogievskiy@openvz.org>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, v.sementsov-og@mail.ru, jsnow@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com, hreitz@redhat.com,
vsementsov@openvz.org, stefanha@redhat.com, eblake@redhat.com
Subject: [PATCH v3 0/7] copy-before-write: on-cbw-error and cbw-timeout
Date: Wed, 6 Apr 2022 21:07:54 +0300 [thread overview]
Message-ID: <20220406180801.374844-1-vsementsov@openvz.org> (raw)
Hi all!
v3:
01: refactor options parsing
02: - wording, grammar
- early return from cbw_do_copy_before_write() when snapshot_error is set
- drop premature optimization around waiting for in-flight requests when
we set snapshot_error
03: Hanna's r-b
05: - add callback to block_copy() interface
- add forgotten g_free(call_state)
- do cancel block-copy call on timeout
06: - wording
- increase in_flight for block_copy(), to handle timed-out block_copy()
on drain
07: - less strict limit for bps-write, as now we honestly wait for cancelled
block-copy call on final drain
Here are two new options for copy-before-write filter:
on-cbw-error allows to alter the behavior on copy-before-write operation
failure: not break guest write but break the snapshot (and therefore
backup process)
cbw-timeout allows to limit cbw operation by some timeout.
So, for example, using cbw-timeout=60 and on-cbw-error=break-snapshot
you can be sure that guest write will not stuck for more than 60
seconds and will never fail due to backup problems.
Based-on: <20220406153202.332186-1-vsementsov@openvz.org>
( [PATCH for-7.1 0/2] throttle-groups: use QEMU_CLOCK_REALTIME )
Vladimir Sementsov-Ogievskiy (7):
block/copy-before-write: refactor option parsing
block/copy-before-write: add on-cbw-error open parameter
iotests: add copy-before-write: on-cbw-error tests
util: add qemu-co-timeout
block/block-copy: block_copy(): add timeout_ns parameter
block/copy-before-write: implement cbw-timeout option
iotests: copy-before-write: add cases for cbw-timeout option
qapi/block-core.json | 31 ++-
include/block/block-copy.h | 4 +-
include/qemu/coroutine.h | 13 ++
block/block-copy.c | 33 ++-
block/copy-before-write.c | 110 +++++++---
util/qemu-co-timeout.c | 89 ++++++++
tests/qemu-iotests/tests/copy-before-write | 206 ++++++++++++++++++
.../qemu-iotests/tests/copy-before-write.out | 5 +
util/meson.build | 1 +
9 files changed, 453 insertions(+), 39 deletions(-)
create mode 100644 util/qemu-co-timeout.c
create mode 100755 tests/qemu-iotests/tests/copy-before-write
create mode 100644 tests/qemu-iotests/tests/copy-before-write.out
--
2.35.1
next reply other threads:[~2022-04-06 18:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 18:07 Vladimir Sementsov-Ogievskiy [this message]
2022-04-06 18:07 ` [PATCH v3 1/7] block/copy-before-write: refactor option parsing Vladimir Sementsov-Ogievskiy
2022-04-07 7:08 ` Hanna Reitz
2022-04-06 18:07 ` [PATCH v3 2/7] block/copy-before-write: add on-cbw-error open parameter Vladimir Sementsov-Ogievskiy
2022-04-07 8:22 ` Hanna Reitz
2022-04-06 18:07 ` [PATCH v3 3/7] iotests: add copy-before-write: on-cbw-error tests Vladimir Sementsov-Ogievskiy
2022-04-06 18:07 ` [PATCH v3 4/7] util: add qemu-co-timeout Vladimir Sementsov-Ogievskiy
2022-04-07 9:20 ` Hanna Reitz
2022-04-06 18:07 ` [PATCH v3 5/7] block/block-copy: block_copy(): add timeout_ns parameter Vladimir Sementsov-Ogievskiy
2022-04-07 9:20 ` Hanna Reitz
2022-04-06 18:08 ` [PATCH v3 6/7] block/copy-before-write: implement cbw-timeout option Vladimir Sementsov-Ogievskiy
2022-04-07 9:20 ` Hanna Reitz
2022-04-06 18:08 ` [PATCH v3 7/7] iotests: copy-before-write: add cases for " Vladimir Sementsov-Ogievskiy
2022-04-07 9:19 ` Hanna Reitz
2022-04-07 10:54 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406180801.374844-1-vsementsov@openvz.org \
--to=vladimir.sementsov-ogievskiy@openvz.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=v.sementsov-og@mail.ru \
--cc=vsementsov@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).