From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Alistair Francis <alistair.francis@opensource.wdc.com>
Cc: peter.maydell@linaro.org,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>,
qemu-riscv@nongnu.org, Alistair Francis <alistair@alistair23.me>,
richard.henderson@linaro.org, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, Palmer Dabbelt <palmer@dabbelt.com>,
alistair23@gmail.com, bmeng.cn@gmail.com
Subject: Re: [PATCH v2 0/6] hw/riscv: Add TPM support to the virt board
Date: Thu, 7 Apr 2022 15:30:59 +0200 [thread overview]
Message-ID: <20220407133059.GG3143488@toto> (raw)
In-Reply-To: <20220407020432.4062829-1-alistair.francis@opensource.wdc.com>
On Thu, Apr 07, 2022 at 12:04:26PM +1000, Alistair Francis wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
>
> This series adds support for connecting TPM devices to the RISC-V virt
> board. This is similar to how it works for the ARM virt board.
>
> This was tested by first creating an emulated TPM device:
>
> swtpm socket --tpm2 -t -d --tpmstate dir=/tmp/tpm \
> --ctrl type=unixio,path=swtpm-sock
>
> Then launching QEMU with:
>
> -chardev socket,id=chrtpm,path=swtpm-sock \
> -tpmdev emulator,id=tpm0,chardev=chrtpm \
> -device tpm-tis-device,tpmdev=tpm0
>
> The TPM device can be seen in the memory tree and the generated device
> tree.
Hi Alistair!
You've got a typo in the subject of patch 4/6 "generating".
On the series:
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
Cheers,
Edgar
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/942
>
> Alistair Francis (6):
> hw/riscv: virt: Add a machine done notifier
> hw/core: Move the ARM sysbus-fdt to core
> hw/riscv: virt: Create a platform bus
> hw/riscv: virt: Add support for generateing platform FDT entries
> hw/riscv: virt: Add device plug support
> hw/riscv: Enable TPM backends
>
> include/hw/{arm => core}/sysbus-fdt.h | 0
> include/hw/riscv/virt.h | 8 +-
> hw/arm/virt.c | 2 +-
> hw/arm/xlnx-versal-virt.c | 1 -
> hw/{arm => core}/sysbus-fdt.c | 2 +-
> hw/riscv/virt.c | 312 +++++++++++++++++---------
> hw/arm/meson.build | 1 -
> hw/core/meson.build | 1 +
> hw/riscv/Kconfig | 2 +
> 9 files changed, 221 insertions(+), 108 deletions(-)
> rename include/hw/{arm => core}/sysbus-fdt.h (100%)
> rename hw/{arm => core}/sysbus-fdt.c (99%)
>
> --
> 2.35.1
>
prev parent reply other threads:[~2022-04-07 13:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 2:04 [PATCH v2 0/6] hw/riscv: Add TPM support to the virt board Alistair Francis
2022-04-07 2:04 ` [PATCH v2 1/6] hw/riscv: virt: Add a machine done notifier Alistair Francis
2022-04-15 15:25 ` Andrew Bresticker
2022-04-19 4:50 ` Alistair Francis
2022-04-07 2:04 ` [PATCH v2 2/6] hw/core: Move the ARM sysbus-fdt to core Alistair Francis
2022-04-07 2:04 ` [PATCH v2 3/6] hw/riscv: virt: Create a platform bus Alistair Francis
2022-04-07 2:04 ` [PATCH v2 4/6] hw/riscv: virt: Add support for generateing platform FDT entries Alistair Francis
2022-04-07 2:04 ` [PATCH v2 5/6] hw/riscv: virt: Add device plug support Alistair Francis
2022-04-07 2:04 ` [PATCH v2 6/6] hw/riscv: Enable TPM backends Alistair Francis
2022-04-07 13:30 ` Edgar E. Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407133059.GG3143488@toto \
--to=edgar.iglesias@gmail.com \
--cc=alistair.francis@opensource.wdc.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=bin.meng@windriver.com \
--cc=bmeng.cn@gmail.com \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).