From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
slp@redhat.com, mathieu.poirier@linaro.org, mst@redhat.com,
viresh.kumar@linaro.org, stefanha@redhat.com,
"Paolo Bonzini" <pbonzini@redhat.com>,
marcandre.lureau@redhat.com,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [RFC PATCH] tests/qtest: pass stdout/stderr down to subtests
Date: Thu, 7 Apr 2022 16:00:42 +0100 [thread overview]
Message-ID: <20220407150042.2338562-1-alex.bennee@linaro.org> (raw)
When trying to work out what the virtio-net-tests where doing it was
hard because the g_test_trap_subprocess redirects all output to
/dev/null. Lift this restriction by using the appropriate flags so you
can see something similar to what the vhost-user-blk tests show when
running.
While we are at it remove the g_test_verbose() check so we always show
how the QEMU is run.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/qtest/qos-test.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c
index f97d0a08fd..c6c196cc95 100644
--- a/tests/qtest/qos-test.c
+++ b/tests/qtest/qos-test.c
@@ -89,9 +89,7 @@ static void qos_set_machines_devices_available(void)
static void restart_qemu_or_continue(char *path)
{
- if (g_test_verbose()) {
- qos_printf("Run QEMU with: '%s'\n", path);
- }
+ qos_printf("Run QEMU with: '%s'\n", path);
/* compares the current command line with the
* one previously executed: if they are the same,
* don't restart QEMU, if they differ, stop previous
@@ -185,7 +183,8 @@ static void run_one_test(const void *arg)
static void subprocess_run_one_test(const void *arg)
{
const gchar *path = arg;
- g_test_trap_subprocess(path, 0, 0);
+ g_test_trap_subprocess(path, 0,
+ G_TEST_SUBPROCESS_INHERIT_STDOUT | G_TEST_SUBPROCESS_INHERIT_STDERR);
g_test_trap_assert_passed();
}
--
2.30.2
next reply other threads:[~2022-04-07 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 15:00 Alex Bennée [this message]
2022-04-14 17:25 ` [RFC PATCH] tests/qtest: pass stdout/stderr down to subtests Eric Auger
2022-04-21 12:44 ` Stefan Hajnoczi
2022-04-21 13:57 ` Alex Bennée
2022-05-18 7:34 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407150042.2338562-1-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).