From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76838C433F5 for ; Mon, 11 Apr 2022 02:09:36 +0000 (UTC) Received: from localhost ([::1]:52236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndjUl-0003CT-9k for qemu-devel@archiver.kernel.org; Sun, 10 Apr 2022 22:09:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndjU8-0002Ks-24; Sun, 10 Apr 2022 22:08:56 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:45013) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndjU4-0006s8-JG; Sun, 10 Apr 2022 22:08:55 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 23B1txrM053510; Mon, 11 Apr 2022 09:55:59 +0800 (GMT-8) (envelope-from jamin_lin@aspeedtech.com) Received: from aspeedtech.com (192.168.70.87) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 11 Apr 2022 10:07:34 +0800 Date: Mon, 11 Apr 2022 10:07:29 +0800 From: Jamin Lin To: =?utf-8?Q?C=C3=A9dric?= Le Goater Subject: Re: [PATCH v5 0/9] Add support for AST1030 SoC Message-ID: <20220411020727.GA2461@aspeedtech.com> References: <20220401083850.15266-1-jamin_lin@aspeedtech.com> <66783c6a-4942-23c5-1052-0dcab389e177@kaod.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <66783c6a-4942-23c5-1052-0dcab389e177@kaod.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.70.87] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 23B1txrM053510 Received-SPF: pass client-ip=211.20.114.71; envelope-from=jamin_lin@aspeedtech.com; helo=twspam01.aspeedtech.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, SCC_BODY_URI_ONLY=0.833, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Troy Lee , Beraldo Leal , Andrew Jeffery , Alistair Francis , Steven Lee , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , "open list:All patches CC here" , "open list:STM32F205" , Joel Stanley , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The 04/05/2022 16:12, Cédric Le Goater wrote: Hi Cedric, > Hello Jamin, > > On 4/1/22 10:38, Jamin Lin wrote: > > Changes from v5: > > - remove TYPE_ASPEED_MINIBMC_MACHINE and ASPEED_MINIBMC_MACHINE > > - remove ast1030_machine_instance_init function > > > > Changes from v4: > > - drop the ASPEED_SMC_FEATURE_WDT_CONTROL flag in hw/ssi/aspeed_smc.c > > > > Changes from v3: > > - remove AspeedMiniBmcMachineState state structure and > > AspeedMiniBmcMachineClass class > > - remove redundant new line in hw/arm/aspeed_ast10xx.c > > Do we want to be in sync with the zephyr naming and use ast10x0.c ? > > https://github.com/zephyrproject-rtos/zephyr/tree/main/soc/arm/aspeed > We used aspeed_ast10xx.c to support minibmc family such as ast1030 and may support ast1060 in the future. If need, I can submit the new patch to change its filename to aspeed_ast10x0.c. Thanks-Jamin > This is just a question. Don't resend for this. > > Thanks, > > C.